docs(CLI): the LAG cap refusal is typed at a port that is not in the bundle yet #2033

Closed
jaylouisw wants to merge 1 commit from docs/1118-2047 into main
Owner

The transcript in the A bundle carries eight links; the rest wait as (H) section showed channel-group 1 mode on typed at Gi1/0/9 straight after Gi1/0/9 joined the group as hot-standby, with the cap refusal printed over it.

Replayed against engine/cli.js (#2024), that line does not refuse. _channelGroup() compares the cap only on the joining path — the branch is guarded by alreadyIn, so a port that is already a member skips it. On Gi1/0/9 the console instead converts the group (Channel group 1 mode changed from active to on for every member: Gi1/0/1, Gi1/0/2, …) and adds the port; the group then holds ten members in a static (mode on) mode whose own refusal says eight at most.

This change:

  • types the refusal where the console really gives it — interface Gi1/0/11, the eleventh socket, outside the ten-member LACP bundle — so the block replays prompt for prompt;
  • records the gap the old example hid: a static bundle past the cap is still reachable through the mode conversion, which is the engine's half to close.

Docs only. docs/CLI.md.

Gates: scripts/syntax-check.js 423 files OK; check-control-bytes clean; docs-commands 7/7 (59 forms, 118 commands, 74 refusals); help-coverage 8/8 (102 advertised commands, 16 show commands); docs-syntax (CLI transcript) 4/4; help-forms (help-key 40, no-form 81, 10/10).

The transcript in the `A bundle carries eight links; the rest wait as (H)` section showed `channel-group 1 mode on` typed at **Gi1/0/9** straight after Gi1/0/9 joined the group as hot-standby, with the cap refusal printed over it. Replayed against `engine/cli.js` (#2024), that line does not refuse. `_channelGroup()` compares the cap only on the joining path — the branch is guarded by `alreadyIn`, so a port that is already a member skips it. On Gi1/0/9 the console instead converts the group (`Channel group 1 mode changed from active to on for every member: Gi1/0/1, Gi1/0/2, …`) and adds the port; the group then holds ten members in a static (`mode on`) mode whose own refusal says eight at most. This change: * types the refusal where the console really gives it — `interface Gi1/0/11`, the eleventh socket, outside the ten-member LACP bundle — so the block replays prompt for prompt; * records the gap the old example hid: a static bundle past the cap is still reachable through the mode conversion, which is the engine's half to close. Docs only. `docs/CLI.md`. Gates: `scripts/syntax-check.js` 423 files OK; `check-control-bytes` clean; docs-commands 7/7 (59 forms, 118 commands, 74 refusals); help-coverage 8/8 (102 advertised commands, 16 show commands); docs-syntax (CLI transcript) 4/4; help-forms (help-key 40, no-form 81, 10/10).
docs(CLI): the LAG cap refusal is typed at a port that is not in the bundle yet (#2024's page)
All checks were successful
CI / Classify the change (pull_request) Successful in 6s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 7s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 20s
CI / Test (Node 20) (pull_request) Successful in 53s
CI / Test (Node 22) (pull_request) Successful in 54s
CI / Test (Node 18) (pull_request) Successful in 1m0s
CI / Arm auto-merge (pull_request) Successful in 55s
7554f9af5b
The transcript in 'A bundle carries eight links' showed `channel-group 1 mode on`
typed at Gi1/0/9 immediately after Gi1/0/9 joined the group as hot-standby, and
printed the cap refusal over it. Replayed against engine/cli.js that line does
not refuse: `_channelGroup()` skips the cap when the port is already a member
(`alreadyIn`), so the console converts the group's mode for every member
("Channel group 1 mode changed from active to on for every member: ...") and
adds the port. The refusal is only given to a port that is not in the bundle.

The example now types the refusal where the console gives it - `interface
Gi1/0/11`, eleventh socket, outside the ten-member LACP bundle - and the page
records the hole the old transcript hid: the mode conversion leaves a static
bundle holding ten members in a mode whose own sentence says eight at most.
forgejo-actions force-pushed docs/1118-2047 from 7554f9af5b
All checks were successful
CI / Classify the change (pull_request) Successful in 6s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 7s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 20s
CI / Test (Node 20) (pull_request) Successful in 53s
CI / Test (Node 22) (pull_request) Successful in 54s
CI / Test (Node 18) (pull_request) Successful in 1m0s
CI / Arm auto-merge (pull_request) Successful in 55s
to 022b1ea0e8 2026-11-18 20:56:57 +00:00
Compare
forgejo-actions force-pushed docs/1118-2047 from 022b1ea0e8 to a23f9573a8
All checks were successful
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 6s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 18) (pull_request) Successful in 55s
CI / Test (Node 20) (pull_request) Successful in 50s
CI / Test (Node 22) (pull_request) Successful in 51s
CI / Arm auto-merge (pull_request) Successful in 2s
2026-11-18 21:12:33 +00:00
Compare
forgejo-actions force-pushed docs/1118-2047 from a23f9573a8
All checks were successful
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 6s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 18) (pull_request) Successful in 55s
CI / Test (Node 20) (pull_request) Successful in 50s
CI / Test (Node 22) (pull_request) Successful in 51s
CI / Arm auto-merge (pull_request) Successful in 2s
to 6f60f521f3 2026-11-18 21:19:15 +00:00
Compare
Author
Owner

Queue livelock — measured, not inferred. This PR has now been rebased out from under three green runs in 40 minutes:

time (Z) event head
20:56 PR opened, CI green 8/8 7554f9af
21:00 Auto-rebase force-push 022b1ea0 — 0 statuses
21:14 closed+reopened by surgery, CI green 8/8 a23f9573
21:15 squash-merge of #2020 moves main → Auto-rebase force-push 6f60f521 → 8c4cc9b2 → 03ce6c46, 0 statuses

Every push auto-rebase.yml makes lands as an action-token push, which does not raise a synchronize event, so no CI runs on the SHA the bot mints. workflow_dispatch does not help either: run 7058 ran against ed1ef529 and wrote zero commit statuses (checked GET /commits/ed1ef529/statuses → []), so only a pull_request event produces checks. Net effect: the queue can only ever land the one PR that is newest when main moves — 4 of 5 merges this hour needed a manual close+reopen to be green at all.

Needs Jay's decision: in auto-rebase.yml, after git push --force-with-lease, either (a) push with a PAT instead of the action token so the push carries a real synchronize event, or (b) POST /actions/workflows/ci.yml/dispatches on the branch — which needs (a) to work anyway, since the dispatch itself is token-authenticated. Nothing on the PR side can fix it.

**Queue livelock — measured, not inferred.** This PR has now been rebased out from under three green runs in 40 minutes: | time (Z) | event | head | |---|---|---| | 20:56 | PR opened, CI green 8/8 | `7554f9af` | | 21:00 | Auto-rebase force-push | `022b1ea0` — 0 statuses | | 21:14 | closed+reopened by surgery, CI green 8/8 | `a23f9573` | | 21:15 | squash-merge of #2020 moves `main` → Auto-rebase force-push | `6f60f521` → `8c4cc9b2` → `03ce6c46`, 0 statuses | Every push `auto-rebase.yml` makes lands as an action-token push, which does not raise a `synchronize` event, so no CI runs on the SHA the bot mints. `workflow_dispatch` does not help either: run 7058 ran against `ed1ef529` and wrote **zero** commit statuses (checked `GET /commits/ed1ef529/statuses` → `[]`), so only a `pull_request` event produces checks. Net effect: the queue can only ever land the one PR that is newest when `main` moves — 4 of 5 merges this hour needed a manual close+reopen to be green at all. **Needs Jay's decision:** in `auto-rebase.yml`, after `git push --force-with-lease`, either (a) push with a PAT instead of the action token so the push carries a real `synchronize` event, or (b) `POST /actions/workflows/ci.yml/dispatches` on the branch — which needs (a) to work anyway, since the dispatch itself is token-authenticated. Nothing on the PR side can fix it.
Author
Owner

Third reproduction, and the trigger is now unambiguous: the merge itself.

This PR's head was one of the four that lost its checks in the last hour. Timeline from this run:

  • 21:38:30Z — I rebased #2039 (catalogue/1118-2122) onto a603c7f7 (only conflict: the generated docs/DEVICE_REGISTRY.md; regenerated with scripts/regen-registry-doc.js), force-pushed 88c14f42 → 8cf7efa9. Eight statuses were created on the new head inside 20 s and all went green (Node 18/20/22 59/51/53 s).
  • 21:40:1xZ — squash-merged #2039 as 63dc0b56 on an 8/8-green head with mergeable: true.
  • 21:40:5xZ → 21:41:2xZ — every remaining open branch was force-pushed by auto-rebase.yml:
PR before after statuses on new head
#2038 7eff4559 b5bc0546 0
#2037 2fd93023 a1cd97da 0
#2035 7290295e 0b234377 0
#2033 03ce6c46 ebaefddd 0

So the accounting is now: one merge costs four CI runs, and none of the four can be merged until its checks exist again, which only a close+reopen (or a new push) produces — and the next merge wipes them again. The queue can be drained one PR per cycle at best, and only by paying 4 wasted workflow runs each time.

Nothing in the PRs fixes this; auto-rebase.yml needs to push with a token whose push triggers CI, or dispatch CI explicitly after its push (a plain workflow_dispatch writes zero statuses — measured on run 7058, /statuses = []). That is a one-line change to a workflow file, which is Jay's to make — I am not permitted to edit .forgejo/workflows/.

Also this run: #2032 closed as superseded — #2036 (80bb55fe) landed the same scoping fix and an equivalent docs/__stray_stale.md regression block, and #2030 closed with it.

**Third reproduction, and the trigger is now unambiguous: the merge itself.** This PR's head was one of the four that lost its checks in the last hour. Timeline from this run: - 21:38:30Z — I rebased #2039 (`catalogue/1118-2122`) onto `a603c7f7` (only conflict: the generated `docs/DEVICE_REGISTRY.md`; regenerated with `scripts/regen-registry-doc.js`), force-pushed `88c14f42` → `8cf7efa9`. Eight statuses were created on the new head inside 20 s and all went green (Node 18/20/22 59/51/53 s). - 21:40:1xZ — squash-merged #2039 as **63dc0b56** on an 8/8-green head with `mergeable: true`. - 21:40:5xZ → 21:41:2xZ — every remaining open branch was force-pushed by `auto-rebase.yml`: | PR | before | after | statuses on new head | |---|---|---|---| | #2038 | 7eff4559 | b5bc0546 | 0 | | #2037 | 2fd93023 | a1cd97da | 0 | | #2035 | 7290295e | 0b234377 | 0 | | #2033 | 03ce6c46 | ebaefddd | 0 | So the accounting is now: **one merge costs four CI runs**, and none of the four can be merged until its checks exist again, which only a close+reopen (or a new push) produces — and the next merge wipes them again. The queue can be drained one PR per cycle at best, and only by paying 4 wasted workflow runs each time. Nothing in the PRs fixes this; `auto-rebase.yml` needs to push with a token whose push triggers CI, or dispatch CI explicitly after its push (a plain `workflow_dispatch` writes zero statuses — measured on run 7058, `/statuses` = `[]`). That is a one-line change to a workflow file, which is Jay's to make — I am not permitted to edit `.forgejo/workflows/`. Also this run: #2032 closed as superseded — #2036 (80bb55fe) landed the same scoping fix and an equivalent `docs/__stray_stale.md` regression block, and #2030 closed with it.
Author
Owner

22:07Z — fourth reproduction, and the effect is now measurable, not just predictable.

Merged three green PRs back-to-back in one burst (#2043 → 090a1a96, #2042 → eabef2cc, #2041 → 5e6bc405). Within ~60 s the push-triggered auto-rebase pass had force-pushed every remaining head onto the new main and reset all five to zero statuses:

  • #2040 55316211 → 816c1f38
  • #2038 b5bc0546 → 1169554d
  • #2037 a1cd97da → bf3f2220
  • #2035 0b234377 → 6320501e
  • #2033 ebaefddd → 9df7b89b

The important number: three merges cost one rebase pass (5 CI matrices), not three passes (15). A rebase after main moves is unavoidable, so the cost per merge is batch / merges_per_burst. Burst-merging every green PR in the same tick is the cheapest way to drain the queue; merging one PR per tick pays a full batch for each.

Secondary cost, visible right now: the rebased heads sit at total_count: 0 for minutes afterwards because the single runner is still working through main's own matrix (Node 18/20/22 all running). Zero statuses on a fresh head is "queued behind main", not "CI lost it" — I read that as red for merge purposes and wait for the next tick.

**22:07Z — fourth reproduction, and the effect is now measurable, not just predictable.** Merged three green PRs back-to-back in one burst (#2043 → `090a1a96`, #2042 → `eabef2cc`, #2041 → `5e6bc405`). Within ~60 s the push-triggered `auto-rebase` pass had force-pushed every remaining head onto the new main and reset all five to zero statuses: - #2040 `55316211` → `816c1f38` - #2038 `b5bc0546` → `1169554d` - #2037 `a1cd97da` → `bf3f2220` - #2035 `0b234377` → `6320501e` - #2033 `ebaefddd` → `9df7b89b` The important number: **three merges cost one rebase pass (5 CI matrices), not three passes (15)**. A rebase after main moves is unavoidable, so the cost per merge is `batch / merges_per_burst`. Burst-merging every green PR in the same tick is the cheapest way to drain the queue; merging one PR per tick pays a full batch for each. Secondary cost, visible right now: the rebased heads sit at `total_count: 0` for minutes afterwards because the single runner is still working through main's own matrix (Node 18/20/22 all `running`). Zero statuses on a fresh head is "queued behind main", not "CI lost it" — I read that as red for merge purposes and wait for the next tick.
jaylouisw force-pushed docs/1118-2047 from 1682a72981 to 24344236ad
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 6s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 18) (pull_request) Successful in 1m19s
CI / Test (Node 20) (pull_request) Failing after 1m2s
CI / Test (Node 22) (pull_request) Failing after 1m4s
CI / Arm auto-merge (pull_request) Successful in 4s
2026-11-18 22:47:21 +00:00
Compare
jaylouisw force-pushed docs/1118-2047 from 24344236ad
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 6s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 18) (pull_request) Successful in 1m19s
CI / Test (Node 20) (pull_request) Failing after 1m2s
CI / Test (Node 22) (pull_request) Failing after 1m4s
CI / Arm auto-merge (pull_request) Successful in 4s
to 030e397fe4
All checks were successful
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 4s
CI / Classify the change (pull_request) Successful in 8s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 18) (pull_request) Successful in 59s
CI / Test (Node 20) (pull_request) Successful in 50s
CI / Test (Node 22) (pull_request) Successful in 50s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-18 23:04:56 +00:00
Compare
Author
Owner

Needs Jay's decision — prose conflict in docs/CLI.md, not mechanical

This branch was green on all three Node legs at 030e397f, but it can no longer be merged: #2035 and then #2037 (commit 06da3f7d, "the EtherChannel receipts are two sessions, not one") landed in the same paragraph of docs/CLI.md while this PR was open. A rebase onto 06da3f7d gives one conflicted file, docs/CLI.md, with two hunks:

  1. A lead-in line vs the commands that follow it — mechanical, both sides keepable:
<<<<<<< HEAD
and on a group already holding eight `mode on` members, which has nowhere to park a ninth:

=======
sw1(config-if)#exit
sw1(config)#interface Gi1/0/11

030e397f

2. Two competing explanations of the same behaviour — **this is the decision**:

<<<<<<< HEAD (#2037, 06da3f7d)
The mode belongs to the group, not to the member: typed on a port that is already in that group, the line
re-modes every member (...) rather than refusing the port, because the cap is checked when a port joins.
======= (this PR)
The refusal is asked of a port that is not in the bundle yet - Gi1/0/11 above (...) The cap is compared
on the joining path only - _channelGroup() skips it when the port is already a member - so a static bundle
past the cap is still reachable through the mode conversion. That half is the engine's to close; [...]

030e397f


What I verified: this PR's `docs/CLI.md` passes `test/docs-cli-transcript.test.js` (4/4) against the current engine, so its transcript is what the console really prints; `#2037`'s wording is also main-current. `test/lag-mode.test.js` pins the mode conversion itself and passes either way, so no test decides this.

Decision needed: does this PR's revised paragraph (and its claim that the cap gap through mode conversion is still open) supersede `#2037`'s sentence, or should `#2037`'s wording stand and this PR be reduced to its transcript change? I did not resolve it — choosing between two behaviour descriptions is not a mechanical merge. Once decided, the rebase is a 2-minute job.
**Needs Jay's decision — prose conflict in `docs/CLI.md`, not mechanical** This branch was green on all three Node legs at `030e397f`, but it can no longer be merged: `#2035` and then `#2037` (commit `06da3f7d`, "the EtherChannel receipts are two sessions, not one") landed in the same paragraph of `docs/CLI.md` while this PR was open. A rebase onto `06da3f7d` gives one conflicted file, `docs/CLI.md`, with two hunks: 1. A lead-in line vs the commands that follow it — mechanical, both sides keepable: ``` <<<<<<< HEAD and on a group already holding eight `mode on` members, which has nowhere to park a ninth: ``` ======= sw1(config-if)#exit sw1(config)#interface Gi1/0/11 >>>>>>> 030e397f ``` 2. Two competing explanations of the same behaviour — **this is the decision**: ``` <<<<<<< HEAD (#2037, 06da3f7d) The mode belongs to the group, not to the member: typed on a port that is already in that group, the line re-modes every member (...) rather than refusing the port, because the cap is checked when a port joins. ======= (this PR) The refusal is asked of a port that is **not in the bundle yet** - Gi1/0/11 above (...) The cap is compared on the joining path only - `_channelGroup()` skips it when the port is already a member - so a static bundle past the cap is still reachable through the mode conversion. That half is the engine's to close; [...] >>>>>>> 030e397f ``` What I verified: this PR's `docs/CLI.md` passes `test/docs-cli-transcript.test.js` (4/4) against the current engine, so its transcript is what the console really prints; `#2037`'s wording is also main-current. `test/lag-mode.test.js` pins the mode conversion itself and passes either way, so no test decides this. Decision needed: does this PR's revised paragraph (and its claim that the cap gap through mode conversion is still open) supersede `#2037`'s sentence, or should `#2037`'s wording stand and this PR be reduced to its transcript change? I did not resolve it — choosing between two behaviour descriptions is not a mechanical merge. Once decided, the rebase is a 2-minute job.
Author
Owner

surgery run 2026-11-19 03:0xZ — needs Jay's decision (docs text is now stale, not a rebase).

origin/main f1d8cfa5 (PR #2069, "etherchannel: a group too wide for its new mode is refused, not converted") landed the engine half and a docs/CLI.md paragraph at the later occurrence of this example. This PR's added paragraph at docs/CLI.md:2096-2106 still says:

The cap is compared on the joining path only … so a static bundle past the cap is still reachable through the mode conversion. That half is the engine's to close

f1d8cfa5 closes exactly that half: engine/cli.js now refuses the mode conversion and the page documents the refusal (% Channel group 1 not moved to mode on: it holds 9 members …).

So the rebase conflict in docs/CLI.md cannot be resolved mechanically — resolving it either drops this PR's Gi1/0/11 example or keeps a sentence main has just made false. It needs the author (or Jay) to rewrite the closing paragraph against the new behaviour; the Gi1/0/11 example itself is still a good edit.

I did not rebase, merge or close it. It is green on d0579f8c and 20 behind main; mergeable=false is the real conflict above, not a stale computation.

**surgery run 2026-11-19 03:0xZ — needs Jay's decision (docs text is now stale, not a rebase).** `origin/main` `f1d8cfa5` (PR #2069, "etherchannel: a group too wide for its new mode is refused, not converted") landed the engine half *and* a docs/CLI.md paragraph at the later occurrence of this example. This PR's added paragraph at `docs/CLI.md:2096-2106` still says: > The cap is compared on the joining path only … so a static bundle past the cap is still reachable through the mode conversion. **That half is the engine's to close** `f1d8cfa5` closes exactly that half: `engine/cli.js` now refuses the mode conversion and the page documents the refusal (`% Channel group 1 not moved to mode on: it holds 9 members …`). So the rebase conflict in `docs/CLI.md` cannot be resolved mechanically — resolving it either drops this PR's Gi1/0/11 example or keeps a sentence main has just made false. It needs the author (or Jay) to rewrite the closing paragraph against the new behaviour; the Gi1/0/11 example itself is still a good edit. I did not rebase, merge or close it. It is green on `d0579f8c` and 20 behind main; `mergeable=false` is the real conflict above, not a stale computation.
Author
Owner

surgery run 2026-11-19 04:0xZ — half of this PR has landed, half has not; still Jay's text call.

Probed engine/cli.js on current main 06830e13 (9 LACP members, then channel-group 1 mode on typed at a member):

members: 9 mode: lacp-active
% Channel group 1 not moved to mode on: it holds 9 members, and a static (`mode on`) bundle carries at most 8
  links, with no hot-standby to park the extra member in. Keep `channel-group 1 mode active`, or remove a member
  first. Nothing was changed.
after: members 9 mode lacp-active

So the engine gap this PR argues for — "the cap is compared on the joining path only ... that half is the engine's to close" — is already closed, by f1d8cfa5 ("etherchannel: a group too wide for its new mode is refused, not converted (#2033) (#2069)"), which names this PR and adds the guard at engine/cli.js:3521, a test, and main's "The mode belongs to the group ..." paragraph. That paragraph of this PR is now wrong on the fact, not just on wording.

What still stands is the first half: main's join-refusal fence prints sw1(config-if)#channel-group 1 mode on → % Gi1/0/9 not added, but the port in that context is already the ninth member, so the block does not replay — the console gives the mode-change refusal instead. This PR's exit / interface Gi1/0/11 lines are the fix for that.

Resolution, for the author (not surgery — it drops parts of two hunks): keep main's mode-change paragraph and its refusal block whole; take this PR's two prompt lines for the join fence; drop this PR's closing paragraph. One commit, then it goes green and merges.

Conflict as it stands: 1 hunk in docs/CLI.md. Needs Jay's decision only because deleting a side of a hunk is a text call, not a mechanical rebase.

**surgery run 2026-11-19 04:0xZ — half of this PR has landed, half has not; still Jay's text call.** Probed `engine/cli.js` on current main `06830e13` (9 LACP members, then `channel-group 1 mode on` typed at a member): ``` members: 9 mode: lacp-active % Channel group 1 not moved to mode on: it holds 9 members, and a static (`mode on`) bundle carries at most 8 links, with no hot-standby to park the extra member in. Keep `channel-group 1 mode active`, or remove a member first. Nothing was changed. after: members 9 mode lacp-active ``` So the engine gap this PR argues for — "the cap is compared on the joining path only ... that half is the engine's to close" — **is already closed**, by `f1d8cfa5` ("etherchannel: a group too wide for its new mode is refused, not converted (#2033) (#2069)"), which names this PR and adds the guard at `engine/cli.js:3521`, a test, and main's "The mode belongs to the group ..." paragraph. That paragraph of this PR is now wrong on the fact, not just on wording. What still stands is the first half: main's join-refusal fence prints `sw1(config-if)#channel-group 1 mode on` → `% Gi1/0/9 not added`, but the port in that context is already the ninth member, so the block does not replay — the console gives the mode-change refusal instead. This PR's `exit` / `interface Gi1/0/11` lines are the fix for that. **Resolution, for the author (not surgery — it drops parts of two hunks):** keep main's mode-change paragraph and its refusal block whole; take this PR's two prompt lines for the join fence; drop this PR's closing paragraph. One commit, then it goes green and merges. Conflict as it stands: 1 hunk in `docs/CLI.md`. **Needs Jay's decision** only because deleting a side of a hunk is a text call, not a mechanical rebase.
Author
Owner

Needs Jay's decision — the rebase conflicts are a behaviour question, not a mechanical one.

Rebased onto main (8349c59d): two conflicting hunks in docs/CLI.md, both inside "A bundle carries eight links; the rest wait as (H)" (at the mode on refusal transcript, and at the paragraph explaining what happens when the line is typed on a port already in the group).

Why this is not mine to resolve: the premise of this PR — "the cap is compared on the joining path only — _channelGroup() skips it when the port is already a member (alreadyIn) — so a static bundle past the cap is still reachable through the mode conversion. That half is the engine's to close" — is no longer true on main. #2069 (f1d8cfa5, "etherchannel: a group too wide for its new mode is refused, not converted (#2033)") closed that half: engine/cli.js:3521 now has if (existing && alreadyIn && retuning && held > cap) and refuses the mode change with % Channel group 1 not moved to mode on: it holds 9 members, … Nothing was changed. Main's docs/CLI.md already prints that refusal, and its own transcript types the join refusal at Gi1/0/9.

So the PR now asserts something the engine does not do any more, and relocates the transcript to Gi1/0/11. Merging it as written would leave the page describing a gap that #2069 removed.

Decision: one of

  1. retire #2033 as superseded by #2069 (its remaining content is the Gi1/0/11 relocation, which main does not need), or
  2. keep the relocation and rewrite the surrounding paragraph for the post-#2069 engine — a docs wording call, not a rebase.

One thing worth a look while you are there: main's Gi1/0/9 block still reads % Gi1/0/9 not added: channel group 1 already holds 8 members, but in this section's state Gi1/0/9 already joined the LACP bundle (10 members), so post-#2069 that line would answer with the mode refusal, not the join one.

Verified on the rebased tree: syntax-check 443 files OK, check-control-bytes clean, audit-port-types clean, npm test 364 suites / 12,420 assertions green. Not pushed — no point putting a semantic answer on the branch.

**Needs Jay's decision** — the rebase conflicts are a behaviour question, not a mechanical one. Rebased onto `main` (`8349c59d`): two conflicting hunks in `docs/CLI.md`, both inside *"A bundle carries eight links; the rest wait as `(H)`"* (at the `mode on` refusal transcript, and at the paragraph explaining what happens when the line is typed on a port already in the group). **Why this is not mine to resolve:** the premise of this PR — *"the cap is compared on the joining path only — `_channelGroup()` skips it when the port is already a member (`alreadyIn`) — so a static bundle past the cap is still reachable through the mode conversion. That half is the engine's to close"* — is no longer true on main. **#2069** (`f1d8cfa5`, *"etherchannel: a group too wide for its new mode is refused, not converted (#2033)"*) closed that half: `engine/cli.js:3521` now has `if (existing && alreadyIn && retuning && held > cap)` and refuses the mode change with `% Channel group 1 not moved to mode on: it holds 9 members, … Nothing was changed.` Main's `docs/CLI.md` already prints that refusal, and its own transcript types the join refusal at `Gi1/0/9`. So the PR now asserts something the engine does not do any more, and relocates the transcript to `Gi1/0/11`. Merging it as written would leave the page describing a gap that #2069 removed. **Decision:** one of 1. retire #2033 as superseded by #2069 (its remaining content is the `Gi1/0/11` relocation, which main does not need), or 2. keep the relocation and rewrite the surrounding paragraph for the post-#2069 engine — a docs wording call, not a rebase. One thing worth a look while you are there: main's `Gi1/0/9` block still reads `% Gi1/0/9 not added: channel group 1 already holds 8 members`, but in this section's state `Gi1/0/9` already joined the LACP bundle (10 members), so post-#2069 that line would answer with the *mode* refusal, not the join one. Verified on the rebased tree: `syntax-check` 443 files OK, `check-control-bytes` clean, `audit-port-types` clean, `npm test` 364 suites / 12,420 assertions green. Not pushed — no point putting a semantic answer on the branch.
Author
Owner

The engine half of this landed in #2069, and main now carries the mode-change refusal paragraph and example. The transcript hunk here was written before that and does not apply: its Gi1/0/11 line names a group of eight while the section builds ten, and the message the console gives there is holds 10 members, and ... would make 11. The replayable version of that hunk — the Gi1/0/9 mode-change refusal, both standby receipts, and the Gi1/0/11 join refusal — is in #2112, with a replay test in test/docs-cli-transcript.test.js. This branch conflicts with main and is superseded on both halves.

The engine half of this landed in #2069, and `main` now carries the mode-change refusal paragraph and example. The transcript hunk here was written before that and does not apply: its Gi1/0/11 line names a group of eight while the section builds ten, and the message the console gives there is `holds 10 members, and ... would make 11`. The replayable version of that hunk — the Gi1/0/9 mode-change refusal, both standby receipts, and the Gi1/0/11 join refusal — is in #2112, with a replay test in `test/docs-cli-transcript.test.js`. This branch conflicts with `main` and is superseded on both halves.
Author
Owner

Closed as superseded — #2112 landed the same paragraph, written against the console.

a5baefc6 (#2112, "the eight-link example is typed at a port that is already in the bundle") rewrote the "A bundle carries eight links; the rest wait as (H)" example in docs/CLI.md to match what the engine actually prints:

  • both standby receipts (Gi1/0/9 and Gi1/0/10);
  • the mode-change refusal at the port that is already in the group, carrying the group's own count of ten;
  • the join refusal at Gi1/0/11, outside the ten-member bundle.

The engine half this PR argued was open was already closed by f1d8cfa5 (#2069); #2112's version is consistent with it and has a transcript test (test/docs-cli-transcript.test.js, 9 checks) asserting every page line is a line the console prints.

Verified before the merge: clean merge into 9574bdd5, transcript test 9/9, citation check clean (356 docs, 19 judged), CI 8/8 green on f1649220.

Reopen if you'd rather keep this PR's wording — nothing of it was merged.

**Closed as superseded — #2112 landed the same paragraph, written against the console.** `a5baefc6` (#2112, "the eight-link example is typed at a port that is already in the bundle") rewrote the *"A bundle carries eight links; the rest wait as `(H)`"* example in `docs/CLI.md` to match what the engine actually prints: * both standby receipts (Gi1/0/9 and Gi1/0/10); * the mode-change refusal at the port that is already in the group, carrying the group's own count of ten; * the join refusal at Gi1/0/11, outside the ten-member bundle. The engine half this PR argued was open was already closed by `f1d8cfa5` (#2069); #2112's version is consistent with it and has a transcript test (`test/docs-cli-transcript.test.js`, 9 checks) asserting every page line is a line the console prints. Verified before the merge: clean merge into `9574bdd5`, transcript test 9/9, citation check clean (356 docs, 19 judged), CI 8/8 green on `f1649220`. Reopen if you'd rather keep this PR's wording — nothing of it was merged.
jaylouisw closed this pull request 2026-11-19 07:13:34 +00:00
All checks were successful
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 4s
CI / Classify the change (pull_request) Successful in 8s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 18) (pull_request) Successful in 59s
CI / Test (Node 20) (pull_request) Successful in 50s
CI / Test (Node 22) (pull_request) Successful in 50s
CI / Arm auto-merge (pull_request) Successful in 3s

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2033
No description provided.