ci: a request closed by its own disclaimer - check the sentence before pushing #2020
No reviewers
Labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!2020
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "catalogue/1118-1906"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The forge closed two requests on their own disclaimers
Two merges today closed a
[Device]:request using a sentence that said the opposite, twoseconds after the merge, with no comment on the issue:
Neither of those was
scripts/close-merged-issues.js: that sweep posts a comment carrying itsmarker before it changes state, and neither issue has one. Both were the forge's own merge-time
parser reading a keyword next to a number - the mechanism that legitimately closed one issue from
#1635, doing the same thing to a sentence that disclaimed it.
The identical shape in #1867 ("Does not close something") and #1873 ("it does not close
the issue") closed nothing at all. So the forge's rule is not learnable from out here, and the
conclusion is not "write a better negation" - it is never put a closing keyword in a sentence
about a request you are not answering:
Refs #N- a reference with no closing keyword anywhere in the sentence;issue N- no#, so there is nothing for either parser to read.This pull request is written that way, which is why it names issue 803 and issue 130 rather than
quoting the two bodies faithfully.
What this adds
scripts/check-closing-keywords.js- reports every keyword-plus-number the forge could read asa close while this repository's rule would not, with the reason (
negated,mid-sentence,hypothetical), the line and the snippet.--pr Nreads a pull request body and its commitsfrom the forge;
--strictexits 1. Run against #2005 and #2000 it reproduces both closes, andagainst #1635 it reports one claim and no risk.
test/closing-keywords.test.js- 25 checks, including that the new rule andparseClosingKeywords()agree on every real body quoted indocs/CI.md, so the two cannotdrift apart.
docs/CI.md- a section recording both measurements and the two safe shapes; the paragraph thatused to say Forgejo had agreed about #742/#743 now says what it can: those two merges closed
nothing, which is not a rule.
scripts/close-merged-issues.js- the comment block that made the same claim, corrected. Nobehaviour change;
test/close-merged-issues.test.jsstill passes 81/81.Gates
No spec, no catalogue entry and no engine behaviour is touched: this is the queue machinery that
keeps the two open requests where a reader can find them.
The two requests this protects, for the record: #803 and #130.
baa7d488ab90260db88e90260db88etob252bb816cb252bb816cto6ac7e85f78Still no CI on this PR — and the cause is now visible.
b252bb81when I surveyed at 20:07Z; at 20:08:57Z the auto-rebase workflow pushed6ac7e85f(behind=0, ahead=1)./commits/<sha>/statusreturnstotal_count: 0, emptystate— not a failure, no run at all.pull_requestruns exist under this title (6987, 6988, bothsuccess), so the workflow can fire for this branch; they predate the rebase push.runningand 7015/7023waitingon sibling branches.Net effect: auto-rebase keeps minting a fresh head SHA which never receives a
pull_requestrun, so the PR can never go green and can never auto-merge — a livelock. Not touching the branch myself (nothing to rebase; it is already 0 behind). Needs-ci/Jay: why is no run queued for the post-rebase SHA.6ac7e85f78to2a0f890d3bSame shape as #2019, different ending: the rebase minted
6ac7e85fwith no run, but a close+reopen producedpull_requestruns 7055/7056 against head2a0f890d(mainc6053d2e, behind=0). It is queued behind a single runner, so it should go green on its own; no dispatch needed here.Root cause is in the rebase workflow, not this PR: pushes made with the auto-rebase action token do not re-trigger
ci.yml, so any SHA the bot mints is unbuildable. Noted on #2019 with the suggested fixes — needs Jay's decision on.forgejo/workflows/auto-rebase.yml.2a0f890d3bcc311e001acc311e001ato741ae00f9c