etherchannel: a group too wide for its new mode is refused, not converted (#2033) #2069
No reviewers
Labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!2069
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1119-0202"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Refs #2033 — this closes the engine half that issue recorded and left open, not its docs transcript.
What was wrong. The EtherChannel cap was checked only where a port joins. A mode change is the one line that rewrites the cap a group already holds under, and it was unguarded: nine members fit one LACP group (cap sixteen),
channel-group 1 mode ontyped on a member moved the group tomode on— cap eight — and left all nine in it. Three lies followed from that one state:show etherchannel summaryprinted nine members of a static bundle withPo1(SU), the ninth asGi1/0/9(s)stand-alone yet still a member;channel-group 1 mode onjoin was refused with "channel group 1 already holds 8 members" over a group holding nine — a number the operator cannot find anywhere;Gi1/0/9 is hot-standby, in a bundle whose own key line saysH - Hot-standby (LACP only).Changed
engine/cli.js(_channelGroup): a mode change that would leave the group holding more members than the new mode allows is refused, nothing changed, naming the count, the cap, and the form that keeps the bundle (channel-group 1 mode active). The join refusal now names the group's real count, and when the line also re-modes, says what the count would become. The hot-standby receipt is only printed for a negotiating bundle.docs/CLI.md: the paragraph that said the cap "is checked when a port joins" now says what is checked where, with the refusal transcript.test/etherchannel-member-limit.test.js: 14 new assertions (refusal and its wording, group untouched, table still LACP, all nine members present, the tenth-join count, and an eight-member group that still converts so the guard is about the overflow rather than about conversion).Gates.
node scripts/syntax-check.js— 433 files OK. Fullnpm test— 356 suites, 12294 assertions, 0 failed.Not done. The mode conversion of a group at the cap is still allowed in the other direction (
mode on→mode active) — the cap grows there. Nothing in this console lets a static bundle hold nine, so a saved config carrying one is now the only way to reach the state; the saver does not write one.ee7aa2a804f4b0186a98f4b0186a98todad118ffd4