test(canonical-urls): a stale URL elsewhere is reported once, not as three failed cleanups #2032
Closed
jaylouisw
wants to merge 1 commit from
fix/1118-2037 into main
pull from: fix/1118-2037
merge into: jaylouisw:main
jaylouisw:main
jaylouisw:rev/1121-1812
jaylouisw:catalogue/1121-1822
jaylouisw:docs/1121-1817
jaylouisw:catalogue/1121-1752
jaylouisw:docs/1121-1747
jaylouisw:rev/1121-1742
jaylouisw:catalogue/1121-1722
jaylouisw:rev/1121-1712
jaylouisw:docs/1121-1717
jaylouisw:catalogue/1121-1652
jaylouisw:rev/1121-1642
jaylouisw:docs/1121-1647
jaylouisw:ci/1121-1646
jaylouisw:ci/1121-1427
jaylouisw:rev/1121-1412
jaylouisw:catalogue/1121-1422
jaylouisw:docs/1121-1417
jaylouisw:catalogue/1121-1352
jaylouisw:rev/1121-1342
jaylouisw:docs/1121-1347
jaylouisw:rev/1121-1212
jaylouisw:catalogue/1121-1222
jaylouisw:docs/1121-1217
jaylouisw:ci/1121-1027
jaylouisw:catalogue/1121-1022
jaylouisw:rev/1121-1013
jaylouisw:docs/1121-1017
jaylouisw:catalogue/1121-0852
jaylouisw:rev/1121-0842
jaylouisw:docs/1121-0847
jaylouisw:ci/1121-0827
jaylouisw:catalogue/1121-0822
jaylouisw:rev/1121-0812
jaylouisw:catalogue/1121-0752
jaylouisw:rev/1121-0742
jaylouisw:docs/1121-0747
jaylouisw:catalogue/1121-0722
jaylouisw:docs/1121-0717
jaylouisw:rev/1121-0712
jaylouisw:rev/1121-0642
jaylouisw:plan/1121-0637
jaylouisw:ci/1121-0627
jaylouisw:catalogue/1121-0622
jaylouisw:rev/1121-0612
jaylouisw:docs/1121-0617
jaylouisw:plan/1120-0337
jaylouisw:docs/1120-0347
jaylouisw:rev/1119-1942
jaylouisw:rev/1119-1912
jaylouisw:catalogue/1119-1752
jaylouisw:docs/1119-1347
jaylouisw:catalogue/1119-1352
jaylouisw:fix/1119-1232
jaylouisw:fix/1119-0602
jaylouisw:catalogue/1119-0452
jaylouisw:catalogue/1119-0422
jaylouisw:docs/1119-0417
jaylouisw:fix/1119-0202
jaylouisw:catalogue/1119-0222
jaylouisw:rev/1119-0042
jaylouisw:catalogue/1118-2252
jaylouisw:docs/1118-2047
jaylouisw:catalogue/1118-2152
jaylouisw:ci/1118-2027
jaylouisw:docs/1118-1416
jaylouisw:fix/1118-1006
jaylouisw:catalogue/1118-0326
jaylouisw:catalogue/1117-2326
jaylouisw:catalogue/1117-0025
jaylouisw:catalogue/1116-1730
jaylouisw:fix/1523-speed-downgrade-one-end
jaylouisw:fix/enable-required-and-empty-pipe-help
jaylouisw:land-all-v5
jaylouisw:land-all-v4
jaylouisw:land-all-v3
jaylouisw:land-all-v2
jaylouisw:land-all
jaylouisw:fix/board-id
jaylouisw:fix/stated-range
jaylouisw:fix/no-form-names-v2
jaylouisw:fix/voice-vlan
jaylouisw:devices/catalogue-batch
jaylouisw:devices/powerline-moca
jaylouisw:devices/firewalls-enterprise
jaylouisw:devices/pon-splitters
jaylouisw:devices/nvr-and-taps
jaylouisw:devices/four-nvr-models
jaylouisw:fix/contributing-exemption
jaylouisw:fix/stale-github-urls
jaylouisw:ci/cancel-superseded-runs
jaylouisw:gh/1438
jaylouisw:device/uisp-console-lbe-xr
jaylouisw:gh/1442
jaylouisw:docs/readme-current-counts
jaylouisw:feat/device-ubiquiti-wave-fiber-onu
jaylouisw:fix/address-ownership
jaylouisw:feat/vrrp-in-path
jaylouisw:fix/merge-research-duplicate
jaylouisw:docs/hybrid-patch-current
jaylouisw:fix/audit-port-template
jaylouisw:fix/2930f-jl256a-uplinks
jaylouisw:feat/dhcp-in-path
jaylouisw:feat/hackgpon-ubiquiti-uisp-fiber-xgs
jaylouisw:feat/hackgpon-adtran-sdx-621
jaylouisw:tool/issue-duplicate-sweep
jaylouisw:feat/device-mikrotik-rb433ah
jaylouisw:feat/hackgpon-ma5671a
jaylouisw:issues/categories-and-labels
jaylouisw:ci/run-every-suite-locally
jaylouisw:chore/http-smoke
No reviewers
Labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!2032
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1118-2037"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #2030
Measured on main (
05ed9322), one stale URL planted in a file no probe touches:The last three all ended with
ok(check().ok, ...), i.e. "the whole tree is clean", not "my probe was cleaned up".and the README is restoredfailed whileand the README is restored byte for byte- the assertion two lines further down - passed on the same run. The suite contradicted itself, and the three extra failures sent a reader looking at probe cleanup instead of at the stale URL the first line had already named, with its file and line printed underneath.PR #1980 is that scenario today:
docs/plans/changelog-discipline.md:36quotesgithub.com/Jaylouisw/packetforgeas the changelog footer's evidence, and all three Node legs read48 passed, 4 failed.Change,
test/canonical-urls.test.jsonly:docs/__drift_probe.md, noE_NO_CANONICAL_CLONEleft, noE_BADGE_NO_WORKFLOWleft;Guard strength unchanged:
check()still fails the tree on a planted URL, and the suite still proves every probe can fail.Gates
node scripts/syntax-check.js- 422 files, all OKnode test/canonical-urls.test.js- 61 passed, 0 failed (was 52); with one stale URL planted elsewhere:60 passed, 1 failed, the one failure being the true one, and the same for the #1980 file verbatimnpm test- 348 suites, 12074 assertions, 0 failedNo engine, server or catalogue code touched. Nothing else changed.
6bf637da95b43338d2d0b43338d2d0to46eec941f1Superseded — closing, not merging.
Main already carries this change. PR #2036 (squashed to
80bb55fe, merged 21:11:58Z) landed the same fix intest/canonical-urls.test.jsand closed #2030 at 21:12:03Z:problemsFor(rel)/problemsWithCode(code)on main (line 34), the same idea as this PR'sreportedFor/reportedCodes— just named differently;problemsFor('docs/__drift_probe.md'), lines 90/109/145/228);docs/__elsewhere_stale.mdalready exists on main as thedocs/__stray_stale.mdblock ("A stale URL outside the probe paths is reported once, and blames only itself", lines 65–92) — it asserts the same three properties: exactly one problem, reported against the file and line that holds it, and no report filed against a probe that is not on disk.Verified by rebasing locally onto
a603c7f7: the only conflict is this overlap (problemsForvsreportedFor, two versions of the same test block), and the branch's delta against main after resolution is zero — 50ok()on main, 52 here, with the two extra being the duplicate stray-URL block.No content is lost by closing. If you want #2032's exact wording of that test kept instead of #2036's, say so and I will reopen and rebase it on top of the #2036 text rather than choose for you.
Pull request closed