test/canonical-urls.test.js: one stale URL anywhere reports three more failures that name the wrong cause #2030
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#2030
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Measured on
origin/main(05ed9322), Node 26, with one stale URL planted in a file the probes never touch:One stale URL is one problem, and it is the first line: correct, with its file and line printed under it. The other three are collateral. Three assertions end with
ok(check().ok, ...):test/canonical-urls.test.js:69and:184- "and the tree is clean again once the probe is removed"test/canonical-urls.test.js:103- "and the README is restored"check().okis the whole tree, not the probe. So a pre-existing stale URL makes the suite claim the probe cleanup left residue, and claim the README was not restored - while the assertion two lines below,and the README is restored byte for byte, passes on the same run. The label contradicts the test next to it.This is not hypothetical: PR #1980 (
docs/plans/changelog-discipline.md:36quotesgithub.com/Jaylouisw/packetforgeas the changelog footer's evidence) is red on all three Node legs at48 passed, 4 failed, which reads as a broken cleanup rather than as one line of prose the checker refuses. Triage cost, not a guard.Wanted: the post-probe assertions assert what their names say - nothing is reported for the probe path, and no
E_NO_CANONICAL_CLONE/E_BADGE_NO_WORKFLOWproblem remains - while the suite keeps its whole-tree guard at:47, which is where a stale URL should be reported once, with its file and line. A regression case should plant a stale URL outside the probe paths and pin that it is reported once and does not accuse the probes.