Stop devices claiming power they do not have, and 10G ports in 1G cages #954
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!954
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/spec-contradictions"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes the issue for
mainbeing red since the sync commit.Devices that accept power declared as power sources
EP-R6,ER-10X,ACB-ACeach say "PoE-in" in their own description and declared every port aPSE. They now keep the input and source nothing. The same sweep checked
EP-R8(passes powerthrough),
EP-S16(4 PoE / 12 PoE+) andN-SW(3 PoE out) and left them alone, because theirdescriptions say what they do.
The invariant could not tell a declaration from a guess
"off a switch, only ports that name themselves PoE source power" tested the port name, which is a
proxy for intent, not the thing itself: it fired on an NVR whose datasheet names its ports
"PoE 1..16".
derivePortHardware()now recordspoeOutDeclared, and the rule asks the questionthat matters - on a non-switch, power is only sourced where the datasheet says so. A wrongly
declared port stays a data bug, fixed in the spec file rather than excused by the test, which is what
the first section of this PR is.
poe_inis not a power sourceisPoePse()returned true for any name containing "poe", soplanet/POE-E201andpoe-texas/GAF-12V12Wbecame PSEs on the strength of their own input jack's name. Input markers areexcluded first now.
10G in a 1G cage
ER-8-XG(8 ports) andENVR(2) declaredsfpat 10G. Ubiquiti's pages for both say SFP+:EdgeRouter Infinity is 8x 10G SFP+, Enterprise NVR is 2x 10G SFP+. Same defect as #1069, on
hardware that arrived in the sync.
83 suites, 4182 assertions, all passing.
Closes #953.