main is red: synced specs contradict their own datasheets (PoE-in declared as PSE, 10G in 1G cages) #953
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#953
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
mainis red, and has been since the sync commit9e1bf8abrought the GitHub history in.Two suites fail, for two unrelated reasons, both of them specs contradicting their own text.
1. Devices that accept power, declared as power sources.
EP-R6,ER-10XandACB-ACsay"PoE-in" in their own descriptions and declare every port a PSE. A sweep of the catalogue for the
same contradiction found three more that were fine -
EP-R8passes power through,EP-S16has4 PoE + 12 PoE+,
N-SWhas 3 PoE out - so this is not a category error, it is three bad files.2.
poe_intreated as a power source.isPoePse()returns true for any port whose namecontains "poe", so the inline splitters
planet/POE-E201andpoe-texas/GAF-12V12Wbecame PSEs onthe strength of their own input jack's name.
3. 10G ports in 1G cages.
ER-8-XG(8 ports) andENVR(2) declare connectorsfpat 10G.Ubiquiti documents both as SFP+.
The invariant itself is also part of the problem: it tests the port name, which is a proxy for
intent, and so fires on legitimate PoE outputs whose datasheet names them "PoE 1..16" while never
asking whether the engine invented the watts. That is the same class as #1069.
Worth noting for whoever owns the sync: this landed on
mainwithout a CI run, becausepull_requestevents are not creating tasks (#930). Two red suites sat there until someone ran thesuite by hand.