Let CONTRIBUTING name the mirror, and keep the guard able to fail #1081
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1081
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/canonical-contributing-exemption"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
#1074moved contributions to GitHub — accounts here are closed, so that is the only door astranger has — and in doing so tripped the guard that says CONTRIBUTING may not mention GitHub.
That assertion was right when the forge was the only door and is wrong now, but the fix is not to
delete it.
README.mdstays forbidden, and CONTRIBUTING is allowed only on conditions that arethemselves asserted:
So the pair of checks survives in a stronger form: the failure that would actually hurt — a
contributor following a stale instruction to clone from the wrong place — still goes red.
test/canonical-urls.test.js: 43 passed, 0 failed.Closes #1080.