The canonical-URL guard forbids the one file that must now name GitHub #1080
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1080
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
test/canonical-urls.test.jsasserts:That was correct while the forge was the only door. It no longer is: accounts here are closed by
design, so CONTRIBUTING.md must send contributors to the GitHub mirror, and the guard refuses any
file that contains
github.com/Jaylouisw/packetforge.Suppressing the failure would be the wrong fix, and so would deleting the assertion. The invariant
that actually matters is narrower: CONTRIBUTING may name the mirror, but it must still present the
forge as the canonical home, must call GitHub what it is, and must carry a reasoned exemption.
Acceptance:
mirror, or the exemption lost its reason, the suite goes red.