Let CONTRIBUTING name the mirror, and keep the check that matters #1079

Closed
jaylouisw wants to merge 1 commit from fix/contributing-exemption into main
Owner

Superseded by #1081, which fixed the same contradiction while this was open — and did it better.

#1081 asserts that CONTRIBUTING.md is exempt and that the exemption is reasoned, that the reason names GitHub as the shopfront, that the file still points at the forge as the canonical home, and that it calls GitHub the mirror. That is the same invariant I was reaching for, stated more directly, and it fails for the right reasons.

Keeping mine would leave two competing guards for one rule. Closing.

(Found the same way, for the record: main was at 39 passed, 1 failed because #1074 added the exemption and this test still forbade it. Two PRs, each green on its own base.)

Superseded by #1081, which fixed the same contradiction while this was open — and did it better. #1081 asserts that `CONTRIBUTING.md` **is** exempt and that the exemption is reasoned, that the reason names GitHub as the shopfront, that the file still points at the forge as the canonical home, and that it calls GitHub the mirror. That is the same invariant I was reaching for, stated more directly, and it fails for the right reasons. Keeping mine would leave two competing guards for one rule. Closing. (Found the same way, for the record: `main` was at `39 passed, 1 failed` because #1074 added the exemption and this test still forbade it. Two PRs, each green on its own base.)
Let CONTRIBUTING name the mirror, and keep the check that matters
Some checks failed
CI / Test (Node 18) (pull_request) Failing after 1m37s
CI / Test (Node 20) (pull_request) Failing after 1m27s
CI / Server smoke test (pull_request) Successful in 30s
CI / Docker build (pull_request) Successful in 11s
CI / Test (Node 22) (pull_request) Failing after 1m24s
4ca8f7dd1b
Two pull requests landed that could not both be right. #1074 inverted the
contribution model - contributors now arrive through the GitHub mirror and
scripts/gh-bridge.js carries their work onto the forge - and added CONTRIBUTING.md
to the exemption list so the file could name the mirror. test/canonical-urls.test.js
still asserted the opposite, in a comment that called it one of 'the two files that
must never be allowed to advertise GitHub as the place to work'.

main went red. Nobody noticed, because nobody has run that suite against main since
the two merges.

The rule, not the file, was stale. CONTRIBUTING.md cannot both tell contributors to
open issues on GitHub and avoid mentioning GitHub. So the assertion becomes
conditional instead of being deleted:

- if CONTRIBUTING is exempt, it must still name git.jayw.uk - naming the mirror is
  allowed, replacing the forge with it is not
- and the mirror it names must be the real repository, not a placeholder

README keeps the absolute rule: it is the file everyone follows, and there is no
version of it that needs to send them to the mirror first.

41 checks pass, where main was at 40 passed and 1 failed.
jaylouisw scheduled this pull request to auto merge when all checks succeed 2026-11-08 15:23:42 +00:00
jaylouisw force-pushed fix/contributing-exemption from 4ca8f7dd1b
Some checks failed
CI / Test (Node 18) (pull_request) Failing after 1m37s
CI / Test (Node 20) (pull_request) Failing after 1m27s
CI / Server smoke test (pull_request) Successful in 30s
CI / Docker build (pull_request) Successful in 11s
CI / Test (Node 22) (pull_request) Failing after 1m24s
to 9288b2ebc2
All checks were successful
CI / Test (Node 18) (pull_request) Successful in 1m40s
CI / Test (Node 20) (pull_request) Successful in 1m33s
CI / Server smoke test (pull_request) Successful in 26s
CI / Docker build (pull_request) Successful in 10s
CI / Test (Node 22) (pull_request) Successful in 1m27s
2026-11-08 15:26:43 +00:00
Compare
jaylouisw closed this pull request 2026-11-08 15:32:02 +00:00
All checks were successful
CI / Test (Node 18) (pull_request) Successful in 1m40s
CI / Test (Node 20) (pull_request) Successful in 1m33s
CI / Server smoke test (pull_request) Successful in 26s
CI / Docker build (pull_request) Successful in 10s
CI / Test (Node 22) (pull_request) Successful in 1m27s

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1079
No description provided.