ci(docker): the smoke test runs beside the image build, in one job instead of two #2219
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!2219
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ci/1119-2229"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What was slow
Server smoke testandDocker buildwere two jobs that never overlapped. This runner gives a run four slots: the three test legs hold three of them for ~60 s, and the fourth carriesClassify the change(12-16 s) ->Server smoke test(10 s) ->Docker build(20 s) end to end. Each of the two also paid its own 5.3 s checkout of the same commit.Evidence,
/api/v1/repos/jaylouisw/packetforge/actions/tasksover the last 60 pull-request runs (7607-7974):Docker buildtask is created a median 2 s after theServer smoke testtask has finished (p10 -1 s, p90 +3 s), so the two never overlapped in a single one of those runs;The change
One job (key
docker, display nameServer smoke and Docker build) that runs both checks: one checkout, one container, andscripts/smoke-http.jsdetached beside the image build instead of in front of it.smoke-http.jslistens on127.0.0.1:0and keeps its state underos.tmpdir(), so it shares the tree with the build without touching it.Coverage unchanged
Same
scripts/smoke-http.jsand the same 180 s bound (status recorded to a file and reported by anif: always()step, 200 s bound on the wait, 124/137 still named as a stop); same eight Dockerfile static checks; samedocker build -t packetforge:ci-run-<run>with its 180 s bound; same prune underif: always(); same::error title=Server smoke test/Docker buildtitles; either red still reddens the job.node scripts/run-tests.jslocally: 390 suites, 13082 assertions, 0 failed, the same counts as the last green CI legs (run 7974).check-ci-disk-hygiene.js,check-canonical-urls.js,check-node-surface.jsandtest/ci-disk-hygiene.test.jspass.After
Job count per run 7 -> 6, one 5.3 s checkout gone, and the smoke verdict now arrives with the build instead of 11 s before it. This PR's own run id is in the comments once it finishes.
After: run 7989 (this PR), one job instead of two.
Pushed as
49e69920. The workflow parsed and ran; the merged job isServer smoke and Docker build(task 21129), and every check it carried ran:Run total 72 s in 7989 against 68 s in 7974: the test legs are the wall clock in both (legs 54-56 s in 7989, 57-61 s in 7974, and they started staggered at +4/+8/+10 this time against +0/+1/+2), so this change pays out in slot time and in the tail, not in the median. On the 24 of the last 60 runs where the second job outlived every leg (median 11 s, 97 s at worst) that tail is now ~10 s shorter, and it can no longer be two dispatches deep.
Coverage identical: 390 suites / 13082 assertions in each leg (same as 7974), the same 18 smoke assertions, the same 8 Dockerfile checks, the same real
docker buildand the same prune. Nothing skipped, nothing retried.