docs(ci): the smoke test and Docker build are one job, not two (#2219) #2223

Merged
jaylouisw merged 1 commit from docs/1119-2317 into main 2026-11-19 23:37:42 +00:00
Owner

docs/CI.md still described five verification checks and gave Server smoke test and Docker build a row each. Since a56b9a72 (#2219) .forgejo/workflows/ci.yml has four jobs, and the fourth is docker: / name: Server smoke and Docker build: the step Drive the API end to end, beside the image build launches scripts/smoke-http.js under nohup, the image build runs over it, and Report the server smoke test prints the verdict at the end of the same job.

Evidence from the workflow:

  • the jobs are changes, test, docker, arm - there is no smoke: job;
  • arm takes needs: [changes, test, docker], not [changes, test, smoke, docker];
  • the merged job keeps both ::error title=Server smoke test and ::error title=Docker build, so a red still names which of the two checks failed.

Fixed: the check count (four), the check table, the timeout-minutes enumeration, Arm auto-merge's needs list, the classifier tables ("skipped | skipped" -> one skipped column, "the pair of jobs" -> one job), and the timeout 180 sentence that called the whole job 11 s median (that figure is the smoke client's, and it now shares the slot with the build). CONTRIBUTING.md's "lists the five checks" pointer follows. The 2026-11-16/17 measurements that cite seven checks and five blocked jobs are history and are left alone.

Guards: scripts/syntax-check.js 471 files OK; docs-cli-transcript 9 passed, docs-show-commands 7, help-completeness 8, doc-catalog-counts 43, doc-citations 11, check-control-bytes clean - identical before and after the edit.

`docs/CI.md` still described five verification checks and gave `Server smoke test` and `Docker build` a row each. Since a56b9a72 (#2219) `.forgejo/workflows/ci.yml` has four jobs, and the fourth is `docker:` / `name: Server smoke and Docker build`: the step `Drive the API end to end, beside the image build` launches `scripts/smoke-http.js` under `nohup`, the image build runs over it, and `Report the server smoke test` prints the verdict at the end of the same job. Evidence from the workflow: * the jobs are `changes`, `test`, `docker`, `arm` - there is no `smoke:` job; * `arm` takes `needs: [changes, test, docker]`, not `[changes, test, smoke, docker]`; * the merged job keeps both `::error title=Server smoke test` and `::error title=Docker build`, so a red still names which of the two checks failed. Fixed: the check count (four), the check table, the `timeout-minutes` enumeration, `Arm auto-merge`'s `needs` list, the classifier tables ("skipped | skipped" -> one skipped column, "the pair of jobs" -> one job), and the `timeout 180` sentence that called the whole job 11 s median (that figure is the smoke client's, and it now shares the slot with the build). `CONTRIBUTING.md`'s "lists the five checks" pointer follows. The 2026-11-16/17 measurements that cite seven checks and five blocked jobs are history and are left alone. Guards: `scripts/syntax-check.js` 471 files OK; docs-cli-transcript 9 passed, docs-show-commands 7, help-completeness 8, doc-catalog-counts 43, doc-citations 11, check-control-bytes clean - identical before and after the edit.
docs(ci): the smoke test and Docker build are one job, not two (#2219)
All checks were successful
CI / Classify the change (pull_request) Successful in 15s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 12s
CI / Server smoke and Docker build (pull_request) Has been skipped
CI / Test (Node 22) (pull_request) Successful in 58s
CI / Test (Node 20) (pull_request) Successful in 1m0s
CI / Test (Node 18) (pull_request) Successful in 1m2s
CI / Arm auto-merge (pull_request) Successful in 4s
48e3584a16
docs/CI.md still counted five verification checks and named `Server smoke
test` and `Docker build` as separate job statuses. Since a56b9a72 (#2219)
ci.yml posts one `Server smoke and Docker build` job: the smoke client is
launched before the image build and reported at the end of the same slot.
Correct the check count (four), the check table, the timeout-minutes
enumeration, `Arm auto-merge`'s `needs` list, and both classifier tables
that predicted two skipped jobs. CONTRIBUTING.md's 'five checks' pointer
follows.
forgejo-actions scheduled this pull request to auto merge when all checks succeed 2026-11-19 23:20:29 +00:00
jaylouisw deleted branch docs/1119-2317 2026-11-19 23:37:43 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2223
No description provided.