docs(BGP-POLICY): the anchor table points at the code that holds the symbols again #2050
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!2050
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "docs/1118-2317"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What was untrue
The anchor table in
docs/BGP-POLICY.md§1 citesengine/cli.jsandengine/simulator.jsby line. Five of those anchors no longer hold the code the row names, and the same stale numbers are repeated in §4.4, §6.3, §7.4, §9.1, §9.2, §9.4, §9.6 and §11.cli.js:6767_help()cli.js:6859_showIpv6Nd()(92 lines away)cli.js:2610_bgp(tokens)cli.js:2633cli.js:2679this._dnsZonecli.js:2702this._dnsZone = z.name;cli.js:1564-1582config-mode BGP dispatchcli.js:1581-1599no ipv6/ipv6 ndbranchessimulator.js:1907-1957+ lines 1913/1918/1919/19241905-1958+ 1914/1919/1920/1925simulator.js:1871-1874{type:"bgp"}emit1872-1875this._emit({ … })cli.js:981,:1181for the% Incomplete commandstylecli.js:998,:1198iface.natRole = null;, 1181 is a ternary tailcli.js:1580for_bgp(tokens.slice(1))onneighborcli.js:1597Citations verified by reading the cited lines in this tree;
node scripts/check-doc-citations.js --strictnow reports "No judged citation is more than 40 lines from the code it names" (before: 2 suspects,docs/BGP-POLICY.md:76and:824at 92 lines).What changed
Numbers only — no prose, no behaviour, no code.
Gates
node scripts/syntax-check.js— 429 files, all OKnode scripts/check-control-bytes.js— cleannode test/docs-show-commands.test.js— 7 passed / 0 (59 forms, 118 commands)node test/docs-cli-transcript.test.js— 4 passed / 0node test/help-completeness.test.js— 8 passed / 0node test/no-form-help-key.test.js— 81 passed / 0;help-key-is-not-a-value40 / 0;help-key-works-in-every-prompt10 / 0node scripts/check-doc-citations.js --strict— 0 suspects (was 2)The table's five cli.js/simulator.js anchors had drifted: `_help()` is 92 lines further down than the page said (cli.js:6859, cited 6767, which now falls inside `_showIpv6Nd()`), `_bgp(tokens)` is 2633 (cited 2610), the sticky `this._dnsZone` assignment is 2702 (cited 2679), and the config-mode BGP dispatch is cli.js:1581-1599 (cited 1564-1582, which is now the IPv6 gateway/ND branches). The simulator advertisement loop is 1905-1958, not 1907-1957, so every line quoted inside it moved by one: the `from` guard is 1914, the iBGP->iBGP suppression 1919, the AS-path prepend 1920 and the next hop 1925; the `{type:'bgp'}` emit is 1872-1875. The `% Incomplete command` style reference cited cli.js:981 and :1181, which hold a NAT role assignment and a ternary tail; 998 and 1198 are the two handlers. No prose, no behaviour: numbers only, each checked against engine/cli.js and engine/simulator.js in this tree. `node scripts/check-doc-citations.js --strict` went from 2 suspects to none._help()anchors point at_help(), not 42 lines above it #2106