docs(BGP-POLICY): the cli.js anchors point at the code that holds them again #2047

Closed
jaylouisw wants to merge 1 commit from docs/1118-2247 into main
Owner

Seven cli.js line citations in docs/BGP-POLICY.md had drifted 17-55 lines above the code they name, because rows landed above _configMode()/_bgp()/_help().

says was is
config-mode BGP dispatch 1564-1582 1581-1599
neighbor -> _bgp(tokens.slice(1)) 1580 1597
_bgp(tokens) 2610 2633
this._dnsZone sticky context 2679 2702
_help() 6767 6822
% Incomplete command style 981 / 1181 998 / 1198

Verified by reading each target line in engine/cli.js: 6822 is _help() {, 2633 is _bgp(tokens) {, 2702 is this._dnsZone = z.name;, 1597 is the neighbor branchs _bgp(tokens.slice(1)) call, 998/1198 are the VLAN-id and hostname % Incomplete command returns.

node scripts/check-doc-citations.js before: 2 suspects (cli.js:6767 is 55 lines from _help() at line 6822). After: no judged citation more than 40 lines from its symbol. Guards unchanged: syntax-check 428 files OK, docs-show-commands 7, docs-cli-transcript 4, help-forms 81, help-coverage 8. Docs-only.

Seven `cli.js` line citations in docs/BGP-POLICY.md had drifted 17-55 lines above the code they name, because rows landed above `_configMode()`/`_bgp()`/`_help()`. | says | was | is | |---|---|---| | config-mode BGP dispatch | 1564-1582 | 1581-1599 | | `neighbor` -> `_bgp(tokens.slice(1))` | 1580 | 1597 | | `_bgp(tokens)` | 2610 | 2633 | | `this._dnsZone` sticky context | 2679 | 2702 | | `_help()` | 6767 | 6822 | | `% Incomplete command` style | 981 / 1181 | 998 / 1198 | Verified by reading each target line in engine/cli.js: 6822 is `_help() {`, 2633 is `_bgp(tokens) {`, 2702 is `this._dnsZone = z.name;`, 1597 is the `neighbor` branchs `_bgp(tokens.slice(1))` call, 998/1198 are the VLAN-id and hostname `% Incomplete command` returns. `node scripts/check-doc-citations.js` before: 2 suspects (`cli.js:6767 is 55 lines from _help() at line 6822`). After: no judged citation more than 40 lines from its symbol. Guards unchanged: syntax-check 428 files OK, docs-show-commands 7, docs-cli-transcript 4, help-forms 81, help-coverage 8. Docs-only.
docs(BGP-POLICY): the cli.js anchors point at the code that holds them again (#2050)
All checks were successful
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 9s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 18) (pull_request) Successful in 1m19s
CI / Test (Node 20) (pull_request) Successful in 1m17s
CI / Test (Node 22) (pull_request) Successful in 1m18s
CI / Arm auto-merge (pull_request) Successful in 3s
96785f9c6d
forgejo-actions force-pushed docs/1118-2247 from 96785f9c6d
All checks were successful
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 9s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 18) (pull_request) Successful in 1m19s
CI / Test (Node 20) (pull_request) Successful in 1m17s
CI / Test (Node 22) (pull_request) Successful in 1m18s
CI / Arm auto-merge (pull_request) Successful in 3s
to b0a81cfc6e 2026-11-18 22:52:44 +00:00
Compare
Author
Owner

Superseded: main already carries this anchor refresh. #2050 landed the same docs/BGP-POLICY.md anchor pass as 215049d1, and a rebase of this branch onto current main is content-empty (git diff origin/main origin/docs/1118-2247 = 0 files), so there is nothing left to merge.

Verified against the tree rather than taken on trust — the two anchors where this branch differs from main are the stale ones:

  • _help(): branch says cli.js:6822; the definition is at engine/cli.js:6859 (main is right).
  • advertisement loop: branch says simulator.js:1907-1957 / line 1913; if (e.from === adj.peer.dev.id) continue; is at engine/simulator.js:1914 inside 1905-1958 (main is right).

The % Incomplete command anchors this branch also fixed (cli.js:998, :1198) are already on main. Closing as superseded, not merging.

Superseded: main already carries this anchor refresh. #2050 landed the same `docs/BGP-POLICY.md` anchor pass as `215049d1`, and a rebase of this branch onto current main is content-empty (`git diff origin/main origin/docs/1118-2247` = 0 files), so there is nothing left to merge. Verified against the tree rather than taken on trust — the two anchors where this branch differs from main are the stale ones: - `_help()`: branch says `cli.js:6822`; the definition is at `engine/cli.js:6859` (main is right). - advertisement loop: branch says `simulator.js:1907-1957` / line `1913`; `if (e.from === adj.peer.dev.id) continue;` is at `engine/simulator.js:1914` inside `1905-1958` (main is right). The `% Incomplete command` anchors this branch also fixed (`cli.js:998`, `:1198`) are already on main. Closing as superseded, not merging.
jaylouisw closed this pull request 2026-11-18 23:40:26 +00:00

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2047
No description provided.