ci(arm): ask the server to merge, instead of polling a cached mergeable field #1939
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1939
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ci/1118-0421"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Baseline: the arm job polls
GET /pulls/:nfor a cachedmergeablefor up to 90 s and then reports it as "still not computed". Two of the last 40 green arm runs paid the full 90 s and still did not merge: #1917 (run 5735, task 14603) and #1923 (run 5788, task 14759) - the latter merged six minutes later (02:11:47) via the next rebase pass, which re-ran the whole matrix on a fresh head.Change: request the merge directly (
POST /pulls/:n/merge), which recomputes mergeability inside the request that merges; bounded to 3 attempts, printing the server's reason on refusal. The status-set read, the three-test-leg floor andhead_commit_idare unchanged, so a red or unmergeable pull request is still never merged.Coverage unchanged: no job, step, suite or check is added, removed, skipped or softened - only the arm job's merge call path changed.
After: this pull request's own arm job runs the new code, on this head.
mergeablec928d2f8c588f077ce97