ci(arm): ask the server to merge, instead of polling a cached mergeable field #1939

Merged
jaylouisw merged 1 commit from ci/1118-0421 into main 2026-11-18 04:39:03 +00:00
Owner

Baseline: the arm job polls GET /pulls/:n for a cached mergeable for up to 90 s and then reports it as "still not computed". Two of the last 40 green arm runs paid the full 90 s and still did not merge: #1917 (run 5735, task 14603) and #1923 (run 5788, task 14759) - the latter merged six minutes later (02:11:47) via the next rebase pass, which re-ran the whole matrix on a fresh head.

Change: request the merge directly (POST /pulls/:n/merge), which recomputes mergeability inside the request that merges; bounded to 3 attempts, printing the server's reason on refusal. The status-set read, the three-test-leg floor and head_commit_id are unchanged, so a red or unmergeable pull request is still never merged.

Coverage unchanged: no job, step, suite or check is added, removed, skipped or softened - only the arm job's merge call path changed.

After: this pull request's own arm job runs the new code, on this head.

Baseline: the arm job polls `GET /pulls/:n` for a cached `mergeable` for up to 90 s and then reports it as "still not computed". Two of the last 40 green arm runs paid the full 90 s and still did not merge: #1917 (run 5735, task 14603) and #1923 (run 5788, task 14759) - the latter merged six minutes later (02:11:47) via the next rebase pass, which re-ran the whole matrix on a fresh head. Change: request the merge directly (`POST /pulls/:n/merge`), which recomputes mergeability inside the request that merges; bounded to 3 attempts, printing the server's reason on refusal. The status-set read, the three-test-leg floor and `head_commit_id` are unchanged, so a red or unmergeable pull request is still never merged. Coverage unchanged: no job, step, suite or check is added, removed, skipped or softened - only the arm job's merge call path changed. After: this pull request's own arm job runs the new code, on this head.
ci(arm): ask the server to merge, instead of polling a cached mergeable
All checks were successful
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 6s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 23s
CI / Test (Node 20) (pull_request) Successful in 50s
CI / Test (Node 18) (pull_request) Successful in 1m0s
CI / Test (Node 22) (pull_request) Successful in 1m0s
CI / Arm auto-merge (pull_request) Successful in 18s
c928d2f8c5
The arm job read GET /pulls/:n until `mergeable` was `true`, up to 90 s, then gave up
with "mergeable was still not computed". The field is filled by a background task, so
the poll was waiting on a cache; POST /pulls/:n/merge recomputes mergeability inside
the request that merges.

Two of the last 40 green arm runs paid the full 90 s and still did not merge: #1917
(run 5735, task 14603) and #1923 (run 5788, task 14759). #1923 was merged at 02:11:47
by the next rebase pass, six minutes later, after that pass re-ran the whole matrix on
a fresh head.

The green-status read, the three-leg floor and `head_commit_id` are unchanged; a
refusal now costs 3 bounded attempts and prints the server's own reason.
jaylouisw force-pushed ci/1118-0421 from c928d2f8c5
All checks were successful
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 6s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 23s
CI / Test (Node 20) (pull_request) Successful in 50s
CI / Test (Node 18) (pull_request) Successful in 1m0s
CI / Test (Node 22) (pull_request) Successful in 1m0s
CI / Arm auto-merge (pull_request) Successful in 18s
to 88f077ce97
All checks were successful
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 6s
CI / Server smoke test (pull_request) Successful in 9s
CI / Docker build (pull_request) Successful in 23s
CI / Test (Node 20) (pull_request) Successful in 50s
CI / Test (Node 18) (pull_request) Successful in 1m0s
CI / Test (Node 22) (pull_request) Successful in 55s
CI / Arm auto-merge (pull_request) Successful in 9s
2026-11-18 04:36:56 +00:00
Compare
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1939
No description provided.