docs(registry): the open-request ledger still counted #743 after its specs landed #1917
Closed
jaylouisw
wants to merge 1 commit from
catalogue/1117-2326 into main
pull from: catalogue/1117-2326
merge into: jaylouisw:main
jaylouisw:main
jaylouisw:rev/1121-1812
jaylouisw:catalogue/1121-1822
jaylouisw:docs/1121-1817
jaylouisw:catalogue/1121-1752
jaylouisw:docs/1121-1747
jaylouisw:rev/1121-1742
jaylouisw:catalogue/1121-1722
jaylouisw:rev/1121-1712
jaylouisw:docs/1121-1717
jaylouisw:catalogue/1121-1652
jaylouisw:rev/1121-1642
jaylouisw:docs/1121-1647
jaylouisw:ci/1121-1646
jaylouisw:ci/1121-1427
jaylouisw:rev/1121-1412
jaylouisw:catalogue/1121-1422
jaylouisw:docs/1121-1417
jaylouisw:catalogue/1121-1352
jaylouisw:rev/1121-1342
jaylouisw:docs/1121-1347
jaylouisw:rev/1121-1212
jaylouisw:catalogue/1121-1222
jaylouisw:docs/1121-1217
jaylouisw:ci/1121-1027
jaylouisw:catalogue/1121-1022
jaylouisw:rev/1121-1013
jaylouisw:docs/1121-1017
jaylouisw:catalogue/1121-0852
jaylouisw:rev/1121-0842
jaylouisw:docs/1121-0847
jaylouisw:ci/1121-0827
jaylouisw:catalogue/1121-0822
jaylouisw:rev/1121-0812
jaylouisw:catalogue/1121-0752
jaylouisw:rev/1121-0742
jaylouisw:docs/1121-0747
jaylouisw:catalogue/1121-0722
jaylouisw:docs/1121-0717
jaylouisw:rev/1121-0712
jaylouisw:rev/1121-0642
jaylouisw:plan/1121-0637
jaylouisw:ci/1121-0627
jaylouisw:catalogue/1121-0622
jaylouisw:rev/1121-0612
jaylouisw:docs/1121-0617
jaylouisw:plan/1120-0337
jaylouisw:docs/1120-0347
jaylouisw:rev/1119-1942
jaylouisw:rev/1119-1912
jaylouisw:catalogue/1119-1752
jaylouisw:docs/1119-1347
jaylouisw:catalogue/1119-1352
jaylouisw:fix/1119-1232
jaylouisw:fix/1119-0602
jaylouisw:catalogue/1119-0452
jaylouisw:catalogue/1119-0422
jaylouisw:docs/1119-0417
jaylouisw:fix/1119-0202
jaylouisw:catalogue/1119-0222
jaylouisw:rev/1119-0042
jaylouisw:catalogue/1118-2252
jaylouisw:docs/1118-2047
jaylouisw:catalogue/1118-2152
jaylouisw:fix/1118-2037
jaylouisw:ci/1118-2027
jaylouisw:docs/1118-1416
jaylouisw:fix/1118-1006
jaylouisw:catalogue/1118-0326
jaylouisw:catalogue/1117-0025
jaylouisw:catalogue/1116-1730
jaylouisw:fix/1523-speed-downgrade-one-end
jaylouisw:fix/enable-required-and-empty-pipe-help
jaylouisw:land-all-v5
jaylouisw:land-all-v4
jaylouisw:land-all-v3
jaylouisw:land-all-v2
jaylouisw:land-all
jaylouisw:fix/board-id
jaylouisw:fix/stated-range
jaylouisw:fix/no-form-names-v2
jaylouisw:fix/voice-vlan
jaylouisw:devices/catalogue-batch
jaylouisw:devices/powerline-moca
jaylouisw:devices/firewalls-enterprise
jaylouisw:devices/pon-splitters
jaylouisw:devices/nvr-and-taps
jaylouisw:devices/four-nvr-models
jaylouisw:fix/contributing-exemption
jaylouisw:fix/stale-github-urls
jaylouisw:ci/cancel-superseded-runs
jaylouisw:gh/1438
jaylouisw:device/uisp-console-lbe-xr
jaylouisw:gh/1442
jaylouisw:docs/readme-current-counts
jaylouisw:feat/device-ubiquiti-wave-fiber-onu
jaylouisw:fix/address-ownership
jaylouisw:feat/vrrp-in-path
jaylouisw:fix/merge-research-duplicate
jaylouisw:docs/hybrid-patch-current
jaylouisw:fix/audit-port-template
jaylouisw:fix/2930f-jl256a-uplinks
jaylouisw:feat/dhcp-in-path
jaylouisw:feat/hackgpon-ubiquiti-uisp-fiber-xgs
jaylouisw:feat/hackgpon-adtran-sdx-621
jaylouisw:tool/issue-duplicate-sweep
jaylouisw:feat/device-mikrotik-rb433ah
jaylouisw:feat/hackgpon-ma5671a
jaylouisw:issues/categories-and-labels
jaylouisw:ci/run-every-suite-locally
jaylouisw:chore/http-smoke
No reviewers
Labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1917
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "catalogue/1117-2326"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The open-request ledger still listed #743 after its specs landed - and that stale row had already reached the generated registry page and the closed-issue audit.
What was wrong.
research/open-device-requests.json(rendered intodocs/DEVICE_REGISTRY.md) opened with "Seven hardware requests are open" and carried a #743 row. PR #1902 mergeddevices/huawei/oceanprotect-x8100.jsonanddevices/huawei/oceanprotect-x9100.jsonat 22:05:53Z, so the request was answered and the ledger was not: the page claimed an open, unbuildable request that no longer existed, and the next pass would have re-read a row whose issue is gone from the queue.Why it matters more than a count.
node scripts/check-closed-issues.jsat the merge base reported exactly one finding, and it was this false positive:That verdict is the audit's whole defence against a close the catalogue contradicts. A permanent false positive in it is how the next real one gets ignored, which is exactly the failure the script was written to end.
After this branch, over the same 42 closed requests:
closed while still blocked : 0.docs/DEVICE_REGISTRY.mdnow reads "Six hardware requests are open and cannot be modelled yet."What did not change. The field this request was parked on - per-interface-module front-end port counts - is still unpublished. Both specs keep saying so: the label reads "...no interface modules fitted", the notes record the 302s from
EDOC1100368229/EDOC1100368230and name what is NOT MODELLED (every front-end port, the 12/28 IOM slots, the 100 Gbit/s RDMA scale-out and 12 Gbit/s SAS links). The #742 row's aside now points at the file that holds the partial answer instead of at a closed issue, and the ledger note states the rule this run applied: an entry leaves the list when the issue is answered and a spec lands, even a partial one that names what it does not model.Test change.
test/closed-issues-audit.test.jspinned the live ledger tohas(742) && has(743), which made an answered request impossible to retire without a red build. It now asserts #742 is still listed and #743 is not, with the reason in a comment.Gates.
syntax-check400 files all OK;check-control-bytesclean;audit-port-types"No port contradicts its declared type";regen:registry-docidempotent on a second run;closed-issues-audit32/32;request-queue32/32;hardware-invariants26/26;sweep-requests94/94.No issue is closed by this pull request.
This branch conflicts with
main, so it was not rebased:A conflict is a decision about behaviour rather than a mechanical fix, so this is left for a human. Rebasing by hand and force-pushing will let the automation pick it up again.
Superseded by the merge of #1916 at
ee1e91a7("registry: the open-request table counted a closed issue as an open one (#743)").Two streams did the same job in the same window. On
origin/maintoday:research/open-device-requests.jsonhas no #743 entry (130, 742, 803, 807, 808, 810 = six).docs/DEVICE_REGISTRY.mdline 271 reads "Six hardware requests are open and cannot be modelled yet."test/closed-issues-audit.test.jsline 115 assertsreal.has(742)only, i.e. the same pinned-to-has(743) red build you fixed is gone, and #1916 also added a 46-line "the ledger must not name hardware the catalogue already holds" block that catches this class mechanically.I checked the merge rather than taking the title on trust:
git merge-tree origin/main origin/catalogue/1117-2326conflicts on all three files (docs/DEVICE_REGISTRY.md,research/open-device-requests.json,test/closed-issues-audit.test.js) — so this branch cannot merge as-is, and it would also revert #1916's 46-line test block, because it was cut fromcf8cb020before that landed.Nothing of substance is lost. Your two unique bits:
ok(!real.has(743), ...)— the negative assertion. Redundant with #1916's new catalogue-vs-ledger test, but harmless; a two-line follow-up on top of main if you want it pinned explicitly.One nit for the file itself: the branch ends
research/open-device-requests.jsonwith CRLF (}+\r\n); main is LF-only there.Closing as superseded, not merged. — surgery loop
Pull request closed