cli: a config file ends with end, so a paste closes itself #1768
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1768
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "rev/1117-0130"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
show running-confignow ends withend, the line a Cisco config file closes with, so a pastedbackup finishes at privileged EXEC instead of leaving the operator at
(config)#.endtyped at#(where a paste usually starts) is accepted and silent rather than answering% Unrecognized command: end.Evidence: two vendor samples (IOS 11.2 command reference, ISR 4400 configuration guide) both end
with
endand differ only in how many bare!lines sit above it, so onlyendwas adopted.research/running-config-end.mdrecords what is inferred (acceptingendat EXEC) and what staysunresolved (the
!count, and theCurrent configuration : N bytesbyte count).test/running-config-end.test.js- 14 assertions. Full suite: 299 suites, 10535 assertions, 0 failed.end, so a paste closes itself098dd60e1d25a5806189Red on one leg only — and the CI logs are readable now, so here are the two assertions by name.
Full log is at
/jaylouisw/packetforge/actions/runs/4505/jobs/2/logsfetched withAccept: text/plain(36564 bytes). The REST/actions/...API still 404s on this build, so logs are web-only.Head
25a58061,CI / Test (Node 20):Node 18 and Node 22 are green on the same commit.
Against main (
82e33b70, run 4498, 02:01:47 — same host, same 10-way concurrency):link-roundtrip 36 passed 1594 ms,state-payload-shape 21 passed 2636 ms, 298 suites, 0 failed. Main is green on both suites two minutes before this run, so this is not repo-wide breakage.Locally on this head (v24.11.0, three runs each):
state-payload-shape21/21 at 5.5 / 5.2 / 5.5 ms;link-roundtrip36/36 three times. A 60 ms budget that measures 5 ms unloaded and 66 ms inside a 10-way, three-container CI burst is load-shaped, not code-shaped — and neither suite touches anything this PR changes (docs/CLI.md,engine/cli.js,research/running-config-end.md,test/running-config-end.test.js).link-roundtrip's0 passed, 1 failed (no summary line)at 1910 ms means the suite process died before printing its summary; the runner's ceiling is 300 s, so it is not a timeout.Caveat: this is the second consecutive head failing only Node 20, so it may be reproducible rather than luck.
Why it is still open: Jay's standing rule is a PR never merges on a red leg, and
mergeableis true. The rerun endpoint is 404 on this Forgejo build and the auto-rebase workflow rebases without producing a new head, so only a push re-triggers CI. Owner's call: push an empty commit for a fresh run, or raise the two wall-clock budgets to CI-realistic values.Same three-PR shape, for the record: #1739 is deterministic (
device-aliases—B1LDCD finds both shelves [3]against a hardcoded 2, pluspalette-search-keyssame count), #1749 is its own new suite's 2,000-frame budget measured at 4051 ms in CI. — surgery watchdog25a580618934744fc906