vlan: switchport trunk allowed vlan remove on a default trunk subtracts, and a list prints as ranges #1749

Merged
jaylouisw merged 1 commit from rev/1116-2300 into main 2026-11-17 08:36:32 +00:00
Owner

Question. A trunk that has never had an allowed list typed on it carries the default all. What does switchport trunk allowed vlan remove <list> do there, and what does the box print?

Verdict. It is accepted: the box subtracts the named VLANs from the list it is already carrying and prints the remainder with runs folded into ranges. PacketForge refused it with % this trunk allows all VLANs: name the list it should allow instead.

Evidence:

  • Catalyst 2960-X 15.2(2)E config guide, Configuring VLAN Trunks - default is all VLANs 1-4094, and its Removing a VLAN from a Port example runs switchport trunk allowed vlan remove 2 on a default port.
  • Catalyst 9200 command reference, switchport trunk - remove "removes the defined list of VLANs from those currently set instead of replacing the list"; no switchport trunk allowed vlan restores all; removing VLAN 1 is the documented way to stop a trunk carrying VLAN 1 for data.
  • Cisco TAC KB, How to define the VLANs allowed on a trunk link - c3550 transcript: remove 5-10,12 then add 7, show interfaces fa0/2 trunk gives 1-4,7,11,13-4094.
  • Catalyst 3650 thread - a backup line in the same shape, switchport trunk allowed vlan 1-3,100.

Change.

  • remove on an all-allowed trunk stores allVlansExcept(removed); removing every assignable VLAN is still refused. remove 1-4094 no longer answers % Unrecognized "remove" - it is refused for the reserved VLANs the range spans.
  • formatVlanList() folds runs into ranges; the running-config line, the console replies and switchportSentence() all use it, and web/app.js mirrors it, so a port reads allowed 1,3-1001,1006-4094 in one line instead of 4,089 numbers.
  • The parser stays out of the data plane: a list already sorted/unique/assignable is copied rather than re-parsed, and membership is cached per array.

Unresolved (in research/trunk-allowed-remove-from-all.md): the exact running-config line after a removal is inferred, not captured; whether a two-id run prints 3-4; whether remove 1002 is refused or ignored; and the printed range across the reserved block (the c3550 prints one continuous 13-4094, this console splits at 1002-1005).

Tests. test/trunk-allowed-remove-from-all.test.js 45 checks (new); test/trunk-allowed-add-remove.test.js 45 -> 47. Full suite 296 suites / 10,515 assertions, 0 failed. node scripts/syntax-check.js 367 files OK.

**Question.** A trunk that has never had an allowed list typed on it carries the default `all`. What does `switchport trunk allowed vlan remove <list>` do there, and what does the box print? **Verdict.** It is accepted: the box subtracts the named VLANs from the list it is already carrying and prints the remainder with runs folded into ranges. PacketForge refused it with `% this trunk allows all VLANs: name the list it should allow instead`. Evidence: - Catalyst 2960-X 15.2(2)E config guide, *Configuring VLAN Trunks* - default is all VLANs 1-4094, and its *Removing a VLAN from a Port* example runs `switchport trunk allowed vlan remove 2` on a default port. - Catalyst 9200 command reference, `switchport trunk` - `remove` "removes the defined list of VLANs from those currently set instead of replacing the list"; `no switchport trunk allowed vlan` restores all; removing VLAN 1 is the documented way to stop a trunk carrying VLAN 1 for data. - Cisco TAC KB, *How to define the VLANs allowed on a trunk link* - c3550 transcript: `remove 5-10,12` then `add 7`, `show interfaces fa0/2 trunk` gives `1-4,7,11,13-4094`. - Catalyst 3650 thread - a backup line in the same shape, `switchport trunk allowed vlan 1-3,100`. **Change.** - `remove` on an all-allowed trunk stores `allVlansExcept(removed)`; removing every assignable VLAN is still refused. `remove 1-4094` no longer answers `% Unrecognized "remove"` - it is refused for the reserved VLANs the range spans. - `formatVlanList()` folds runs into ranges; the running-config line, the console replies and `switchportSentence()` all use it, and `web/app.js` mirrors it, so a port reads `allowed 1,3-1001,1006-4094` in one line instead of 4,089 numbers. - The parser stays out of the data plane: a list already sorted/unique/assignable is copied rather than re-parsed, and membership is cached per array. **Unresolved** (in `research/trunk-allowed-remove-from-all.md`): the exact running-config line after a removal is inferred, not captured; whether a two-id run prints `3-4`; whether `remove 1002` is refused or ignored; and the printed range across the reserved block (the c3550 prints one continuous `13-4094`, this console splits at 1002-1005). **Tests.** `test/trunk-allowed-remove-from-all.test.js` 45 checks (new); `test/trunk-allowed-add-remove.test.js` 45 -> 47. Full suite 296 suites / 10,515 assertions, 0 failed. `node scripts/syntax-check.js` 367 files OK.
vlan: switchport trunk allowed vlan remove on a default trunk subtracts, and a list prints as ranges
Some checks failed
CI / Classify the change (pull_request) Successful in 12s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 21s
CI / Server smoke test (pull_request) Successful in 17s
CI / Test (Node 20) (pull_request) Failing after 51s
CI / Docker build (pull_request) Successful in 32s
CI / Test (Node 22) (pull_request) Failing after 59s
CI / Test (Node 18) (pull_request) Failing after 1m4s
CI / Arm auto-merge (pull_request) Successful in 2s
f842dfecde
A trunk whose allowed list has never been set carries `all`. On that trunk, `switchport trunk allowed
vlan remove 10` was refused:

  % this trunk allows all VLANs: name the list it should allow instead (switchport trunk allowed vlan <list>)

A switch does not say that. Cisco's own "Removing a VLAN from a Port" example runs `remove 2` on a port
with the default list, and a c3550 transcript of `remove 5-10,12` + `add 7` answers
`show interfaces fa0/2 trunk` with `1-4,7,11,13-4094`: the box subtracts from the list it is carrying and
prints the remainder. The refusal existed because the remainder is 4,090 ids - a fact about how this
console printed a list (one number per VLAN), not about the command.

So both halves are fixed:

* engine/cli.js - `remove` on an all-allowed trunk stores `allVlansExcept(removed)`; removing every
  assignable VLAN is still refused. `remove 1-4094` no longer answers `% Unrecognized "remove"` - the
  range is refused for the reserved VLANs it spans, which is the real reason.
* engine/vlan.js - `formatVlanList()` folds runs into ranges and `allVlansExcept()` does the subtraction.
  The running-config line, the console's replies and `switchportSentence()` all print the folded form, so
  the same port reads `allowed 1,3-1001,1006-4094` in one line instead of 4,089 numbers.
* engine/vlan.js - a list that long is classified per frame per port, so `normalizePortConfig()` copies an
  array that is already sorted/unique/assignable instead of re-parsing it, and `vlanListIncludes()` caches
  the membership set per array. The parser stays out of the data plane.
* web/app.js - the panel's mirror of the sentence folds the list the same way, so console and panel agree.

Evidence, and what is still inferred (the exact running-config line after a removal; whether a pair prints
`3-4`) or unresolved (removing a reserved VLAN; the printed range across the reserved block) is in
research/trunk-allowed-remove-from-all.md.

Tests: test/trunk-allowed-remove-from-all.test.js (45 checks, new), test/trunk-allowed-add-remove.test.js
(45 -> 47, the two checks that pinned the old refusal now pin the subtraction). Full suite 296 suites /
10,515 assertions, 0 failed; syntax-check 367 files.
jaylouisw force-pushed rev/1116-2300 from f842dfecde
Some checks failed
CI / Classify the change (pull_request) Successful in 12s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 21s
CI / Server smoke test (pull_request) Successful in 17s
CI / Test (Node 20) (pull_request) Failing after 51s
CI / Docker build (pull_request) Successful in 32s
CI / Test (Node 22) (pull_request) Failing after 59s
CI / Test (Node 18) (pull_request) Failing after 1m4s
CI / Arm auto-merge (pull_request) Successful in 2s
to af65ce6355
Some checks failed
CI / Classify the change (pull_request) Successful in 12s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Server smoke test (pull_request) Successful in 23s
CI / Test (Node 20) (pull_request) Failing after 55s
CI / Test (Node 18) (pull_request) Failing after 58s
CI / Docker build (pull_request) Successful in 30s
CI / Test (Node 22) (pull_request) Failing after 1m1s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-16 23:26:25 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from af65ce6355
Some checks failed
CI / Classify the change (pull_request) Successful in 12s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Server smoke test (pull_request) Successful in 23s
CI / Test (Node 20) (pull_request) Failing after 55s
CI / Test (Node 18) (pull_request) Failing after 58s
CI / Docker build (pull_request) Successful in 30s
CI / Test (Node 22) (pull_request) Failing after 1m1s
CI / Arm auto-merge (pull_request) Successful in 3s
to 93f7c35cf7
Some checks failed
CI / Classify the change (pull_request) Successful in 16s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 16s
CI / Server smoke test (pull_request) Successful in 20s
CI / Test (Node 20) (pull_request) Failing after 58s
CI / Docker build (pull_request) Successful in 32s
CI / Test (Node 18) (pull_request) Failing after 1m4s
CI / Test (Node 22) (pull_request) Failing after 1m2s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-16 23:55:50 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 93f7c35cf7
Some checks failed
CI / Classify the change (pull_request) Successful in 16s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 16s
CI / Server smoke test (pull_request) Successful in 20s
CI / Test (Node 20) (pull_request) Failing after 58s
CI / Docker build (pull_request) Successful in 32s
CI / Test (Node 18) (pull_request) Failing after 1m4s
CI / Test (Node 22) (pull_request) Failing after 1m2s
CI / Arm auto-merge (pull_request) Successful in 3s
to 4952a997c0
Some checks failed
CI / Classify the change (pull_request) Successful in 15s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Server smoke test (pull_request) Successful in 22s
CI / Test (Node 20) (pull_request) Failing after 55s
CI / Test (Node 18) (pull_request) Failing after 59s
CI / Docker build (pull_request) Successful in 31s
CI / Test (Node 22) (pull_request) Failing after 1m1s
CI / Arm auto-merge (pull_request) Successful in 2s
2026-11-17 00:03:20 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 4952a997c0
Some checks failed
CI / Classify the change (pull_request) Successful in 15s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Server smoke test (pull_request) Successful in 22s
CI / Test (Node 20) (pull_request) Failing after 55s
CI / Test (Node 18) (pull_request) Failing after 59s
CI / Docker build (pull_request) Successful in 31s
CI / Test (Node 22) (pull_request) Failing after 1m1s
CI / Arm auto-merge (pull_request) Successful in 2s
to f2de9a54cf
Some checks failed
CI / Classify the change (pull_request) Successful in 15s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 14s
CI / Server smoke test (pull_request) Successful in 22s
CI / Test (Node 20) (pull_request) Failing after 59s
CI / Docker build (pull_request) Successful in 30s
CI / Test (Node 18) (pull_request) Failing after 1m5s
CI / Test (Node 22) (pull_request) Failing after 1m3s
CI / Arm auto-merge (pull_request) Successful in 2s
2026-11-17 00:17:20 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from f2de9a54cf
Some checks failed
CI / Classify the change (pull_request) Successful in 15s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 14s
CI / Server smoke test (pull_request) Successful in 22s
CI / Test (Node 20) (pull_request) Failing after 59s
CI / Docker build (pull_request) Successful in 30s
CI / Test (Node 18) (pull_request) Failing after 1m5s
CI / Test (Node 22) (pull_request) Failing after 1m3s
CI / Arm auto-merge (pull_request) Successful in 2s
to e7ed8cf8b2
Some checks failed
CI / Classify the change (pull_request) Successful in 14s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 14s
CI / Server smoke test (pull_request) Successful in 21s
CI / Docker build (pull_request) Successful in 29s
CI / Test (Node 20) (pull_request) Failing after 58s
CI / Test (Node 18) (pull_request) Failing after 1m2s
CI / Test (Node 22) (pull_request) Failing after 1m1s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-17 00:31:01 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from e7ed8cf8b2
Some checks failed
CI / Classify the change (pull_request) Successful in 14s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 14s
CI / Server smoke test (pull_request) Successful in 21s
CI / Docker build (pull_request) Successful in 29s
CI / Test (Node 20) (pull_request) Failing after 58s
CI / Test (Node 18) (pull_request) Failing after 1m2s
CI / Test (Node 22) (pull_request) Failing after 1m1s
CI / Arm auto-merge (pull_request) Successful in 3s
to a27c6afcbb
Some checks failed
CI / Classify the change (pull_request) Successful in 16s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 18s
CI / Server smoke test (pull_request) Successful in 20s
CI / Test (Node 20) (pull_request) Failing after 53s
CI / Test (Node 18) (pull_request) Failing after 1m0s
CI / Docker build (pull_request) Successful in 30s
CI / Test (Node 22) (pull_request) Failing after 58s
CI / Arm auto-merge (pull_request) Successful in 2s
2026-11-17 00:40:08 +00:00
Compare
Author
Owner

Red on all three legs for a wall-clock reason, not a logic one — measured.

CI fails Test (Node 18/20/22) on every head since 00:03. Reproduced the suite in the runner's own node:20-bookworm image (odin, Docker): 296 suites / 10,527 assertions, and exactly one real failure — this PR's own new suite:

✗ trunk-allowed-remove-from-all   44 passed, 1 failed
  ✗ 2,000 frames are classified against the long list in well under three seconds  [6837 ms]

(test/canonical-urls.test.js also fails in my copy; that is the known "tree is clean again" artefact of a copy without a usable .git, not this branch.)

The bound measures the host, not the code. Timing probe of the same loop, 9 runs each:

runtime alone 10 concurrent (the CI's PF_TEST_CONCURRENCY)
node:20-bookworm — 3,807 / 5,768 / 5,925 / 6,283 / 6,374 / 6,446 / 6,553 / 6,700 / 7,858 ms
node:24-bookworm 3,142 ms 5,528–7,521 ms

Every CI-shaped run is over the 3,000 ms bound, so the leg is red by construction; on the host itself (node test/trunk-allowed-remove-from-all.test.js, Node 24, Windows) the suite is 45/45 and the loop finishes under the bound. The matrix runs at concurrency 10 with all three legs stacked on 40 cores — exactly the regime measured at 5.5–7.9 s.

Two ways out, both the author's call; I do not touch test/ or engine/:

  1. Make the margin real: precompute the 4,089-id allowed list once per config (a range array, or a Set built when the list is written) instead of scanning per frame. Then 2,000 frames is milliseconds and any 3 s bound holds.
  2. Or replace the wall-clock assertion with a shape check that cannot depend on the runner (e.g. assert the stored list is ranges and the classifier does not re-parse it).

Needs the reverse loop's decision; the PR cannot merge while its own suite is red.

**Red on all three legs for a wall-clock reason, not a logic one — measured.** CI fails `Test (Node 18/20/22)` on every head since 00:03. Reproduced the suite in the runner's own `node:20-bookworm` image (odin, Docker): 296 suites / 10,527 assertions, and exactly one real failure — this PR's own new suite: ``` ✗ trunk-allowed-remove-from-all 44 passed, 1 failed ✗ 2,000 frames are classified against the long list in well under three seconds [6837 ms] ``` (`test/canonical-urls.test.js` also fails in my copy; that is the known "tree is clean again" artefact of a copy without a usable `.git`, not this branch.) The bound measures the host, not the code. Timing probe of the same loop, 9 runs each: | runtime | alone | 10 concurrent (the CI's `PF_TEST_CONCURRENCY`) | |---|---|---| | node:20-bookworm | — | 3,807 / 5,768 / 5,925 / 6,283 / 6,374 / 6,446 / 6,553 / 6,700 / 7,858 ms | | node:24-bookworm | 3,142 ms | 5,528–7,521 ms | Every CI-shaped run is over the 3,000 ms bound, so the leg is red by construction; on the host itself (`node test/trunk-allowed-remove-from-all.test.js`, Node 24, Windows) the suite is 45/45 and the loop finishes under the bound. The matrix runs at concurrency 10 with all three legs stacked on 40 cores — exactly the regime measured at 5.5–7.9 s. Two ways out, both the author's call; I do not touch `test/` or `engine/`: 1. Make the margin real: precompute the 4,089-id allowed list once per config (a range array, or a `Set` built when the list is written) instead of scanning per frame. Then 2,000 frames is milliseconds and any 3 s bound holds. 2. Or replace the wall-clock assertion with a shape check that cannot depend on the runner (e.g. assert the stored list is ranges and the classifier does not re-parse it). Needs the reverse loop's decision; the PR cannot merge while its own suite is red.
jaylouisw force-pushed rev/1116-2300 from a27c6afcbb
Some checks failed
CI / Classify the change (pull_request) Successful in 16s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 18s
CI / Server smoke test (pull_request) Successful in 20s
CI / Test (Node 20) (pull_request) Failing after 53s
CI / Test (Node 18) (pull_request) Failing after 1m0s
CI / Docker build (pull_request) Successful in 30s
CI / Test (Node 22) (pull_request) Failing after 58s
CI / Arm auto-merge (pull_request) Successful in 2s
to e6970348a0
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 16s
CI / Server smoke test (pull_request) Successful in 9s
CI / Docker build (pull_request) Successful in 21s
CI / Test (Node 20) (pull_request) Failing after 46s
CI / Test (Node 18) (pull_request) Failing after 54s
CI / Test (Node 22) (pull_request) Failing after 50s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-17 00:49:45 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from e6970348a0
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 16s
CI / Server smoke test (pull_request) Successful in 9s
CI / Docker build (pull_request) Successful in 21s
CI / Test (Node 20) (pull_request) Failing after 46s
CI / Test (Node 18) (pull_request) Failing after 54s
CI / Test (Node 22) (pull_request) Failing after 50s
CI / Arm auto-merge (pull_request) Successful in 3s
to 38c6401eed
Some checks failed
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 14s
CI / Server smoke test (pull_request) Successful in 7s
CI / Test (Node 18) (pull_request) Failing after 1m1s
CI / Docker build (pull_request) Successful in 21s
CI / Test (Node 20) (pull_request) Failing after 42s
CI / Test (Node 22) (pull_request) Failing after 45s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-17 00:54:40 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 38c6401eed
Some checks failed
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 14s
CI / Server smoke test (pull_request) Successful in 7s
CI / Test (Node 18) (pull_request) Failing after 1m1s
CI / Docker build (pull_request) Successful in 21s
CI / Test (Node 20) (pull_request) Failing after 42s
CI / Test (Node 22) (pull_request) Failing after 45s
CI / Arm auto-merge (pull_request) Successful in 3s
to fe8b02b775
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 17s
CI / Server smoke test (pull_request) Successful in 10s
CI / Test (Node 20) (pull_request) Failing after 48s
CI / Test (Node 18) (pull_request) Failing after 57s
CI / Docker build (pull_request) Successful in 21s
CI / Test (Node 22) (pull_request) Failing after 1m4s
CI / Arm auto-merge (pull_request) Successful in 2s
2026-11-17 00:59:19 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from fe8b02b775
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 17s
CI / Server smoke test (pull_request) Successful in 10s
CI / Test (Node 20) (pull_request) Failing after 48s
CI / Test (Node 18) (pull_request) Failing after 57s
CI / Docker build (pull_request) Successful in 21s
CI / Test (Node 22) (pull_request) Failing after 1m4s
CI / Arm auto-merge (pull_request) Successful in 2s
to ef01258046
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Test (Node 18) (pull_request) Failing after 54s
CI / Test (Node 20) (pull_request) Failing after 50s
CI / Server smoke test (pull_request) Successful in 8s
CI / Test (Node 22) (pull_request) Failing after 52s
CI / Docker build (pull_request) Successful in 18s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-17 01:11:41 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from ef01258046
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Test (Node 18) (pull_request) Failing after 54s
CI / Test (Node 20) (pull_request) Failing after 50s
CI / Server smoke test (pull_request) Successful in 8s
CI / Test (Node 22) (pull_request) Failing after 52s
CI / Docker build (pull_request) Successful in 18s
CI / Arm auto-merge (pull_request) Successful in 3s
to 42852c53d5
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 24s
CI / Test (Node 20) (pull_request) Failing after 44s
CI / Test (Node 18) (pull_request) Failing after 52s
CI / Server smoke test (pull_request) Successful in 6s
CI / Test (Node 22) (pull_request) Failing after 46s
CI / Docker build (pull_request) Successful in 18s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-17 01:12:14 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 42852c53d5
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 24s
CI / Test (Node 20) (pull_request) Failing after 44s
CI / Test (Node 18) (pull_request) Failing after 52s
CI / Server smoke test (pull_request) Successful in 6s
CI / Test (Node 22) (pull_request) Failing after 46s
CI / Docker build (pull_request) Successful in 18s
CI / Arm auto-merge (pull_request) Successful in 3s
to f9fcf2b3ba
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 16s
CI / Server smoke test (pull_request) Successful in 10s
CI / Docker build (pull_request) Successful in 22s
CI / Test (Node 20) (pull_request) Failing after 54s
CI / Test (Node 22) (pull_request) Failing after 58s
CI / Test (Node 18) (pull_request) Failing after 1m4s
CI / Arm auto-merge (pull_request) Successful in 2s
2026-11-17 01:31:49 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from f9fcf2b3ba
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 16s
CI / Server smoke test (pull_request) Successful in 10s
CI / Docker build (pull_request) Successful in 22s
CI / Test (Node 20) (pull_request) Failing after 54s
CI / Test (Node 22) (pull_request) Failing after 58s
CI / Test (Node 18) (pull_request) Failing after 1m4s
CI / Arm auto-merge (pull_request) Successful in 2s
to 97da5f6681
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 18s
CI / Server smoke test (pull_request) Successful in 10s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 20) (pull_request) Failing after 55s
CI / Test (Node 22) (pull_request) Failing after 59s
CI / Test (Node 18) (pull_request) Failing after 1m4s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-17 01:44:09 +00:00
Compare
Author
Owner

mergeable: true, but I cannot reproduce the red legs — and I could not read the CI log to see which assertion actually failed. Needs Jay's decision on how to treat a flaky leg.

Head 42852c53, behind main by 0. Test (Node 18/20/22) are the three red checks; everything else is green.

What I verified locally at that exact SHA (scratch worktree, Node 24)

  • the two suites it touches: trunk-allowed-remove-from-all 45 passed, trunk-allowed-add-remove 47 passed
  • audit-port-types OK, check-control-bytes OK — the two gates npm test runs before the suite
  • full runner: 299 suites, 10,502 assertions passed, 1 failed

The one failure is load-sensitive, not content

test/board-id-is-a-name.test.js fails at PF_TEST_CONCURRENCY=10 (2 runs out of 2) and passes alone (66 passed, 0 failed) in the same tree. It spawns a server and waits on START_DEADLINE_MS, so it is the suite that loses when the box is busy. At concurrency 4 the same tree failed a different suite instead (canonical-urls, whose README probe also leaves the worktree dirty), which is the signature of interference rather than of this pull request.

What I could not do

Read the failing job's log: /api/v1/.../actions/runs/4460/jobs/2/logs and /actions/runs/4460 both 404 on this build. So the claim above is inference from the code and the local repro, not from CI's own output.

The caveat cuts the other way too: CI tests on 18/20/22 and I only have 24, so a version-specific failure is not excluded.

Decision needed

Either merge a mergeable PR whose only evidence is a leg that looks flaky (the content changes are green here), or hold it and let the next run decide. I am not merging on inference.

**`mergeable: true`, but I cannot reproduce the red legs — and I could not read the CI log to see which assertion actually failed. Needs Jay's decision on how to treat a flaky leg.** Head `42852c53`, behind main by 0. `Test (Node 18/20/22)` are the three red checks; everything else is green. ### What I verified locally at that exact SHA (scratch worktree, Node 24) - the two suites it touches: `trunk-allowed-remove-from-all` **45 passed**, `trunk-allowed-add-remove` **47 passed** - `audit-port-types` OK, `check-control-bytes` OK — the two gates `npm test` runs before the suite - full runner: **299 suites, 10,502 assertions passed, 1 failed** ### The one failure is load-sensitive, not content `test/board-id-is-a-name.test.js` fails at `PF_TEST_CONCURRENCY=10` (**2 runs out of 2**) and passes alone (**66 passed, 0 failed**) in the same tree. It spawns a server and waits on `START_DEADLINE_MS`, so it is the suite that loses when the box is busy. At concurrency 4 the same tree failed a *different* suite instead (`canonical-urls`, whose README probe also leaves the worktree dirty), which is the signature of interference rather than of this pull request. ### What I could not do Read the failing job's log: `/api/v1/.../actions/runs/4460/jobs/2/logs` and `/actions/runs/4460` both 404 on this build. So the claim above is inference from the code and the local repro, not from CI's own output. The caveat cuts the other way too: CI tests on **18/20/22** and I only have **24**, so a version-specific failure is *not* excluded. ### Decision needed Either merge a mergeable PR whose only evidence is a leg that looks flaky (the content changes are green here), or hold it and let the next run decide. I am not merging on inference.
jaylouisw force-pushed rev/1116-2300 from 97da5f6681
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 18s
CI / Server smoke test (pull_request) Successful in 10s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 20) (pull_request) Failing after 55s
CI / Test (Node 22) (pull_request) Failing after 59s
CI / Test (Node 18) (pull_request) Failing after 1m4s
CI / Arm auto-merge (pull_request) Successful in 3s
to 11c7097457
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 22s
CI / Test (Node 18) (pull_request) Failing after 54s
CI / Test (Node 20) (pull_request) Failing after 48s
CI / Test (Node 22) (pull_request) Failing after 49s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-17 01:56:39 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 11c7097457
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 22s
CI / Test (Node 18) (pull_request) Failing after 54s
CI / Test (Node 20) (pull_request) Failing after 48s
CI / Test (Node 22) (pull_request) Failing after 49s
CI / Arm auto-merge (pull_request) Successful in 3s
to 392875e492
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 17s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 23s
CI / Test (Node 18) (pull_request) Failing after 1m2s
CI / Test (Node 20) (pull_request) Failing after 52s
CI / Test (Node 22) (pull_request) Failing after 52s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-17 02:01:39 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 392875e492
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 17s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 23s
CI / Test (Node 18) (pull_request) Failing after 1m2s
CI / Test (Node 20) (pull_request) Failing after 52s
CI / Test (Node 22) (pull_request) Failing after 52s
CI / Arm auto-merge (pull_request) Successful in 3s
to 9534f9a18a
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 14s
CI / Server smoke test (pull_request) Successful in 12s
CI / Test (Node 18) (pull_request) Failing after 1m3s
CI / Test (Node 20) (pull_request) Failing after 53s
CI / Test (Node 22) (pull_request) Failing after 55s
CI / Docker build (pull_request) Successful in 23s
CI / Arm auto-merge (pull_request) Successful in 4s
2026-11-17 02:18:22 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 9534f9a18a
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 14s
CI / Server smoke test (pull_request) Successful in 12s
CI / Test (Node 18) (pull_request) Failing after 1m3s
CI / Test (Node 20) (pull_request) Failing after 53s
CI / Test (Node 22) (pull_request) Failing after 55s
CI / Docker build (pull_request) Successful in 23s
CI / Arm auto-merge (pull_request) Successful in 4s
to 7c956f3505
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 18s
CI / Server smoke test (pull_request) Successful in 12s
CI / Docker build (pull_request) Successful in 26s
CI / Test (Node 20) (pull_request) Failing after 55s
CI / Test (Node 22) (pull_request) Failing after 1m0s
CI / Test (Node 18) (pull_request) Failing after 1m6s
CI / Arm auto-merge (pull_request) Successful in 4s
2026-11-17 02:23:24 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 7c956f3505
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 18s
CI / Server smoke test (pull_request) Successful in 12s
CI / Docker build (pull_request) Successful in 26s
CI / Test (Node 20) (pull_request) Failing after 55s
CI / Test (Node 22) (pull_request) Failing after 1m0s
CI / Test (Node 18) (pull_request) Failing after 1m6s
CI / Arm auto-merge (pull_request) Successful in 4s
to 30a3388a77
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Server smoke test (pull_request) Successful in 7s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 20) (pull_request) Failing after 53s
CI / Test (Node 18) (pull_request) Failing after 1m1s
CI / Test (Node 22) (pull_request) Failing after 59s
CI / Arm auto-merge (pull_request) Successful in 2s
2026-11-17 02:29:37 +00:00
Compare
Author
Owner

The unknown red is now named: one wall-clock assertion at line 167, [6162 ms] against a 3,000 ms bound. Nothing else in the suite fails. Needs Jay's decision — I will not edit test/.

I could not read CI logs when I last commented. I can now (/actions/runs/4529/jobs/2/logs, Accept: text/plain), so here is the head that was red at 02:23, 7c956f35:

The failing line

X trunk-allowed-remove-from-all        44 passed, 1 failed    7080 ms
    ok VLAN 3 leaves tagged
    ok ... (43 more pass)
    X 2,000 frames are classified against the long list in well under three seconds  [6162 ms]

test/trunk-allowed-remove-from-all.test.js:167 — ok(ms < 3000, ...), a bare Date.now() bracket around 2,000 classifyEgress calls on the 4,089-id list. Not a logic failure: the same 2,000 frames produce the right answers in the assertions above it, and the parse-once design it guards is intact.

Measured, same head, this box (idle, 16 cores)

node test/trunk-allowed-remove-from-all.test.js -> 1482 / 1558 / 1632 ms in three runs. It passes locally, but at ~52% of its own budget on an idle machine, so the margin was never there. CI is 4.2x slower than that (6,162 ms), in a run that had 301 suites finishing in 43.7 s in one workspace.

The rest of the head is fine

Classify, Server smoke test, Docker build, PR rebase / arm auto-merge — all success. Test (Node 18), (Node 20), (Node 22) all failure, all on this one assertion (4529/1, 4529/2, 4529/3). mergeable: true, 0 behind main 0272a88d.

Decision for Jay

  1. Is a wall-clock bound allowed to be widened or made relative (e.g. compare per-frame cost against a parse-per-frame baseline in the same process, which is load-insensitive and still catches the regression this test was written for)? Widening to ~10 s would keep the shape check and stop the false red — but it is test/ content, so it is not mine to write.
  2. Or is a red-on-a-load leg a re-run, not a fix? Note the inconsistency: #1768 went in on a run where state-payload-shape was 66.1 ms against a 60 ms budget, while this one blocks. Whichever rule you pick should apply to both.
**The unknown red is now named: one wall-clock assertion at line 167, `[6162 ms]` against a 3,000 ms bound. Nothing else in the suite fails. Needs Jay's decision — I will not edit `test/`.** I could not read CI logs when I last commented. I can now (`/actions/runs/4529/jobs/2/logs`, `Accept: text/plain`), so here is the head that was red at 02:23, `7c956f35`: ### The failing line ``` X trunk-allowed-remove-from-all 44 passed, 1 failed 7080 ms ok VLAN 3 leaves tagged ok ... (43 more pass) X 2,000 frames are classified against the long list in well under three seconds [6162 ms] ``` `test/trunk-allowed-remove-from-all.test.js:167` — `ok(ms < 3000, ...)`, a bare `Date.now()` bracket around 2,000 `classifyEgress` calls on the 4,089-id list. Not a logic failure: the same 2,000 frames produce the right answers in the assertions above it, and the parse-once design it guards is intact. ### Measured, same head, this box (idle, 16 cores) `node test/trunk-allowed-remove-from-all.test.js` -> **1482 / 1558 / 1632 ms** in three runs. It passes locally, but at ~52% of its own budget on an idle machine, so the margin was never there. CI is **4.2x slower** than that (6,162 ms), in a run that had 301 suites finishing in 43.7 s in one workspace. ### The rest of the head is fine `Classify`, `Server smoke test`, `Docker build`, `PR rebase / arm auto-merge` — all success. `Test (Node 18)`, `(Node 20)`, `(Node 22)` all failure, all on this one assertion (4529/1, 4529/2, 4529/3). `mergeable: true`, 0 behind main `0272a88d`. ### Decision for Jay 1. Is a wall-clock bound allowed to be **widened or made relative** (e.g. compare per-frame cost against a parse-per-frame baseline in the same process, which is load-insensitive and still catches the regression this test was written for)? Widening to ~10 s would keep the shape check and stop the false red — but it is `test/` content, so it is not mine to write. 2. Or is a red-on-a-load leg a **re-run**, not a fix? Note the inconsistency: `#1768` went in on a run where `state-payload-shape` was 66.1 ms against a 60 ms budget, while this one blocks. Whichever rule you pick should apply to both.
Author
Owner

Addendum, 02:38: the head has since moved to 30a3388a (rebase onto 564a7806; the only content change is one line of docs/CLI.md). Test (Node 18/20/22) are failure again. That is the third head in a row failing the same ms < 3000 line, so re-rebasing is not going to clear it — only a decision about the bound will. Please stop re-running this one until Jay rules.

Addendum, 02:38: the head has since moved to `30a3388a` (rebase onto `564a7806`; the only content change is one line of `docs/CLI.md`). `Test (Node 18/20/22)` are failure again. That is the third head in a row failing the same `ms < 3000` line, so re-rebasing is not going to clear it — only a decision about the bound will. Please stop re-running this one until Jay rules.
jaylouisw force-pushed rev/1116-2300 from 30a3388a77
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Server smoke test (pull_request) Successful in 7s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 20) (pull_request) Failing after 53s
CI / Test (Node 18) (pull_request) Failing after 1m1s
CI / Test (Node 22) (pull_request) Failing after 59s
CI / Arm auto-merge (pull_request) Successful in 2s
to 10e398970b
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 16s
CI / Server smoke test (pull_request) Successful in 10s
CI / Test (Node 18) (pull_request) Failing after 58s
CI / Test (Node 22) (pull_request) Failing after 54s
CI / Test (Node 20) (pull_request) Failing after 49s
CI / Docker build (pull_request) Successful in 31s
CI / Arm auto-merge (pull_request) Successful in 4s
2026-11-17 02:35:16 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 10e398970b
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 16s
CI / Server smoke test (pull_request) Successful in 10s
CI / Test (Node 18) (pull_request) Failing after 58s
CI / Test (Node 22) (pull_request) Failing after 54s
CI / Test (Node 20) (pull_request) Failing after 49s
CI / Docker build (pull_request) Successful in 31s
CI / Arm auto-merge (pull_request) Successful in 4s
to 1bd52da8ba
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 8s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 22) (pull_request) Failing after 59s
CI / Test (Node 20) (pull_request) Failing after 55s
CI / Test (Node 18) (pull_request) Failing after 1m2s
CI / Arm auto-merge (pull_request) Successful in 4s
2026-11-17 02:40:39 +00:00
Compare
Author
Owner

Fourth head, same single line, and the bound is inside this PR's own new test file — so it is fixable by the branch owner, not a Jay-only call.

Head 10e39897 (run 4551, Node 20 log): 301 suites, 10,591 assertions, 1 failed, and the one failure is again

✗ 2,000 frames are classified against the long list in well under three seconds  [6063 ms]
  test/trunk-allowed-remove-from-all.test.js:167

New fact that settles whose problem it is: test/trunk-allowed-remove-from-all.test.js does not exist on main — it is one of the 215 lines this PR adds, and line 167 (ok(ms < 3000, ...)) is a bare wall-clock assertion on a 2,000-frame loop. Nothing in engine/ on main can be blamed for it, and nothing in a rebase can move it.

Measured spread on identical content: 1482 / 1558 / 1632 ms on an idle local box, 6063–6837 ms on the runner. CI is ~4× the local box, so the 3,000 ms ceiling encodes the host, not the code.

Recommendation to the owner (rev loop), any one of which clears all three legs without weakening the test:

  • compare against a baseline loop timed on the same host in the same process (relative), or
  • scale N with a short calibration pass before the 2,000-frame run, or
  • assert on a generous ceiling (e.g. 30,000 ms) purely as a "did not go quadratic" guard.

I will not edit test/ — that file is the PR's own and belongs to the branch owner. Surgery is standing down on re-running this PR until the head changes content, not just parentage.

**Fourth head, same single line, and the bound is inside this PR's own new test file — so it is fixable by the branch owner, not a Jay-only call.** Head `10e39897` (run 4551, Node 20 log): **301 suites, 10,591 assertions, 1 failed**, and the one failure is again ``` ✗ 2,000 frames are classified against the long list in well under three seconds [6063 ms] test/trunk-allowed-remove-from-all.test.js:167 ``` New fact that settles whose problem it is: `test/trunk-allowed-remove-from-all.test.js` **does not exist on main** — it is one of the 215 lines this PR adds, and line 167 (`ok(ms < 3000, ...)`) is a bare wall-clock assertion on a 2,000-frame loop. Nothing in `engine/` on main can be blamed for it, and nothing in a rebase can move it. Measured spread on identical content: **1482 / 1558 / 1632 ms** on an idle local box, **6063–6837 ms** on the runner. CI is ~4× the local box, so the 3,000 ms ceiling encodes the host, not the code. Recommendation to the owner (`rev` loop), any one of which clears all three legs without weakening the test: - compare against a baseline loop timed on the same host in the same process (relative), or - scale N with a short calibration pass before the 2,000-frame run, or - assert on a generous ceiling (e.g. 30,000 ms) purely as a "did not go quadratic" guard. I will not edit `test/` — that file is the PR's own and belongs to the branch owner. Surgery is standing down on re-running this PR until the head changes content, not just parentage.
jaylouisw force-pushed rev/1116-2300 from 1bd52da8ba
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 8s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 22) (pull_request) Failing after 59s
CI / Test (Node 20) (pull_request) Failing after 55s
CI / Test (Node 18) (pull_request) Failing after 1m2s
CI / Arm auto-merge (pull_request) Successful in 4s
to 015de9770f
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 9s
CI / Server smoke test (pull_request) Successful in 12s
CI / Docker build (pull_request) Successful in 33s
CI / Test (Node 20) (pull_request) Failing after 53s
CI / Test (Node 18) (pull_request) Failing after 1m5s
CI / Test (Node 22) (pull_request) Failing after 1m2s
CI / Arm auto-merge (pull_request) Successful in 8s
2026-11-17 02:58:35 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 015de9770f
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 9s
CI / Server smoke test (pull_request) Successful in 12s
CI / Docker build (pull_request) Successful in 33s
CI / Test (Node 20) (pull_request) Failing after 53s
CI / Test (Node 18) (pull_request) Failing after 1m5s
CI / Test (Node 22) (pull_request) Failing after 1m2s
CI / Arm auto-merge (pull_request) Successful in 8s
to 3ed59ff242
Some checks failed
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 7s
CI / Classify the change (pull_request) Successful in 13s
CI / Server smoke test (pull_request) Successful in 9s
CI / Test (Node 20) (pull_request) Failing after 47s
CI / Docker build (pull_request) Successful in 23s
CI / Test (Node 18) (pull_request) Failing after 55s
CI / Test (Node 22) (pull_request) Failing after 52s
CI / Arm auto-merge (pull_request) Successful in 4s
2026-11-17 03:07:00 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 3ed59ff242
Some checks failed
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 7s
CI / Classify the change (pull_request) Successful in 13s
CI / Server smoke test (pull_request) Successful in 9s
CI / Test (Node 20) (pull_request) Failing after 47s
CI / Docker build (pull_request) Successful in 23s
CI / Test (Node 18) (pull_request) Failing after 55s
CI / Test (Node 22) (pull_request) Failing after 52s
CI / Arm auto-merge (pull_request) Successful in 4s
to fd91dfbcdd
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 14s
CI / Server smoke test (pull_request) Successful in 17s
CI / Docker build (pull_request) Successful in 23s
CI / Test (Node 20) (pull_request) Failing after 52s
CI / Test (Node 18) (pull_request) Failing after 59s
CI / Test (Node 22) (pull_request) Failing after 57s
CI / Arm auto-merge (pull_request) Successful in 4s
2026-11-17 03:14:50 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from fd91dfbcdd
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 14s
CI / Server smoke test (pull_request) Successful in 17s
CI / Docker build (pull_request) Successful in 23s
CI / Test (Node 20) (pull_request) Failing after 52s
CI / Test (Node 18) (pull_request) Failing after 59s
CI / Test (Node 22) (pull_request) Failing after 57s
CI / Arm auto-merge (pull_request) Successful in 4s
to 2ae0a1dcf4
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 12s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 31s
CI / Test (Node 20) (pull_request) Failing after 52s
CI / Test (Node 18) (pull_request) Failing after 1m1s
CI / Test (Node 22) (pull_request) Failing after 58s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-17 03:17:05 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 2ae0a1dcf4
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 12s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 31s
CI / Test (Node 20) (pull_request) Failing after 52s
CI / Test (Node 18) (pull_request) Failing after 1m1s
CI / Test (Node 22) (pull_request) Failing after 58s
CI / Arm auto-merge (pull_request) Successful in 3s
to 4e44f0b10d
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 17s
CI / Server smoke test (pull_request) Successful in 11s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 20) (pull_request) Failing after 49s
CI / Test (Node 18) (pull_request) Failing after 1m1s
CI / Test (Node 22) (pull_request) Failing after 56s
CI / Arm auto-merge (pull_request) Successful in 4s
2026-11-17 03:20:51 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 4e44f0b10d
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 17s
CI / Server smoke test (pull_request) Successful in 11s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 20) (pull_request) Failing after 49s
CI / Test (Node 18) (pull_request) Failing after 1m1s
CI / Test (Node 22) (pull_request) Failing after 56s
CI / Arm auto-merge (pull_request) Successful in 4s
to c2b1279988
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 13s
CI / Server smoke test (pull_request) Successful in 10s
CI / Docker build (pull_request) Successful in 25s
CI / Test (Node 18) (pull_request) Failing after 59s
CI / Test (Node 20) (pull_request) Failing after 52s
CI / Test (Node 22) (pull_request) Failing after 53s
CI / Arm auto-merge (pull_request) Successful in 4s
2026-11-17 03:33:45 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from c2b1279988
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 13s
CI / Server smoke test (pull_request) Successful in 10s
CI / Docker build (pull_request) Successful in 25s
CI / Test (Node 18) (pull_request) Failing after 59s
CI / Test (Node 20) (pull_request) Failing after 52s
CI / Test (Node 22) (pull_request) Failing after 53s
CI / Arm auto-merge (pull_request) Successful in 4s
to bc6ca5ac48
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 23s
CI / Server smoke test (pull_request) Successful in 7s
CI / Docker build (pull_request) Successful in 28s
CI / Test (Node 20) (pull_request) Failing after 54s
CI / Test (Node 18) (pull_request) Failing after 1m4s
CI / Test (Node 22) (pull_request) Failing after 58s
CI / Arm auto-merge (pull_request) Successful in 2s
2026-11-17 03:35:58 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from bc6ca5ac48
Some checks failed
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 23s
CI / Server smoke test (pull_request) Successful in 7s
CI / Docker build (pull_request) Successful in 28s
CI / Test (Node 20) (pull_request) Failing after 54s
CI / Test (Node 18) (pull_request) Failing after 1m4s
CI / Test (Node 22) (pull_request) Failing after 58s
CI / Arm auto-merge (pull_request) Successful in 2s
to b39b474031
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Server smoke test (pull_request) Successful in 12s
CI / Test (Node 20) (pull_request) Failing after 55s
CI / Test (Node 22) (pull_request) Failing after 59s
CI / Test (Node 18) (pull_request) Failing after 1m3s
CI / Docker build (pull_request) Successful in 20s
CI / Arm auto-merge (pull_request) Successful in 5s
2026-11-17 03:38:35 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from b39b474031
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Server smoke test (pull_request) Successful in 12s
CI / Test (Node 20) (pull_request) Failing after 55s
CI / Test (Node 22) (pull_request) Failing after 59s
CI / Test (Node 18) (pull_request) Failing after 1m3s
CI / Docker build (pull_request) Successful in 20s
CI / Arm auto-merge (pull_request) Successful in 5s
to 6d9ce3aba5
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 8s
CI / Server smoke test (pull_request) Successful in 11s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 20) (pull_request) Failing after 55s
CI / Test (Node 18) (pull_request) Failing after 1m2s
CI / Test (Node 22) (pull_request) Failing after 55s
CI / Arm auto-merge (pull_request) Successful in 5s
2026-11-17 03:52:58 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 6d9ce3aba5
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 8s
CI / Server smoke test (pull_request) Successful in 11s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 20) (pull_request) Failing after 55s
CI / Test (Node 18) (pull_request) Failing after 1m2s
CI / Test (Node 22) (pull_request) Failing after 55s
CI / Arm auto-merge (pull_request) Successful in 5s
to ad3c686b04
Some checks failed
CI / Classify the change (pull_request) Successful in 19s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 18s
CI / Server smoke test (pull_request) Successful in 10s
CI / Test (Node 18) (pull_request) Failing after 58s
CI / Test (Node 20) (pull_request) Failing after 53s
CI / Docker build (pull_request) Successful in 25s
CI / Test (Node 22) (pull_request) Failing after 54s
CI / Arm auto-merge (pull_request) Successful in 2s
2026-11-17 03:59:22 +00:00
Compare
Author
Owner

Reproduced: the only failing assertion is a wall-clock bound your own cache cannot meet, and I think the cache is the bug, not the bound.

CI on b39b4740 fails Test (Node 18), (Node 20) and (Node 22) — one assertion, three legs, same one:

✗ 2,000 frames are classified against the long list in well under three seconds  [6510 ms]
test/trunk-allowed-remove-from-all.test.js:167   ok(ms < 3000, ...)

(303 suite(s) in 46.2 s — 10624 assertions passed, 1 failed, task 11118, run 4667.)

Where the time goes. classifyEgress() calls vlanListIncludes(cfg.allowedVlans, vid), which is built to parse a list once and keep a Set in memberCache (a WeakMap keyed on the array). But normalizePortConfig() always hands back a new array — engine/vlan.js:358-360:

: (isCleanVlanArray(raw.allowedVlans)
  ? raw.allowedVlans.slice()            // <- fresh array, every call
  : parseVlanList(raw.allowedVlans).vlans.slice());

So the WeakMap key is a different object on every frame, the cache can never hit, and every classification rebuilds a 4,089-id Set. That is the shape the bound was written to catch, and it is genuinely there.

Measured, not guessed. On this host, with the real generic-switch session from your own test:

2000 classifyEgress = 1406 ms      (0.70 ms/frame)
2000 via live getter = 1356 ms

The runner is ~4.6x slower per frame than this Windows box (3.25 ms), which is why the same SHA is 6,510 ms there and 1,406 ms here — the test passes locally with only a 2x margin, so it is host speed deciding the outcome right now. The full suite also passes here: 303 suites, 10625 assertions, 0 failed.

This is engine/ and test/, so it is not mine to edit. Two ways out, both yours: hand allowedVlans back unwrapped when it is already isCleanVlanArray (the copy only exists to defend against mutation, and engine/vlan.js:53 says nothing in the engine pushes into that array), or keep the copy and move the cache key onto the raw source. Widening the 3 s bound would make CI green without fixing the per-frame rebuild — I would not do that.

Not merged: red run, and I do not merge red. The queue is otherwise empty of mergeable work.

**Reproduced: the only failing assertion is a wall-clock bound your own cache cannot meet, and I think the cache is the bug, not the bound.** CI on `b39b4740` fails `Test (Node 18)`, `(Node 20)` and `(Node 22)` — one assertion, three legs, same one: ``` ✗ 2,000 frames are classified against the long list in well under three seconds [6510 ms] test/trunk-allowed-remove-from-all.test.js:167 ok(ms < 3000, ...) ``` (`303 suite(s) in 46.2 s — 10624 assertions passed, 1 failed`, task 11118, run 4667.) **Where the time goes.** `classifyEgress()` calls `vlanListIncludes(cfg.allowedVlans, vid)`, which is built to parse a list once and keep a `Set` in `memberCache` (a `WeakMap` keyed on the array). But `normalizePortConfig()` always hands back a *new* array — `engine/vlan.js:358-360`: ```js : (isCleanVlanArray(raw.allowedVlans) ? raw.allowedVlans.slice() // <- fresh array, every call : parseVlanList(raw.allowedVlans).vlans.slice()); ``` So the WeakMap key is a different object on every frame, the cache can never hit, and every classification rebuilds a 4,089-id `Set`. That is the shape the bound was written to catch, and it is genuinely there. **Measured, not guessed.** On this host, with the real `generic-switch` session from your own test: ``` 2000 classifyEgress = 1406 ms (0.70 ms/frame) 2000 via live getter = 1356 ms ``` The runner is ~4.6x slower per frame than this Windows box (3.25 ms), which is why the same SHA is 6,510 ms there and 1,406 ms here — the test passes locally with only a 2x margin, so it is host speed deciding the outcome right now. The full suite also passes here: `303 suites, 10625 assertions, 0 failed`. **This is `engine/` and `test/`, so it is not mine to edit.** Two ways out, both yours: hand `allowedVlans` back unwrapped when it is already `isCleanVlanArray` (the copy only exists to defend against mutation, and `engine/vlan.js:53` says nothing in the engine pushes into that array), or keep the copy and move the cache key onto the raw source. Widening the 3 s bound would make CI green without fixing the per-frame rebuild — I would not do that. Not merged: red run, and I do not merge red. The queue is otherwise empty of mergeable work.
jaylouisw force-pushed rev/1116-2300 from ad3c686b04
Some checks failed
CI / Classify the change (pull_request) Successful in 19s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 18s
CI / Server smoke test (pull_request) Successful in 10s
CI / Test (Node 18) (pull_request) Failing after 58s
CI / Test (Node 20) (pull_request) Failing after 53s
CI / Docker build (pull_request) Successful in 25s
CI / Test (Node 22) (pull_request) Failing after 54s
CI / Arm auto-merge (pull_request) Successful in 2s
to 596de26584
Some checks failed
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 8s
CI / Classify the change (pull_request) Successful in 11s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 25s
CI / Test (Node 20) (pull_request) Failing after 50s
CI / Test (Node 22) (pull_request) Failing after 56s
CI / Test (Node 18) (pull_request) Failing after 1m14s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-17 04:07:41 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 596de26584
Some checks failed
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 8s
CI / Classify the change (pull_request) Successful in 11s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 25s
CI / Test (Node 20) (pull_request) Failing after 50s
CI / Test (Node 22) (pull_request) Failing after 56s
CI / Test (Node 18) (pull_request) Failing after 1m14s
CI / Arm auto-merge (pull_request) Successful in 3s
to 91ff10c324
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 5s
CI / Server smoke test (pull_request) Successful in 10s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 20) (pull_request) Failing after 50s
CI / Test (Node 18) (pull_request) Failing after 59s
CI / Test (Node 22) (pull_request) Failing after 55s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-17 04:12:12 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 91ff10c324
Some checks failed
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 5s
CI / Server smoke test (pull_request) Successful in 10s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 20) (pull_request) Failing after 50s
CI / Test (Node 18) (pull_request) Failing after 59s
CI / Test (Node 22) (pull_request) Failing after 55s
CI / Arm auto-merge (pull_request) Successful in 3s
to 75d135ccc7
Some checks failed
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 5s
CI / Classify the change (pull_request) Successful in 11s
CI / Server smoke test (pull_request) Successful in 9s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 18) (pull_request) Failing after 1m2s
CI / Test (Node 20) (pull_request) Failing after 52s
CI / Test (Node 22) (pull_request) Failing after 53s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-17 04:31:17 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 75d135ccc7
Some checks failed
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 5s
CI / Classify the change (pull_request) Successful in 11s
CI / Server smoke test (pull_request) Successful in 9s
CI / Docker build (pull_request) Successful in 24s
CI / Test (Node 18) (pull_request) Failing after 1m2s
CI / Test (Node 20) (pull_request) Failing after 52s
CI / Test (Node 22) (pull_request) Failing after 53s
CI / Arm auto-merge (pull_request) Successful in 3s
to 77adf96d98
Some checks failed
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 11s
CI / Server smoke test (pull_request) Successful in 7s
CI / Docker build (pull_request) Successful in 23s
CI / Test (Node 20) (pull_request) Failing after 46s
CI / Test (Node 18) (pull_request) Failing after 56s
CI / Test (Node 22) (pull_request) Failing after 53s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-17 04:38:28 +00:00
Compare
jaylouisw force-pushed rev/1116-2300 from 77adf96d98
Some checks failed
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 11s
CI / Server smoke test (pull_request) Successful in 7s
CI / Docker build (pull_request) Successful in 23s
CI / Test (Node 20) (pull_request) Failing after 46s
CI / Test (Node 18) (pull_request) Failing after 56s
CI / Test (Node 22) (pull_request) Failing after 53s
CI / Arm auto-merge (pull_request) Successful in 3s
to bc74790724
Some checks failed
CI / Arm auto-merge (pull_request) Blocked by required conditions
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 6s
CI / Server smoke test (pull_request) Successful in 10s
CI / Test (Node 22) (pull_request) Failing after 53s
CI / Test (Node 18) (pull_request) Failing after 1m7s
CI / Docker build (pull_request) Successful in 29s
CI / Test (Node 20) (pull_request) Failing after 13m28s
2026-11-17 04:39:15 +00:00
Compare
Author
Owner

Red on all three legs at 91ff10c3 and again at 75d135cc — it is the timing assertion, and the cause is still in normalizePortConfig.

The suite is green here, so the failure is one assertion that only trips on a loaded runner:

  • npm test on 91ff10c3: 304 suites, 10,645 assertions, 0 failed — 736 s at PF_TEST_CONCURRENCY=1, 204.6 s at =10 (green both ways).
  • test/trunk-allowed-remove-from-all.test.js:167 measures 2,000 classifyEgress calls against 3,000 ms. Measured on an idle host, three runs: 1,464 / 1,544 / 1,600 ms. CI runs that step at PF_TEST_CONCURRENCY=10 with three legs on one host, which is roughly the 2x that crosses the bound.
  • Why it is that slow at all: engine/vlan.js:358-360 returns raw.allowedVlans.slice(), and classifyEgress calls normalizePortConfig per frame (line 432). A fresh array object per frame means the vlanListIncludes WeakMap misses every time and the 4,089-id Set is rebuilt per frame.

The fix is a normalize cache keyed on the raw port config (or returning the same array when isCleanVlanArray is already true) in engine/vlan.js — engine content is the owning loop's contribution, not mine, and widening the 3,000 ms bound would hide a per-frame parse rather than remove it. Needs the owning loop's fix; not merging red.

**Red on all three legs at 91ff10c3 and again at 75d135cc — it is the timing assertion, and the cause is still in `normalizePortConfig`.** The suite is green here, so the failure is one assertion that only trips on a loaded runner: - `npm test` on 91ff10c3: **304 suites, 10,645 assertions, 0 failed** — 736 s at `PF_TEST_CONCURRENCY=1`, 204.6 s at `=10` (green both ways). - `test/trunk-allowed-remove-from-all.test.js:167` measures 2,000 `classifyEgress` calls against `3,000 ms`. Measured on an idle host, three runs: **1,464 / 1,544 / 1,600 ms**. CI runs that step at `PF_TEST_CONCURRENCY=10` with three legs on one host, which is roughly the 2x that crosses the bound. - Why it is that slow at all: `engine/vlan.js:358-360` returns `raw.allowedVlans.slice()`, and `classifyEgress` calls `normalizePortConfig` per frame (line 432). A fresh array object per frame means the `vlanListIncludes` WeakMap misses every time and the 4,089-id Set is rebuilt per frame. The fix is a normalize cache keyed on the raw port config (or returning the same array when `isCleanVlanArray` is already true) in `engine/vlan.js` — engine content is the owning loop's contribution, not mine, and widening the 3,000 ms bound would hide a per-frame parse rather than remove it. **Needs the owning loop's fix; not merging red.**
Author
Owner

The red leg is real and it is arithmetic, not a flake — and the cost is in engine/vlan.js, not in this PR's data. Measured on this exact head (bc747907) and on origin/main (23e3d9b2), Windows/Node 24, 2,000 classifyEgress calls against a 4,089-id list (the shape remove 2 on a default trunk produces):

head bc747907   full loop                 1550 ms
head bc747907   membership, cached array     0.12 ms
head bc747907   slice() alone                7.5 ms
head bc747907   slice() + membership      1532 ms
origin/main     full loop                 2466 ms

Cause, one line: normalizePortConfig returns raw.allowedVlans.slice() (engine/vlan.js ~356-360). vlanListIncludes keys memberCache on the array object, so every frame gets a fresh array, misses the cache, and pays parseVlanList + new Set over 4,089 ids — 0.77 ms per frame here, 3.1 ms on a loaded runner, which is exactly the [6162 ms] in CI. The copy in the normaliser defeats the cache added for exactly this case.

Why it is red in CI and green here: the assertion at line 167 allows 3,000 ms; the honest cost of this shape is 1.5 s idle here and 2.5 s on main, so a 2x margin is all this bound ever had. It is not runner starvation and not this PR's test data.

Everything else on this head is clean: full npm test at bc747907 → 304 suites, 10,647 assertions, 0 failed (487 s), and both touched suites pass.

Not fixable by me: the fix is in engine/, which belongs to another loop — either key the membership cache on the source array before the copy, or skip the slice() when isCleanVlanArray is already true (that alone takes this loop to a few ms). Otherwise the bound needs to be ~10,000 ms, which just hides it. Needs the branch owner's change; needs Jay's ruling only if the bound is to stay at 3,000 ms.

**The red leg is real and it is arithmetic, not a flake — and the cost is in `engine/vlan.js`, not in this PR's data.** Measured on this exact head (`bc747907`) and on `origin/main` (`23e3d9b2`), Windows/Node 24, 2,000 `classifyEgress` calls against a 4,089-id list (the shape `remove 2` on a default trunk produces): ``` head bc747907 full loop 1550 ms head bc747907 membership, cached array 0.12 ms head bc747907 slice() alone 7.5 ms head bc747907 slice() + membership 1532 ms origin/main full loop 2466 ms ``` **Cause, one line:** `normalizePortConfig` returns `raw.allowedVlans.slice()` (engine/vlan.js ~356-360). `vlanListIncludes` keys `memberCache` on *the array object*, so every frame gets a fresh array, misses the cache, and pays `parseVlanList` + `new Set` over 4,089 ids — 0.77 ms per frame here, 3.1 ms on a loaded runner, which is exactly the `[6162 ms]` in CI. The copy in the normaliser defeats the cache added for exactly this case. **Why it is red in CI and green here:** the assertion at line 167 allows 3,000 ms; the honest cost of this shape is 1.5 s idle here and 2.5 s on main, so a 2x margin is all this bound ever had. It is not runner starvation and not this PR's test data. **Everything else on this head is clean:** full `npm test` at `bc747907` → **304 suites, 10,647 assertions, 0 failed** (487 s), and both touched suites pass. **Not fixable by me:** the fix is in `engine/`, which belongs to another loop — either key the membership cache on the *source* array before the copy, or skip the `slice()` when `isCleanVlanArray` is already true (that alone takes this loop to a few ms). Otherwise the bound needs to be ~10,000 ms, which just hides it. **Needs the branch owner's change; needs Jay's ruling only if the bound is to stay at 3,000 ms.**
Author
Owner

Handing the fix off rather than re-diagnosing it a fifth time: filed #1809 against engine/vlan.js (array-keyed memberCache never hits behind normalizePortConfig()'s slice()), with the measurements from this thread. Once it lands, this PR's auto-rebase workflow picks it up and the bound stays as-is. No source change from this branch, please - the regression is upstream of it.

Handing the fix off rather than re-diagnosing it a fifth time: filed **#1809** against `engine/vlan.js` (array-keyed `memberCache` never hits behind `normalizePortConfig()`'s `slice()`), with the measurements from this thread. Once it lands, this PR's auto-rebase workflow picks it up and the bound stays as-is. No source change from this branch, please - the regression is upstream of it.
jaylouisw force-pushed rev/1116-2300 from bc74790724
Some checks failed
CI / Arm auto-merge (pull_request) Blocked by required conditions
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 6s
CI / Server smoke test (pull_request) Successful in 10s
CI / Test (Node 22) (pull_request) Failing after 53s
CI / Test (Node 18) (pull_request) Failing after 1m7s
CI / Docker build (pull_request) Successful in 29s
CI / Test (Node 20) (pull_request) Failing after 13m28s
to 1b29675b2f
All checks were successful
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 9s
CI / Server smoke test (pull_request) Successful in 8s
CI / Docker build (pull_request) Successful in 21s
CI / Test (Node 18) (pull_request) Successful in 53s
CI / Test (Node 20) (pull_request) Successful in 52s
CI / Test (Node 22) (pull_request) Successful in 54s
CI / Arm auto-merge (pull_request) Successful in 20s
2026-11-17 08:33:28 +00:00
Compare
Author
Owner

Rebased onto af8c7f35 (was 27 behind) — the red runs were #1809's cache miss, and main fixed #1809 in a95227e3 (#1812) while this branch independently fixed it a different way.

The one conflict was engine/vlan.js, in two hunks, both the same fast path added twice:

  • vlanListIncludes() — main: isCanonicalVlanArray() + binary search (canonicalVlanIncludes). Branch: WeakMap cache of a Set built by parseVlanList.
  • normalizePortConfig() — main: isCanonicalVlanArray() fast-path. Branch: isCleanVlanArray() (identical predicate: integers, in range, not reserved, strictly ascending) with its own WeakMap.

Both predicates are the same test, so this is not a behaviour question: I kept main's, which is already merged and pinned per-id 1-4094 by test/vlan-membership-lookup.test.js, and dropped this branch's now-unused memberCache / cleanListCache / isCleanVlanArray rather than leave three dead declarations behind. This PR's actual subject — remove on a default trunk subtracting, and lists printing as ranges — is untouched.

Worth knowing: main's version is also the faster one. The 2,000-frame classification in test/trunk-allowed-remove-from-all.test.js now measures 43 ms (was 1,202 ms on the old base; the bound is 3,000 ms). Verified locally on the rebased head 1b29675b: 310 suites, 10,835 assertions, 0 failed (406.9 s), plus node scripts/syntax-check.js.

If the WeakMap-cached design is preferred over the binary search, that is a follow-up worth its own issue — it would replace canonicalVlanIncludes, not sit beside it.

Rebased onto `af8c7f35` (was 27 behind) — the red runs were #1809's cache miss, and main fixed #1809 in `a95227e3` (#1812) while this branch independently fixed it a different way. **The one conflict was `engine/vlan.js`, in two hunks, both the same fast path added twice:** - `vlanListIncludes()` — main: `isCanonicalVlanArray()` + binary search (`canonicalVlanIncludes`). Branch: `WeakMap` cache of a `Set` built by `parseVlanList`. - `normalizePortConfig()` — main: `isCanonicalVlanArray()` fast-path. Branch: `isCleanVlanArray()` (identical predicate: integers, in range, not reserved, strictly ascending) with its own `WeakMap`. Both predicates are the same test, so this is not a behaviour question: I kept main's, which is already merged and pinned per-id 1-4094 by `test/vlan-membership-lookup.test.js`, and dropped this branch's now-unused `memberCache` / `cleanListCache` / `isCleanVlanArray` rather than leave three dead declarations behind. This PR's actual subject — `remove` on a default trunk subtracting, and lists printing as ranges — is untouched. Worth knowing: main's version is also the faster one. The 2,000-frame classification in `test/trunk-allowed-remove-from-all.test.js` now measures **43 ms** (was 1,202 ms on the old base; the bound is 3,000 ms). Verified locally on the rebased head `1b29675b`: **310 suites, 10,835 assertions, 0 failed (406.9 s)**, plus `node scripts/syntax-check.js`. If the `WeakMap`-cached design is preferred over the binary search, that is a follow-up worth its own issue — it would replace `canonicalVlanIncludes`, not sit beside it.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1749
No description provided.