CI: the smoke job downloads Node 20 onto Node 20 (most of a 48 s job) #1633

Merged
jaylouisw merged 1 commit from ci/1116-0820 into main 2026-11-16 08:24:12 +00:00
Owner

Baseline

Server smoke test, 22 successful runs 06:37-08:17 on 2026-11-16 (tasks 7312, 7328, 7335, 7387, 7395, 7402, 7410, 7422, 7445, 7450, 7460, 7475, 7491, 7507, 7524, 7531, 7546, 7555, 7570, 7586, 7593, 7608): median 48.5 s, range 39-63 s. The job's own image is node:20-bookworm, and it still ran actions/setup-node@v4 with node-version: 20 - a download of Node 20 onto Node 20.

Control: the Docker build job over the same window has a 22 s median while checking out, running a static check, fetching the docker CLI and building the image, with no runtime download (tasks 7313, 7329, 7336, 7388, 7396, 7403, 7411, 7423, 7446, 7451, 7461, 7476, 7492, 7508, 7525, 7532, 7547, 7556, 7571, 7587, 7594, 7609).

Change

.forgejo/workflows/ci.yml only: drop actions/setup-node from the smoke job, print node --version && npm --version instead. The three test legs already dropped the same step (#1604, run 3122/task 6833: setup-node clone + tarball = 25 s of a 229 s leg).

After

Run 3529 on this branch (PR checks): Server smoke test 24 s (task 7616), Docker build 29 s (7617), test legs 89/81/100 s (7613-7615), Classify the change 14 s (7611). Post-merge main run: smoke 19 s (task 7624), Docker 21 s (7625), legs 93/79/90 s (7621-7623). Median smoke 48.5 s -> 24 s in the PR run and 19 s on main; roughly 24-29 s off every push to main and every non-data-only PR, with no coverage change.

Coverage unchanged

node scripts/smoke-http.js is untouched and remains the step that decides the job, on the same image, in the same job. The Node 18/20/22 support line is still held by the three-leg matrix, each leg still asserting its own runtime; the smoke job now prints its runtime so an image bump is visible rather than silent. No check skipped, weakened, or moved to a different runner.

## Baseline `Server smoke test`, 22 successful runs 06:37-08:17 on 2026-11-16 (tasks 7312, 7328, 7335, 7387, 7395, 7402, 7410, 7422, 7445, 7450, 7460, 7475, 7491, 7507, 7524, 7531, 7546, 7555, 7570, 7586, 7593, 7608): median **48.5 s**, range 39-63 s. The job's own image is node:20-bookworm, and it still ran `actions/setup-node@v4` with `node-version: 20` - a download of Node 20 onto Node 20. Control: the `Docker build` job over the same window has a **22 s** median while checking out, running a static check, fetching the docker CLI and building the image, with no runtime download (tasks 7313, 7329, 7336, 7388, 7396, 7403, 7411, 7423, 7446, 7451, 7461, 7476, 7492, 7508, 7525, 7532, 7547, 7556, 7571, 7587, 7594, 7609). ## Change `.forgejo/workflows/ci.yml` only: drop `actions/setup-node` from the `smoke` job, print `node --version && npm --version` instead. The three test legs already dropped the same step (#1604, run 3122/task 6833: setup-node clone + tarball = 25 s of a 229 s leg). ## After Run 3529 on this branch (PR checks): `Server smoke test` **24 s** (task 7616), `Docker build` 29 s (7617), test legs 89/81/100 s (7613-7615), `Classify the change` 14 s (7611). Post-merge main run: smoke **19 s** (task 7624), Docker 21 s (7625), legs 93/79/90 s (7621-7623). Median smoke 48.5 s -> 24 s in the PR run and 19 s on main; roughly 24-29 s off every push to main and every non-data-only PR, with no coverage change. ## Coverage unchanged `node scripts/smoke-http.js` is untouched and remains the step that decides the job, on the same image, in the same job. The Node 18/20/22 support line is still held by the three-leg matrix, each leg still asserting its own runtime; the smoke job now prints its runtime so an image bump is visible rather than silent. No check skipped, weakened, or moved to a different runner.
CI: the smoke job downloads Node 20 onto Node 20 (most of a 48 s job)
All checks were successful
CI / Classify the change (pull_request) Successful in 13s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 17s
CI / Server smoke test (pull_request) Successful in 22s
CI / Docker build (pull_request) Successful in 29s
CI / Test (Node 20) (pull_request) Successful in 1m21s
CI / Test (Node 18) (pull_request) Successful in 1m29s
CI / Test (Node 22) (pull_request) Successful in 1m39s
99ba31408d
The smoke job's image is already node:20-bookworm - the same Start image the
test legs run on - and it called actions/setup-node with node-version 20
anyway. Measured over the 22 successful smoke jobs between 06:37 and 08:17 on
2026-11-16 (tasks 7312-7608): median 48.5 s, range 39-63 s. The docker job,
which checks out, runs a static check, fetches the docker CLI and builds the
image, has a median of 22 s and downloads no runtime.

The three test legs already dropped this step (run 3122, task 6833: the
setup-node clone and tarball were 25 s of a 229 s leg) and keep an in-job
assertion that each leg runs the Node it is named for. The smoke job keeps the
guarantee in the weaker form that fits it: it prints node --version, so an
image bump is visible in the log, while the three-leg matrix remains the thing
that holds the Node 18/20/22 support line. The work it does is unchanged:
scripts/smoke-http.js, same script and same assertions, in the same job.
jaylouisw scheduled this pull request to auto merge when all checks succeed 2026-11-16 08:24:05 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1633
No description provided.