CI: the smoke job downloads Node 20 onto Node 20 (most of a 48 s job) #1633
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1633
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ci/1116-0820"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Baseline
Server smoke test, 22 successful runs 06:37-08:17 on 2026-11-16 (tasks 7312, 7328, 7335, 7387, 7395, 7402, 7410, 7422, 7445, 7450, 7460, 7475, 7491, 7507, 7524, 7531, 7546, 7555, 7570, 7586, 7593, 7608): median 48.5 s, range 39-63 s. The job's own image is node:20-bookworm, and it still ranactions/setup-node@v4withnode-version: 20- a download of Node 20 onto Node 20.Control: the
Docker buildjob over the same window has a 22 s median while checking out, running a static check, fetching the docker CLI and building the image, with no runtime download (tasks 7313, 7329, 7336, 7388, 7396, 7403, 7411, 7423, 7446, 7451, 7461, 7476, 7492, 7508, 7525, 7532, 7547, 7556, 7571, 7587, 7594, 7609).Change
.forgejo/workflows/ci.ymlonly: dropactions/setup-nodefrom thesmokejob, printnode --version && npm --versioninstead. The three test legs already dropped the same step (#1604, run 3122/task 6833: setup-node clone + tarball = 25 s of a 229 s leg).After
Run 3529 on this branch (PR checks):
Server smoke test24 s (task 7616),Docker build29 s (7617), test legs 89/81/100 s (7613-7615),Classify the change14 s (7611). Post-merge main run: smoke 19 s (task 7624), Docker 21 s (7625), legs 93/79/90 s (7621-7623). Median smoke 48.5 s -> 24 s in the PR run and 19 s on main; roughly 24-29 s off every push to main and every non-data-only PR, with no coverage change.Coverage unchanged
node scripts/smoke-http.jsis untouched and remains the step that decides the job, on the same image, in the same job. The Node 18/20/22 support line is still held by the three-leg matrix, each leg still asserting its own runtime; the smoke job now prints its runtime so an image bump is visible rather than silent. No check skipped, weakened, or moved to a different runner.