CI: stop installing Node 20 on Node 20, and assert every leg's runtime #1604
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1604
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ci/1116-0420"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What was slow / broken
A false red on a green tree. Run 3122 (PR #1564,
ci.yml), jobTest (Node 20)=task 6834: the leg died 22 s in, before running a single check:
Tasks 6833 (
Test (Node 18)) and 6835 (Test (Node 22)) of the same run ran theidentical suite to completion (260 suites, 0 failures) - the two other legs are green, the
third is red, and the commit cannot merge. All three legs clone
actions/setup-node@v4intothe same act cache path within 5 s of each other (04:27:07 / 04:27:09 / 04:27:12).
The same clone is also pure wall clock. Task 6833: setup-node action clone at 04:27:14,
Node tarball download at 04:27:32 - ~25 s of a 229 s job - to install Node 20 on a job image
that already is
node:20-bookworm(Start image=node:20-bookworm, first line of every log,and why the
changesjob has never had a setup step).The change
actions/setup-node(if: matrix.node != 20). It uses theimage's node, as the
changesjob always has.node --versionmatches the version on its check name. That is whatkeeps the saving honest: the repo has twice shipped legs that reported coverage they never
had (runs 1398/1401/1402), and this makes an image change fail loudly instead.
Baseline
Queue context: run 3122's classify job ran at 03:00:41 and its legs only started at 04:27 -
86 minutes in the queue, with 27
ci.ymlruns waiting at 04:30. Each leg costs ~230 s ofwhich ~25 s is now gone from one of the three.
Coverage
Unchanged. Node 18, 20 and 22 still each run the full suite, the five static checks, the
example build and the catalogue sweep; Node 20 is the only leg whose runtime now comes from
the image instead of a download, and it is asserted rather than assumed.
After
This branch's own run is subject to the documented dispatch defect (own branches do not
dispatch) and the queue is 27 runs deep; the after number will be the
Test (Node 20)leg ofthe first run that carries this change.
Still red, not mine to fix
spec-vs-descriptionfails on main and therefore on every PR run examined - 3053/3055/3059/3065/3067 all end
2 passed, 1 failed: 4 edgecore AS4610 models claim2x 20G QSFP+with noport that can do 20G. That is catalogue data, not workflows, and PR #1564 appears to carry the
fix.
9d16b4faa13c66f9e8973c66f9e8978c69dcaa61