ARCHITECTURE: the neighbours citation says 20 checks; the file runs 27 #1582

Merged
jaylouisw merged 1 commit from docs/1116-0146 into main 2026-11-16 01:59:47 +00:00
Owner

docs/ARCHITECTURE.md, the §"A reopened lab announced nothing" citation.

What was untrue: test/neighbours-on-load.test.js pins it, 20 checks; reverting engine/ fails 7.

Evidence:

  • node test/neighbours-on-load.test.js -> 27 passed, 0 failed. #1521 (7e89f959) added the reopened-board block (a reopened board knows both neighbours without announcing again, the field-for-field record, byte-identical save/load/save, the empty-record check) and grew the file from 20 to 27 checks without updating this line.
  • The failing number is stale too: reverse-applying the two engine hunks the section describes (Topology.fromJSON()'s pendingAnnouncement/hydration and the Simulator constructor's announce-on-load) gives 12 failures out of 27, not 7. Reverting only the #1521 hydration hunks fails 4, only the #1468 announce-on-load hunks fails 1, both together 12.

The neighbouring "Neighbours green" list was re-measured and is correct as written (lldp 27, show-lldp 23, lldp-across-trunk 32, link-state 69, poe 18, config-roundtrip 46, pon-splitter 33, ...), so only the two numbers in the first clause changed.

Guards: syntax-check 331 files OK; control bytes clean; docs-show-commands 7/0 (48 forms, 96 typed, 60 refusals); help-completeness 8/0; help-key-works-in-every-prompt 9/9; doc-catalog-counts 24/0; canonical-urls 52/0. Unchanged before and after (prose-only edit).

docs/ARCHITECTURE.md, the §"A reopened lab announced nothing" citation. What was untrue: `test/neighbours-on-load.test.js` pins it, **20 checks; reverting `engine/` fails 7**. Evidence: - `node test/neighbours-on-load.test.js` -> **27 passed, 0 failed**. #1521 (7e89f959) added the reopened-board block (`a reopened board knows both neighbours without announcing again`, the field-for-field record, byte-identical save/load/save, the empty-record check) and grew the file from 20 to 27 checks without updating this line. - The failing number is stale too: reverse-applying the two engine hunks the section describes (`Topology.fromJSON()`'s `pendingAnnouncement`/hydration and the `Simulator` constructor's announce-on-load) gives **12 failures out of 27**, not 7. Reverting only the #1521 hydration hunks fails 4, only the #1468 announce-on-load hunks fails 1, both together 12. The neighbouring "Neighbours green" list was re-measured and is correct as written (lldp 27, show-lldp 23, lldp-across-trunk 32, link-state 69, poe 18, config-roundtrip 46, pon-splitter 33, ...), so only the two numbers in the first clause changed. Guards: syntax-check 331 files OK; control bytes clean; docs-show-commands 7/0 (48 forms, 96 typed, 60 refusals); help-completeness 8/0; help-key-works-in-every-prompt 9/9; doc-catalog-counts 24/0; canonical-urls 52/0. Unchanged before and after (prose-only edit).
ARCHITECTURE: the neighbours citation is 27 checks, and reverting the load path fails 12 (#1521)
Some checks failed
CI / Classify the change (pull_request) Successful in 20s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 20s
CI / Docker build (pull_request) Failing after 12m10s
CI / Server smoke test (pull_request) Failing after 12m11s
CI / Test (Node 22) (pull_request) Failing after 12m15s
CI / Test (Node 20) (pull_request) Failing after 12m20s
CI / Test (Node 18) (pull_request) Failing after 12m22s
b4bf31dc59
jaylouisw deleted branch docs/1116-0146 2026-11-16 01:59:49 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1582
No description provided.