A reopened lab announced nothing #1468
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1468
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/announce-on-load"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #1467
Neighbour rows are not stored state — they are announced. The board announces when a cable is plugged (
refreshNeighbours(), the call the UI makes afteraddLink), and a load is that same event: every cable in the document is being added right now.Topology.fromJSON()marked nothing, so the simulator built on a reopened lab never announced, and every port claimed its far end had never been heard from with the cables all in place — the #1457 symptom arriving by a different road.The change
Topology.fromJSON()marks the board it built (loadedFromDocument);Simulatorconstructor announces once for such a board — PoE budgets, LLDP to the far end, router advertisements: the same three things plugging a cable does;A reopened lab now shows the same neighbour rows as before the save, port for port, with nothing plugged and no ping sent — on both ends of a cable and across a trunk carrying one VLAN.
Deliberately not invented
Evidence
test/neighbours-on-load.test.js, 20 checks. Revertingengine/fails 7.Neighbours green:
lldp27,show-lldp23,lldp-across-trunk32,flows-survive-save-load16,spec-survives-load32,dhcp-leases-survive-save32,state-payload-complete16,examples-generated21,counters-agreement32,link-state69,stp-port-state31,poe18,config-roundtrip46,pon-splitter33.Docs:
docs/ARCHITECTURE.md§ "A reopened lab announced nothing".