a bundle's members are checked against each other when the bundle is built (#1524) #1531
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1531
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1115-1848"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1524
engine/lag.jsvalidates each member's rate, duplex and VLAN set, but the one caller that builds a bundle - thechannel-grouphandler - passed nomemberPorts, so every per-member loop was skipped. A bundle of ports that cannot carry traffic the same way was accepted with a receipt and no word; the mismatch then surfaced as intermittent, half-working traffic thatshow etherchannel summaryreads as healthy, because every member is up.What changed:
CliSession._lagMemberPorts()resolves a record per member: the rate the port will run at (a forcedspeed, else the catalogue rate), its duplex, whether it is administratively up, and whetherengine/vlan.jssays it files frames the same way as the first member. The VLAN verdict is not re-derived here -framesCompatible()already owns that rule.validateLag()is called with those records, and the first warning is printed as well as the first error: a shut member carries nothing, and the moment the port joins is when the operator is looking at it.config.lagsis keyed by the number typed but the object carried none, sonormalizeLag()fell back tolag1and every message would have named a group that does not exist.E_LAG_DUPLEX_MISMATCHsorts its settings, the way the rate message already sorted: one bundle must not be described two ways depending on which member was typed first.A correct bundle stays silent - the existing
lag-modeguarantee - and that is asserted.test/lag-member-checks.test.js(8 assertions) locks mixed rates, mixed duplex, different VLAN sets, a shut member, the group number in the sentence, and silence on a healthy bundle.Gates:
node scripts/syntax-check.js321 files OK;npm test251 suites, 9201 assertions, 0 failed.Still dead, not in this change: the cable-level
E_LAG_SPEED_MISMATCHinvalidation.jsreadsdev.lags(nothing creates it) and needsiface.lagId(nothing sets it) - recorded as a follow-up rather than fixed blind.968d19456755cca52db0