lag.validateLag's per-member checks never run because no caller passes memberPorts #1524
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1524
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
engine/lag.jshas per-member speed, duplex and VLAN checks (:216-291), butengine/cli.js:4565callsvalidateLag(lag)with nomemberPorts, so those loops are skipped.Measured: a 1G port and a 10G SFP+ bundled into
lag1produce no warning at all, while the same call withmemberPortssupplied correctly returnsE_LAG_SPEED_MISMATCH.Related:
E_LAG_SPEED_MISMATCHfromvalidation.js:743readsdev.lags, which nothing creates (the CLI writesdev.config.lags), and it needsiface.lagIdon both ends, whichchannel-groupnever sets - so that path cannot fire either.Why it matters: a bundle of mismatched members is a real misconfiguration that produces intermittent, confusing failure, and the engine has the check but no one calls it.
Suggested fix: pass the resolved member list from the
channel-grouphandler, and make one of the two LAG-speed paths real rather than two of them dead.