The sweeper only looked for the model code at the end of the title #1129
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1129
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/sweeper-midtitle-codes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
[Device]: Teltonika RUT241 Industrial 4G LTE Wi-Fi Router— RUT241 is in the middle of the title, and RUT241 is in the catalogue.The matcher tried the whole subject, the subject with brackets removed, and then trailing suffixes of it. A code in the middle was never a candidate, so the request stayed open while the device was modelled. It is the same defect as the bracketed-code case in #1126, in the other position.
Fix
Every token with a digit and at least three characters is now tried as its own candidate. Two characters is not enough —
48 Port Switchis a port count, not a model — and the catalogue lookup still has to find an exact match, so a stray word cannot invent a hit.Measured on the live backlog
Five checks added, including that a repeated code is tried once and that a two-character token is not treated as a model code.