The sweeper only looked for the model code at the end of the title #1129

Merged
jaylouisw merged 1 commit from fix/sweeper-midtitle-codes into main 2026-11-08 20:55:17 +00:00
Owner

[Device]: Teltonika RUT241 Industrial 4G LTE Wi-Fi Router — RUT241 is in the middle of the title, and RUT241 is in the catalogue.

The matcher tried the whole subject, the subject with brackets removed, and then trailing suffixes of it. A code in the middle was never a candidate, so the request stayed open while the device was modelled. It is the same defect as the bracketed-code case in #1126, in the other position.

Fix

Every token with a digit and at least three characters is now tried as its own candidate. Two characters is not enough — 48 Port Switch is a port count, not a model — and the catalogue lookup still has to find an exact match, so a stray word cannot invent a hit.

Measured on the live backlog

  • 574 open requests
  • 29 satisfied by the catalogue, and every one is genuine: RB750Gr3, RUT241, RUT906, RUT956, RUTM50, AF-2X/3X/4X/5XHD, EP-R6/R8, ES-8-150W, Mimosa A5c/B24/B5c/C5c, Ruckus R650

Five checks added, including that a repeated code is tried once and that a two-character token is not treated as a model code.

`[Device]: Teltonika RUT241 Industrial 4G LTE Wi-Fi Router` — RUT241 is **in the middle** of the title, and RUT241 is in the catalogue. The matcher tried the whole subject, the subject with brackets removed, and then trailing suffixes of it. A code in the middle was never a candidate, so the request stayed open while the device was modelled. It is the same defect as the bracketed-code case in #1126, in the other position. ### Fix Every token with a digit and at least three characters is now tried as its own candidate. Two characters is not enough — `48 Port Switch` is a port count, not a model — and the catalogue lookup still has to find an exact match, so a stray word cannot invent a hit. ### Measured on the live backlog - 574 open requests - **29 satisfied by the catalogue**, and every one is genuine: RB750Gr3, RUT241, RUT906, RUT956, RUTM50, AF-2X/3X/4X/5XHD, EP-R6/R8, ES-8-150W, Mimosa A5c/B24/B5c/C5c, Ruckus R650 Five checks added, including that a repeated code is tried once and that a two-character token is not treated as a model code.
The sweeper only looked for the model code at the end of the title
Some checks failed
CI / Test (Node 20) (pull_request) Successful in 1m45s
CI / Test (Node 18) (pull_request) Successful in 1m51s
CI / Server smoke test (pull_request) Successful in 33s
CI / Docker build (pull_request) Successful in 37s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Failing after 17s
CI / Test (Node 22) (pull_request) Successful in 1m33s
d7d2d14a83
"Teltonika RUT241 Industrial 4G LTE Wi-Fi Router" - RUT241 is in the middle, and RUT241 is
in the catalogue. The matcher tried the whole subject, the subject with brackets removed,
and then trailing suffixes of it; a code in the middle was never a candidate, so the
request stayed open while the device was modelled.

Same defect as the bracketed-code case fixed in #1126, in the other position. Now every
token with a digit and at least three characters is tried as its own candidate. Two
characters is not enough - "48 Port Switch" is a port count, not a model - and the
catalogue lookup still has to find an exact match, so a stray word cannot invent a hit.

Measured on the live backlog: 574 open requests, 29 satisfied by the catalogue, and the
new ones are all genuine (RB750Gr3, RUT241, RUT906, RUT956, RUTM50, AF-2X/3X/4X/5XHD,
EP-R6/R8, ES-8-150W, Mimosa A5c/B24/B5c/C5c, Ruckus R650).

Five checks added, including that a repeated code is tried once and that a two-character
token is not treated as a model code.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1129
No description provided.