The sweeper ignored the model code in brackets, so satisfied requests read as open #1126
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1126
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/sweeper-bracketed-codes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
[Device]: Ubiquiti UniFi Switch Pro XG 24 (USW-Pro-XG-24)— the catalogue is keyed on USW-Pro-XG-24. Neither the title as written nor the title with the parenthetical removed normalises to anything in the catalogue, so the request read as open. It was one of 139 Ubiquiti requests in that state.The queue looked like work when it was a backlog of answers nobody had sent.
What changed
The matcher now tries the contents of every parenthetical as its own candidate, splitting on commas and slashes so
(AAA-1, BBB-2)yields both. The subject as written is still tried first, the bracket-free form is still the fallback, and the guards that stop a shared word like "Ultra" matching the wrong vendor are untouched.Extracted into
requestCandidates()and exported, so the rule is tested directly rather than by grepping the script: bracketed code, bracket-free title, subject as written, comma-separated codes, empty input, and no duplicate candidate when the code is the whole title.Measured on the live backlog
That last number is the real queue, and it is what I am working down next — the first batch of devices from it is in #1127.