The sweeper ignored the model code in brackets, so satisfied requests read as open #1126

Merged
jaylouisw merged 1 commit from fix/sweeper-bracketed-codes into main 2026-11-08 20:42:25 +00:00
Owner

[Device]: Ubiquiti UniFi Switch Pro XG 24 (USW-Pro-XG-24) — the catalogue is keyed on USW-Pro-XG-24. Neither the title as written nor the title with the parenthetical removed normalises to anything in the catalogue, so the request read as open. It was one of 139 Ubiquiti requests in that state.

The queue looked like work when it was a backlog of answers nobody had sent.

What changed

The matcher now tries the contents of every parenthetical as its own candidate, splitting on commas and slashes so (AAA-1, BBB-2) yields both. The subject as written is still tried first, the bracket-free form is still the fallback, and the guards that stop a shared word like "Ultra" matching the wrong vendor are untouched.

Extracted into requestCandidates() and exported, so the rule is tested directly rather than by grepping the script: bracketed code, bracket-free title, subject as written, comma-separated codes, empty input, and no duplicate candidate when the code is the whole title.

Measured on the live backlog

  • open device requests: 595
  • already satisfied by the catalogue: 10
  • genuinely missing hardware: 585

That last number is the real queue, and it is what I am working down next — the first batch of devices from it is in #1127.

`[Device]: Ubiquiti UniFi Switch Pro XG 24 (USW-Pro-XG-24)` — the catalogue is keyed on **USW-Pro-XG-24**. Neither the title as written nor the title with the parenthetical removed normalises to anything in the catalogue, so the request read as open. It was one of **139 Ubiquiti requests** in that state. The queue looked like work when it was a backlog of answers nobody had sent. ### What changed The matcher now tries the contents of every parenthetical as its own candidate, splitting on commas and slashes so `(AAA-1, BBB-2)` yields both. The subject as written is still tried first, the bracket-free form is still the fallback, and the guards that stop a shared word like "Ultra" matching the wrong vendor are untouched. Extracted into `requestCandidates()` and exported, so the rule is tested directly rather than by grepping the script: bracketed code, bracket-free title, subject as written, comma-separated codes, empty input, and no duplicate candidate when the code is the whole title. ### Measured on the live backlog - open device requests: **595** - already satisfied by the catalogue: **10** - **genuinely missing hardware: 585** That last number is the real queue, and it is what I am working down next — the first batch of devices from it is in #1127.
The sweeper ignored the model code in brackets, so satisfied requests read as open
Some checks failed
CI / Test (Node 18) (pull_request) Failing after 37s
CI / Test (Node 20) (pull_request) Successful in 2m4s
CI / Test (Node 22) (pull_request) Successful in 1m43s
CI / Server smoke test (pull_request) Successful in 28s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Failing after 20s
CI / Docker build (pull_request) Successful in 45s
58d272b440
"Ubiquiti UniFi Switch Pro XG 24 (USW-Pro-XG-24)". The catalogue is keyed on
USW-Pro-XG-24. Neither the title as written nor the title with the parenthetical
removed normalises to anything in the catalogue, so the request read as open — and
it was one of 139 Ubiquiti requests in that state. The queue looked like work when it
was a backlog of answers nobody had sent.

The matcher now tries the contents of every parenthetical as its own candidate,
splitting on commas and slashes so "(AAA-1, BBB-2)" yields both. The subject as
written is still tried first; the bracket-free form is still the fallback; and the
guards that stop a shared word like "Ultra" matching the wrong vendor are untouched.

Extracted into `requestCandidates()` and exported, so the rule is tested directly
rather than by grepping the script: bracketed code, bracket-free title, subject as
written, comma-separated codes, empty input, and no duplicate candidate when the
code is the whole title.

Found while working through the backlog: of 595 open requests, 10 were satisfied and
585 are genuinely missing hardware.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1126
No description provided.