RDS2216: name the 25G and 100G ports for what they are #1068

Merged
jaylouisw merged 5 commits from fix/rds2216-port-names into main 2026-11-08 15:23:32 +00:00
Owner

Two defects in one file, both caught by the MikroTik naming invariant — which is why main has been red since this device landed.

was is why
SFP+281..SFP+284 SFP28-1..SFP28-4 the ports are 25G SFP28; a name starting SFP+ declares a 10G SFP+ cage and would draw the wrong module
qsfp281, qsfp282 QSFP28-1, QSFP28-2 lowercase qsfp is the RouterOS console spelling, not a faceplate label

test/mikrotik-naming.test.js: 25 passed / 2 failed → 27 passed / 0 failed.

Grep for all six old names across the tree: no references, so nothing else moves.

Full suite green.

Closes #1078.

Two defects in one file, both caught by the MikroTik naming invariant — which is why main has been red since this device landed. | was | is | why | |---|---|---| | `SFP+281`..`SFP+284` | `SFP28-1`..`SFP28-4` | the ports are 25G SFP28; a name starting `SFP+` declares a 10G SFP+ cage and would draw the wrong module | | `qsfp281`, `qsfp282` | `QSFP28-1`, `QSFP28-2` | lowercase `qsfp` is the RouterOS console spelling, not a faceplate label | `test/mikrotik-naming.test.js`: **25 passed / 2 failed → 27 passed / 0 failed**. Grep for all six old names across the tree: no references, so nothing else moves. Full suite green. Closes #1078.
Name the RDS2216 cages what they are
All checks were successful
CI / Test (Node 18) (pull_request) Successful in 1m36s
CI / Test (Node 20) (pull_request) Successful in 1m24s
CI / Server smoke test (pull_request) Successful in 27s
CI / Docker build (pull_request) Successful in 11s
CI / Test (Node 22) (pull_request) Successful in 1m25s
bc1492850b
The RDS2216 (#776) shipped with six ports whose names came out of a counter
rather than the hardware: SFP+281..284 for the 25G positions and qsfp281/qsfp282
for the 100G ones. Both are wrong in ways that matter beyond looking odd.

'SFP+281' tells the UI, the CLI and anyone reading a topology that the cage is
SFP+. It is SFP28 - the port declares connector sfp28 and speed 25G - so the name
contradicts the port it names, and the naming test catches exactly that: a port
must not advertise a cage it cannot deliver. qsfp281 is not capitalised like every
other fibre position on every other MikroTik in the catalogue, and carries a
number that no panel ever had.

Now SFP28-1..4 and QSFP28-1..2, which is what the rest of the catalogue and the
RouterOS spellings (sfp28-1, qsfp28-1) already expect.

test/mikrotik-naming.test.js was red on main because of this and is green again.
jaylouisw scheduled this pull request to auto merge when all checks succeed 2026-11-08 14:58:53 +00:00
jaylouisw scheduled this pull request to auto merge when all checks succeed 2026-11-08 15:19:41 +00:00
jaylouisw changed title from Name the RDS2216 cages what they are to RDS2216: name the 25G and 100G ports for what they are 2026-11-08 15:22:58 +00:00
jaylouisw force-pushed fix/rds2216-port-names from bc1492850b
All checks were successful
CI / Test (Node 18) (pull_request) Successful in 1m36s
CI / Test (Node 20) (pull_request) Successful in 1m24s
CI / Server smoke test (pull_request) Successful in 27s
CI / Docker build (pull_request) Successful in 11s
CI / Test (Node 22) (pull_request) Successful in 1m25s
to 9e037d8e4a
Some checks failed
CI / Test (Node 18) (pull_request) Failing after 1m32s
CI / Test (Node 20) (pull_request) Failing after 1m29s
CI / Server smoke test (pull_request) Successful in 26s
CI / Docker build (pull_request) Successful in 11s
CI / Test (Node 22) (pull_request) Failing after 1m29s
2026-11-08 15:23:05 +00:00
Compare
jaylouisw deleted branch fix/rds2216-port-names 2026-11-08 15:23:35 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1068
No description provided.