RDS2216 port names promise cages the hardware cannot deliver #1078

Closed
opened 2026-11-08 15:22:52 +00:00 by jaylouisw · 0 comments
Owner

devices/mikrotik/rds2216-2xg-4s-4xs-2xq.json names its 25G ports SFP+281..SFP+284 and its 100G ports qsfp281, qsfp282.

test/mikrotik-naming.test.js fails on main because of it:

x ethN is lowercase and fibre positions are capitalised (RDS2216-2XG-4S+4XS-2XQ/qsfp281, RDS2216-2XG-4S+4XS-2XQ/qsfp282)
x no port advertises a cage it cannot deliver (RDS2216-2XG-4S+4XS-2XQ/SFP+281 -> sfp28 (not sfp+), ...)

The ports are 25G SFP28 and 100G QSFP28. A name starting SFP+ declares an SFP+ cage, so those four ports advertise a 10G cage they cannot deliver and the engine would draw the wrong module into them. The lowercase qsfp names are the RouterOS console form, which this catalogue does not put on a faceplate.

Acceptance:

  • The 25G ports are named SFP28-1..SFP28-4 and the 100G ports QSFP28-1, QSFP28-2.
  • test/mikrotik-naming.test.js passes with no new exemptions.
  • No stale references to the old names anywhere in the tree.
`devices/mikrotik/rds2216-2xg-4s-4xs-2xq.json` names its 25G ports `SFP+281`..`SFP+284` and its 100G ports `qsfp281`, `qsfp282`. `test/mikrotik-naming.test.js` fails on main because of it: ``` x ethN is lowercase and fibre positions are capitalised (RDS2216-2XG-4S+4XS-2XQ/qsfp281, RDS2216-2XG-4S+4XS-2XQ/qsfp282) x no port advertises a cage it cannot deliver (RDS2216-2XG-4S+4XS-2XQ/SFP+281 -> sfp28 (not sfp+), ...) ``` The ports are 25G **SFP28** and 100G **QSFP28**. A name starting `SFP+` declares an SFP+ cage, so those four ports advertise a 10G cage they cannot deliver and the engine would draw the wrong module into them. The lowercase `qsfp` names are the RouterOS console form, which this catalogue does not put on a faceplate. Acceptance: - The 25G ports are named `SFP28-1`..`SFP28-4` and the 100G ports `QSFP28-1`, `QSFP28-2`. - `test/mikrotik-naming.test.js` passes with no new exemptions. - No stale references to the old names anywhere in the tree.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge#1078
No description provided.