ci(auto-rebase): do not mint a head nothing will check #2059
No reviewers
Labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!2059
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ci/1119-0044"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What is broken
Every
auto-rebasepass force-pushes the branches that are behindmain. The head it mints often gets no CI run at all, and a head with no checks can never be armed (checks_greenneeds threeCI / Test (Node *)statuses; the merge POST needs every status on the head to have reported).Evidence,
/api/v1/repos/jaylouisw/packetforge/actions/taskskeyed byhead_sha:816c1f381169554dbf3f22206320501e9df7b89bThose five only merged after a human pushed or closed-and-reopened them, and each merge repeated the freeze on the rest of the queue (see the #2033 timeline).
Reproduced on this PR while it was open:
auto-rebasepushed2a3f751c -> a9384edf -> 237fc3cc, and/commits/<sha>/statusansweredtotal_count: 0for both new heads.What does not fix it
workflow_dispatchof ci.yml. Run 6872 dispatched ci.yml againsta9384edf: Classify, all three test legs, smoke and Docker ran and passed - and/commits/a9384edf/statusstill returnedtotal_count: 0. The jobs run; the statuses the gate reads are not written. (First commit on this branch tried that; it is disproven and superseded.)The change
A push made with a user token does raise the event: pushing
237fc3cc..4e94088dto this PR with the repository token produced eight statuses on the new head inside 25 s.So the pass now tells which credential it holds (
RUN_TOKEN: ${{ github.token }}):FORGEJO_TOKEN): behaviour unchanged - rebase, push, then verify the new head actually has checks and count the ones that do not (no_checks=);block_on_outdated_branch: falseonmain, read from/branch_protections), while a head nothing checks cannot merge at all. The pass says so once, and the re-arming pass still runs.Coverage unchanged: same classifier, same three Node legs, same smoke and Docker jobs, same
checks_greengate. Nothing is skipped, retried or weakened - the change only stops the workflow destroying a state (green checks) it cannot recreate.Checks
node test/ci-disk-hygiene.test.js12/12 pass (thedf -Pkguard and theuses: actions/checkout@it pins are untouched).2a3f751cc3a9384edf7da9384edf7dto237fc3cc84ci(auto-rebase): dispatch CI for a head this pass force-pushed and nothing else checkedto ci(auto-rebase): do not mint a head nothing will check