docs(changelog): the LLDP count test pins 16 checks and two spellings, not 17 and three #2019

Merged
jaylouisw merged 1 commit from docs/1118-1848 into main 2026-11-18 21:18:54 +00:00
Owner

The Unreleased LLDP entry (docs/CHANGELOG.md) says test/lldp-total-entries.test.js "pins 17 checks ... and all three accepted spellings agreeing".

Evidence from the code: #1915 (6728c3f9) made show lldp the status view and removed it from the test's spelling loop:

-  ['show lldp', 'show lldp neighbors', 'show lldp neighbours'].forEach(function (cmd) {
+  ['show lldp neighbors', 'show lldp neighbours'].forEach(function (cmd) {

One ok() call inside that loop means one fewer runtime check, so the suite prints 16 passed, 0 failed today (the file holds 15 ok( calls, one of them in a two-iteration forEach). The claim was correct at 7db29753, where the loop ran three spellings.

Fix: the count reads 16, the coverage names the two spellings the console accepts (show lldp neighbors, show lldp neighbours), and the entry records why the third is gone. Docs-only; no engine or test change.

Guards: syntax-check 421 files OK; doc-catalog-counts 43; docs-show-commands 7 passed (59 forms / 118 commands / 74 refusals); docs-cli-transcript 4; help-completeness 8 (102 advertised commands, 19 mechanisms, 16 show); doc-citations 11; check-control-bytes clean.

The Unreleased LLDP entry (`docs/CHANGELOG.md`) says `test/lldp-total-entries.test.js` "pins 17 checks ... and all three accepted spellings agreeing". **Evidence from the code:** #1915 (6728c3f9) made `show lldp` the status view and removed it from the test's spelling loop: ``` - ['show lldp', 'show lldp neighbors', 'show lldp neighbours'].forEach(function (cmd) { + ['show lldp neighbors', 'show lldp neighbours'].forEach(function (cmd) { ``` One `ok()` call inside that loop means one fewer runtime check, so the suite prints **16 passed, 0 failed** today (the file holds 15 `ok(` calls, one of them in a two-iteration `forEach`). The claim was correct at 7db29753, where the loop ran three spellings. Fix: the count reads 16, the coverage names the two spellings the console accepts (`show lldp neighbors`, `show lldp neighbours`), and the entry records why the third is gone. Docs-only; no engine or test change. Guards: syntax-check 421 files OK; doc-catalog-counts 43; docs-show-commands 7 passed (59 forms / 118 commands / 74 refusals); docs-cli-transcript 4; help-completeness 8 (102 advertised commands, 19 mechanisms, 16 show); doc-citations 11; check-control-bytes clean.
docs(changelog): the LLDP count test pins 16 checks and two spellings, not 17 and three
All checks were successful
CI / Classify the change (pull_request) Successful in 5s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 10s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 20) (pull_request) Successful in 47s
CI / Test (Node 18) (pull_request) Successful in 54s
CI / Test (Node 22) (pull_request) Successful in 49s
CI / Arm auto-merge (pull_request) Successful in 19s
6c58d9b8b3
`test/lldp-total-entries.test.js` dropped `show lldp` from its spelling loop when
that word became the status view (#1915), so the suite prints 16 checks, not 17, and
the neighbour table now has two accepted spellings - `show lldp neighbors` and
`show lldp neighbours` - rather than three. The Unreleased entry still claimed the
old count and the old coverage.

Verified: node test/lldp-total-entries.test.js -> 16 passed, 0 failed; the 15 ok()
calls in the file, one of them inside a two-spelling forEach.
forgejo-actions force-pushed docs/1118-1848 from 6c58d9b8b3
All checks were successful
CI / Classify the change (pull_request) Successful in 5s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 10s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 20) (pull_request) Successful in 47s
CI / Test (Node 18) (pull_request) Successful in 54s
CI / Test (Node 22) (pull_request) Successful in 49s
CI / Arm auto-merge (pull_request) Successful in 19s
to a1721c818b 2026-11-18 19:00:12 +00:00
Compare
forgejo-actions force-pushed docs/1118-1848 from 2f746a4f38 to 57a3862112
All checks were successful
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 8s
CI / Server smoke test (pull_request) Successful in 8s
CI / Test (Node 20) (pull_request) Successful in 51s
CI / Docker build (pull_request) Successful in 19s
CI / Test (Node 22) (pull_request) Successful in 55s
CI / Test (Node 18) (pull_request) Successful in 57s
CI / Arm auto-merge (pull_request) Successful in 20s
2026-11-18 20:08:53 +00:00
Compare
Author
Owner

Same zero-CI picture as #2020.

  • Head was 2f746a4f at survey time; auto-rebase pushed 57a38621 at 20:08:53Z (behind=0, ahead=1).
  • /commits/57a38621/status → total_count: 0, empty state. No run was created, so this is not red — it is unbuilt.
  • Older pull_request runs for this title exist (6983, 6984, both success), i.e. the workflow does fire for docs/1118-1848; the post-rebase SHA got nothing.

Because the rebase keeps producing a new head with no status, this PR cannot satisfy the "green head SHA" merge rule. Needs -ci/Jay: run queueing after an auto-rebase push. I have not rebased or merged it.

Same zero-CI picture as #2020. - Head was `2f746a4f` at survey time; auto-rebase pushed **`57a38621`** at 20:08:53Z (behind=0, ahead=1). - `/commits/57a38621/status` → `total_count: 0`, empty `state`. No run was created, so this is not red — it is unbuilt. - Older `pull_request` runs for this title exist (6983, 6984, both `success`), i.e. the workflow does fire for `docs/1118-1848`; the post-rebase SHA got nothing. Because the rebase keeps producing a new head with no status, this PR cannot satisfy the "green head SHA" merge rule. **Needs `-ci`/Jay: run queueing after an auto-rebase push.** I have not rebased or merged it.
forgejo-actions force-pushed docs/1118-1848 from 57a3862112
All checks were successful
CI / Classify the change (pull_request) Successful in 8s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 8s
CI / Server smoke test (pull_request) Successful in 8s
CI / Test (Node 20) (pull_request) Successful in 51s
CI / Docker build (pull_request) Successful in 19s
CI / Test (Node 22) (pull_request) Successful in 55s
CI / Test (Node 18) (pull_request) Successful in 57s
CI / Arm auto-merge (pull_request) Successful in 20s
to ed1ef529ca 2026-11-18 20:38:54 +00:00
Compare
Author
Owner

Diagnosis corrected, and the stall is now covered by a run.

Close+reopen of this PR produced two pull_request runs on the then-head 57a38621 (7053 waiting, 7054 success). The auto-rebase workflow then rebased the branch again onto c6053d2e (head now ed1ef529) and that rebase minted a head with no run at all — same shape as 6ac7e85f.

Evidence that the rebase push, not the PR, is the missing piece: the runs 7053/7054 exist only because of the reopened event, and every SHA minted by a push from the auto-rebase workflow (57a38621 at 20:08:53Z, ed1ef529 at 20:39:14Z) has zero runs. A push made with an action token does not re-trigger ci.yml in this Forgejo version.

Worked around for this PR: workflow_dispatch of ci.yml at ref docs/1118-1848 → run 7058, against ed1ef529. The PR stays armed for auto-merge; it should land when 7058 is green.

Systemic fix is a decision, not mine: either auto-rebase.yml pushes with a PAT so its push is a real synchronize, or the rebase step follows its push with a workflow_dispatch on the PR branch. Both are edits under .forgejo/workflows/, which I do not touch. needs Jay's decision.

Diagnosis corrected, and the stall is now covered by a run. Close+reopen of this PR produced two `pull_request` runs on the then-head 57a38621 (7053 waiting, 7054 success). The auto-rebase workflow then rebased the branch again onto c6053d2e (head now **ed1ef529**) and that rebase minted a head with **no** run at all — same shape as 6ac7e85f. Evidence that the rebase push, not the PR, is the missing piece: the runs 7053/7054 exist only because of the `reopened` event, and every SHA minted by a push from the auto-rebase workflow (57a38621 at 20:08:53Z, ed1ef529 at 20:39:14Z) has zero runs. A push made with an action token does not re-trigger `ci.yml` in this Forgejo version. Worked around for this PR: `workflow_dispatch` of `ci.yml` at ref `docs/1118-1848` → run **7058**, against ed1ef529. The PR stays armed for auto-merge; it should land when 7058 is green. Systemic fix is a decision, not mine: either `auto-rebase.yml` pushes with a PAT so its push is a real `synchronize`, or the rebase step follows its push with a `workflow_dispatch` on the PR branch. Both are edits under `.forgejo/workflows/`, which I do not touch. **needs Jay's decision.**
forgejo-actions force-pushed docs/1118-1848 from d95404353c to 03b95e1fc9
All checks were successful
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 5s
CI / Classify the change (pull_request) Successful in 6s
CI / Server smoke test (pull_request) Has been skipped
CI / Docker build (pull_request) Has been skipped
CI / Test (Node 20) (pull_request) Successful in 51s
CI / Test (Node 22) (pull_request) Successful in 57s
CI / Test (Node 18) (pull_request) Successful in 1m1s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-18 21:12:22 +00:00
Compare
jaylouisw deleted branch docs/1118-1848 2026-11-18 21:18:56 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2019
No description provided.