docs(changelog): the LLDP count test pins 16 checks and two spellings, not 17 and three #2019
No reviewers
Labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!2019
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "docs/1118-1848"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The Unreleased LLDP entry (
docs/CHANGELOG.md) saystest/lldp-total-entries.test.js"pins 17 checks ... and all three accepted spellings agreeing".Evidence from the code: #1915 (
6728c3f9) madeshow lldpthe status view and removed it from the test's spelling loop:One
ok()call inside that loop means one fewer runtime check, so the suite prints 16 passed, 0 failed today (the file holds 15ok(calls, one of them in a two-iterationforEach). The claim was correct at7db29753, where the loop ran three spellings.Fix: the count reads 16, the coverage names the two spellings the console accepts (
show lldp neighbors,show lldp neighbours), and the entry records why the third is gone. Docs-only; no engine or test change.Guards: syntax-check 421 files OK; doc-catalog-counts 43; docs-show-commands 7 passed (59 forms / 118 commands / 74 refusals); docs-cli-transcript 4; help-completeness 8 (102 advertised commands, 19 mechanisms, 16 show); doc-citations 11; check-control-bytes clean.
6c58d9b8b3a1721c818ba1721c818bto2f746a4f382f746a4f38to57a3862112Same zero-CI picture as #2020.
2f746a4fat survey time; auto-rebase pushed57a38621at 20:08:53Z (behind=0, ahead=1)./commits/57a38621/status→total_count: 0, emptystate. No run was created, so this is not red — it is unbuilt.pull_requestruns for this title exist (6983, 6984, bothsuccess), i.e. the workflow does fire fordocs/1118-1848; the post-rebase SHA got nothing.Because the rebase keeps producing a new head with no status, this PR cannot satisfy the "green head SHA" merge rule. Needs
-ci/Jay: run queueing after an auto-rebase push. I have not rebased or merged it.57a3862112ed1ef529caDiagnosis corrected, and the stall is now covered by a run.
Close+reopen of this PR produced two
pull_requestruns on the then-head57a38621(7053 waiting, 7054 success). The auto-rebase workflow then rebased the branch again ontoc6053d2e(head nowed1ef529) and that rebase minted a head with no run at all — same shape as6ac7e85f.Evidence that the rebase push, not the PR, is the missing piece: the runs 7053/7054 exist only because of the
reopenedevent, and every SHA minted by a push from the auto-rebase workflow (57a38621at 20:08:53Z,ed1ef529at 20:39:14Z) has zero runs. A push made with an action token does not re-triggerci.ymlin this Forgejo version.Worked around for this PR:
workflow_dispatchofci.ymlat refdocs/1118-1848→ run 7058, againsted1ef529. The PR stays armed for auto-merge; it should land when 7058 is green.Systemic fix is a decision, not mine: either
auto-rebase.ymlpushes with a PAT so its push is a realsynchronize, or the rebase step follows its push with aworkflow_dispatchon the PR branch. Both are edits under.forgejo/workflows/, which I do not touch. needs Jay's decision.ed1ef529catod95404353cd95404353cto03b95e1fc9