registry: the open-request table counted a closed issue as an open one (#743) #1916

Merged
jaylouisw merged 1 commit from fix/1117-2306 into main 2026-11-17 23:30:51 +00:00
Owner

Refs #743.

What was wrong

PR #1902 landed devices/huawei/oceanprotect-x8100.json and -x9100.json (the management plane, with the front-end census deliberately unmodelled and named in each spec's notes), and its closing reference closed the request at 2026-11-17 22:05 UTC - which is the order the issue's own last comment asked for.

The row stayed in research/open-device-requests.json, so two records went on lying:

  • docs/DEVICE_REGISTRY.md said "Seven hardware requests are open and cannot be modelled yet" and listed a closed issue as one of them, in the section that issue threads cite as the queue's record.
  • scripts/check-closed-issues.js printed a contradiction for it on every merge ("closed against our own record"), and the message said no spec exists about two files that are in devices/.

Nothing mechanical joined the two files: the ledger is keyed on the issue number, the catalogue on the model, and the only comparison was a human reading both.

What changed

  • research/open-device-requests.json: the X8100/X9100 row is out (six requests left). The E8000 row keeps the shared missing field and now says where the X8100/X9100 gap is recorded instead of pointing at a closed request.
  • docs/DEVICE_REGISTRY.md: regenerated with npm run regen:registry-doc - "Six hardware requests are open", minus that row, nothing else touched.
  • test/closed-issues-audit.test.js: the join that was missing. Every ledger row's model list is split on the slash and compared, case- and punctuation-insensitively, against each spec's model and aliases; a row naming hardware devices/ already holds fails the test. On the pre-fix tree it fails with #743 -> oceanprotect-x9100.

Gates

  • node scripts/syntax-check.js - 400 files, all OK.
  • node test/closed-issues-audit.test.js - 34 passed, 0 failed (32/2 before the fix).
  • node test/doc-catalog-counts.test.js - 43 passed.
  • Full npm test - 327 suites, 11,393 assertions, 0 failed, exit 0.
Refs #743. ## What was wrong PR #1902 landed `devices/huawei/oceanprotect-x8100.json` and `-x9100.json` (the management plane, with the front-end census deliberately unmodelled and named in each spec's notes), and its closing reference closed the request at 2026-11-17 22:05 UTC - which is the order the issue's own last comment asked for. The row stayed in `research/open-device-requests.json`, so two records went on lying: - `docs/DEVICE_REGISTRY.md` said "Seven hardware requests are open and cannot be modelled yet" and listed a closed issue as one of them, in the section that issue threads cite as the queue's record. - `scripts/check-closed-issues.js` printed a contradiction for it on every merge ("closed against our own record"), and the message said `no spec exists` about two files that are in `devices/`. Nothing mechanical joined the two files: the ledger is keyed on the issue number, the catalogue on the model, and the only comparison was a human reading both. ## What changed - `research/open-device-requests.json`: the X8100/X9100 row is out (six requests left). The E8000 row keeps the shared missing field and now says where the X8100/X9100 gap is recorded instead of pointing at a closed request. - `docs/DEVICE_REGISTRY.md`: regenerated with `npm run regen:registry-doc` - "Six hardware requests are open", minus that row, nothing else touched. - `test/closed-issues-audit.test.js`: the join that was missing. Every ledger row's model list is split on the slash and compared, case- and punctuation-insensitively, against each spec's `model` and `aliases`; a row naming hardware `devices/` already holds fails the test. On the pre-fix tree it fails with `#743 -> oceanprotect-x9100`. ## Gates - `node scripts/syntax-check.js` - 400 files, all OK. - `node test/closed-issues-audit.test.js` - 34 passed, 0 failed (32/2 before the fix). - `node test/doc-catalog-counts.test.js` - 43 passed. - Full `npm test` - 327 suites, 11,393 assertions, 0 failed, exit 0.
registry: the open-request table counted a closed issue as an open one (#743)
All checks were successful
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 17s
CI / Server smoke test (pull_request) Successful in 9s
CI / Docker build (pull_request) Successful in 23s
CI / Test (Node 20) (pull_request) Successful in 49s
CI / Test (Node 22) (pull_request) Successful in 53s
CI / Test (Node 18) (pull_request) Successful in 57s
CI / Arm auto-merge (pull_request) Successful in 8s
4a8729903c
Refs #743. PR #1902 landed devices/huawei/oceanprotect-x8100.json and -x9100.json
(management plane, front end unmodelled and named in each spec's notes) and its
closing reference closed the issue at 22:05 UTC on 2026-11-17. The row stayed in
research/open-device-requests.json, so docs/DEVICE_REGISTRY.md went on saying
'Seven hardware requests are open' with a closed issue as one of the seven, and
scripts/check-closed-issues.js printed a contradiction for it on every merge.

The E8000 row keeps the shared missing field and now says where the X8100/X9100
gap is recorded instead of pointing at the closed request.

The test is the join that was missing: it compares every ledger row's model list
(split on the slash, against model and aliases) with the catalogue and fails on a
row naming hardware devices/ already holds.
jaylouisw force-pushed fix/1117-2306 from 4a8729903c
All checks were successful
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 17s
CI / Server smoke test (pull_request) Successful in 9s
CI / Docker build (pull_request) Successful in 23s
CI / Test (Node 20) (pull_request) Successful in 49s
CI / Test (Node 22) (pull_request) Successful in 53s
CI / Test (Node 18) (pull_request) Successful in 57s
CI / Arm auto-merge (pull_request) Successful in 8s
to 49d404a7b0
All checks were successful
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 9s
CI / Server smoke test (pull_request) Successful in 9s
CI / Docker build (pull_request) Successful in 25s
CI / Test (Node 20) (pull_request) Successful in 49s
CI / Test (Node 18) (pull_request) Successful in 56s
CI / Test (Node 22) (pull_request) Successful in 53s
CI / Arm auto-merge (pull_request) Successful in 16s
2026-11-17 23:28:51 +00:00
Compare
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1916
No description provided.