ARCHITECTURE: the neighbours citation says 20 checks; the file runs 27 #1582
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1582
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "docs/1116-0146"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
docs/ARCHITECTURE.md, the §"A reopened lab announced nothing" citation.
What was untrue:
test/neighbours-on-load.test.jspins it, 20 checks; revertingengine/fails 7.Evidence:
node test/neighbours-on-load.test.js-> 27 passed, 0 failed. #1521 (7e89f959) added the reopened-board block (a reopened board knows both neighbours without announcing again, the field-for-field record, byte-identical save/load/save, the empty-record check) and grew the file from 20 to 27 checks without updating this line.Topology.fromJSON()'spendingAnnouncement/hydration and theSimulatorconstructor's announce-on-load) gives 12 failures out of 27, not 7. Reverting only the #1521 hydration hunks fails 4, only the #1468 announce-on-load hunks fails 1, both together 12.The neighbouring "Neighbours green" list was re-measured and is correct as written (lldp 27, show-lldp 23, lldp-across-trunk 32, link-state 69, poe 18, config-roundtrip 46, pon-splitter 33, ...), so only the two numbers in the first clause changed.
Guards: syntax-check 331 files OK; control bytes clean; docs-show-commands 7/0 (48 forms, 96 typed, 60 refusals); help-completeness 8/0; help-key-works-in-every-prompt 9/9; doc-catalog-counts 24/0; canonical-urls 52/0. Unchanged before and after (prose-only edit).