docs(cli): a trunk pruned to nothing is committed, not refused (#2420 follow-up) #2429

Merged
jaylouisw merged 1 commit from docs/1121-1347 into main 2026-11-21 14:39:15 +00:00
Owner

#2420 changed the console: switchport trunk allowed vlan remove that takes every frame-carrying VLAN is now accepted and committed (leaving 1002-1005, or the empty list none stores). It updated the later paragraphs of docs/CLI.md but left two claims behind.

docs/CLI.md (line 2147) still said: "A remove that would empty the list is refused rather than committed, with both ways out named — a trunk carrying no VLAN is not something to arrive at by subtraction." That refusal no longer exists:

sw1(config-if)#switchport trunk allowed vlan 10,20
Trunk on Fa0/1 allows VLANs 10,20
sw1(config-if)#switchport trunk allowed vlan remove 10,20
Trunk on Fa0/1 allows no VLANs (removed 10,20)

engine/cli.js:3977-3982 stores allowedVlans: [] and answers allows no VLANs (removed …); the comment there says the state is "stored the same way rather than refused". The sentence now matches that, and the following remove 10 transcript (unchanged) still replays.

docs/ARCHITECTURE.md (line 1130) said test/trunk-allowed-remove-from-all.test.js was "47 checks"; it is 55 (node test/trunk-allowed-remove-from-all.test.js -> 55 passed). #2420 added eight checks (+8: 47 -> 55) and restated what the suite pins.

Guards before and after, unchanged: scripts/syntax-check.js 535 files OK; docs-cli-transcript 9/9; docs-show-commands 7/7; help-completeness 8/8; no-form-help-key 81/81; scripts/check-control-bytes.js clean; scripts/check-doc-citations.js 380 citations, rc 0.

Docs only; no engine or test changes.

#2420 changed the console: `switchport trunk allowed vlan remove` that takes every frame-carrying VLAN is now accepted and committed (leaving `1002-1005`, or the empty list `none` stores). It updated the later paragraphs of docs/CLI.md but left two claims behind. **docs/CLI.md (line 2147)** still said: *"A `remove` that would empty the list is refused rather than committed, with both ways out named — a trunk carrying no VLAN is not something to arrive at by subtraction."* That refusal no longer exists: ``` sw1(config-if)#switchport trunk allowed vlan 10,20 Trunk on Fa0/1 allows VLANs 10,20 sw1(config-if)#switchport trunk allowed vlan remove 10,20 Trunk on Fa0/1 allows no VLANs (removed 10,20) ``` `engine/cli.js:3977-3982` stores `allowedVlans: []` and answers `allows no VLANs (removed …)`; the comment there says the state is "stored the same way rather than refused". The sentence now matches that, and the following `remove 10` transcript (unchanged) still replays. **docs/ARCHITECTURE.md (line 1130)** said `test/trunk-allowed-remove-from-all.test.js` was "47 checks"; it is 55 (`node test/trunk-allowed-remove-from-all.test.js` -> 55 passed). #2420 added eight checks (+8: 47 -> 55) and restated what the suite pins. Guards before and after, unchanged: `scripts/syntax-check.js` 535 files OK; docs-cli-transcript 9/9; docs-show-commands 7/7; help-completeness 8/8; no-form-help-key 81/81; `scripts/check-control-bytes.js` clean; `scripts/check-doc-citations.js` 380 citations, rc 0. Docs only; no engine or test changes.
docs(cli): a trunk pruned to nothing is committed, and the guard is 55 checks
All checks were successful
CI / Server smoke and Docker build (pull_request) Successful in 15s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 9s
CI / Test (Node 20) (pull_request) Successful in 1m2s
CI / Test (Node 18) (pull_request) Successful in 1m3s
CI / Test (Node 22) (pull_request) Successful in 1m3s
CI / Arm auto-merge (pull_request) Successful in 3s
d2617e40b8
forgejo-actions scheduled this pull request to auto merge when all checks succeed 2026-11-21 13:51:30 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2429
No description provided.