ci(ci): drop the classifier job whose only remaining reader was the arm gate #2408
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!2408
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ci/1121-1027"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The
Classify the changejob is gone. Its three outputs are answered where they are spent, andarm- the last reader - asks the liveness question itself.Why it went
dockeralready classified its own diff (samescripts/classify-change.js, same arguments, one shallow fetch of the base commit,data_only=truestands its own steps down), and the three test legs read neitherdata_onlynorcode("three versions, always" is on the matrix). By 2026-11-21 the only consumer left of the whole job wasarm'slivecondition. So it bought one API call per run and cost a runner slot on every run: this runner takes four jobs at once, and ci.yml asked for five, so the fifth - always a test leg, i.e. the wall clock - waited for the classifier.Baseline (before) - leg logs, Forgejo run indices
Pull-request runs: median wall 70.9 s, third-leg start +9.5 .. +14.0 s, last leg ends ~+66 s, against a ~45 s suite.
After
Run 9262 (this PR, ci.yml for #2408), offsets from the first job's
received taskline:wall 70.9 s (PR median before) -> 62.2 s, -8.7 s / -12%. Third-leg start +9.5 s -> +0.0 s. All four jobs start within 0.1 s; the legs themselves are unchanged (57-58 s here, on a host that was ~10% slower than the baseline runs: 50-52 s suites against 44-46 s).
Post-merge push run 9277 (main
b0642b27, 446 suites / 15125 assertions): wall 74.3 s, docker +0.0 -> +18.3 s, legs +1.9 / +12.6 / +13.9 -> +58.6 / +68.7 / +69.0 s. The legs there queued behind the merge burst (close,audit,rebase,main-healthall dispatch on the same push), so that run is not a clean before/after - the classifier is gone from it, but it was never what the legs were waiting for in that burst.Coverage is unchanged
444 suite(s) ... 14983 assertions passed, 0 failedin every leg of 9262 - the same counts main's runs 9254/9250 report (444 / 14983); 446 / 15125 after the two device/test merges in 9277.armstill requires all threeCI / Test (Node *)statuses present and every status on the head green; the liveness question it now asks itself uses the legs' rule and direction (only a positivemerged:true/state:closedstands it down). 9262 armed this PR:#2408: armed for a squash merge of 333e7c7d ....Classify the change, which gated nothing: branch protection onmainhasenable_status_check: false.Workflow-only change:
.forgejo/workflows/ci.yml(+52 / -250).