plans(cli): the pipe is read as a word, so | include has nineteen answers #2401

Merged
jaylouisw merged 1 commit from plan/1121-0937 into main 2026-11-21 09:45:38 +00:00
Owner

Forward plan only, no code. Measured on d1ad8f93.

docs/plans/output-filters.md — IOS XE filters show output with | {begin|exclude|include|section} <regex>. This console has none of them, and no two handlers agree on what a pipe is: nineteen views answer does not take, show interfaces | exclude down prints % No interface | exclude down on R1, ping says % Unrecognized "|", traceroute drops the pipe and prints the unfiltered trace, links | include up ignores the filter, converge reads | as an instant.

Steps (S, S, S/M, M, S):

  1. one seam in run(): split at |, dispatch, filter — gated on the head word so description uplink | core stays data
  2. include / exclude as case-sensitive regex line filters on the reply, with refusals (% single line) never filtered
  3. begin, and ? at the filter position
  4. section, scoped to show running-config, where the block shape already exists
  5. docs (docs/CLI.md:129) and _help()

Left out deliberately: append/redirect/tee (no filesystem), count (platform-specific), more, pagination.

Closes no open issue — the queue is one blocked device request (#130). Related but not duplicated: show-help-key.md, show-view-seams.md, traceroute-options.md.

Forward plan only, no code. Measured on `d1ad8f93`. `docs/plans/output-filters.md` — IOS XE filters `show` output with `| {begin|exclude|include|section} <regex>`. This console has none of them, and no two handlers agree on what a pipe is: nineteen views answer `does not take`, `show interfaces | exclude down` prints `% No interface | exclude down on R1`, `ping` says `% Unrecognized "|"`, `traceroute` drops the pipe and prints the unfiltered trace, `links | include up` ignores the filter, `converge` reads `|` as an instant. Steps (S, S, S/M, M, S): 1. one seam in `run()`: split at `|`, dispatch, filter — gated on the head word so `description uplink | core` stays data 2. `include` / `exclude` as case-sensitive regex line filters on the reply, with refusals (`% ` single line) never filtered 3. `begin`, and `?` at the filter position 4. `section`, scoped to `show running-config`, where the block shape already exists 5. docs (`docs/CLI.md:129`) and `_help()` Left out deliberately: `append`/`redirect`/`tee` (no filesystem), `count` (platform-specific), `more`, pagination. Closes no open issue — the queue is one blocked device request (#130). Related but not duplicated: `show-help-key.md`, `show-view-seams.md`, `traceroute-options.md`.
plans(cli): the pipe is read as a word, so | include has nineteen answers
All checks were successful
CI / Classify the change (pull_request) Successful in 11s
CI / Server smoke and Docker build (pull_request) Successful in 30s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 5s
CI / Test (Node 20) (pull_request) Successful in 1m1s
CI / Test (Node 18) (pull_request) Successful in 1m3s
CI / Test (Node 22) (pull_request) Successful in 59s
CI / Arm auto-merge (pull_request) Successful in 3s
2f27ded54e
One plan, no code. Measured on d1ad8f93: nineteen views refuse a pipe as an argument, show interfaces names a port after it, ping calls it unrecognised, traceroute drops it in silence, links cannot see it, and converge reads it as an instant. Steps keep the filter in run(), above _show(), gated on the head word so a description containing | stays data.
forgejo-actions scheduled this pull request to auto merge when all checks succeed 2026-11-21 09:45:12 +00:00
jaylouisw deleted branch plan/1121-0937 2026-11-21 09:45:39 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2401
No description provided.