docs(simulation): the ACL rows said 'no counters', and their pointers had slid #2395

Merged
jaylouisw merged 1 commit from docs/1121-0847 into main 2026-11-21 09:12:46 +00:00
Owner

What was untrue

docs/SIMULATION.md §5.3 (ACLs) still claimed the model had no counters, and its code pointers had slid.

  • The row | **Absent** | Any state… No logging, no counters, no time-ranges… predates #1267/#1268. Since then every evaluation is tallied in engine/simulator.js:_countAclHit() (2993-3017) - per rule, keyed by the rule's text, plus the implicit deny - and show access-lists prints (N matches) per line and (implicit deny all: N matches) (engine/cli.js:6820-6863). docs/CLI.md already documents this ("how many packets each rule has matched"), so the two pages disagreed.
  • Pointers moved: implicit deny engine/acl.js:407-415 -> 443-451; _accessGroup() engine/cli.js:3970-4021 -> 4180-4231; _aclCheck() engine/simulator.js:2965-2986 -> 2965-2985; extended-match fields 2900-2907 -> 2971-2977; IPv4-only guard 2897 -> 2968.
  • The binding prose still said outbound was judged on the physical port; since #1517 out is evaluated on the interface the frame leaves by (subinterface if bound there, physical port otherwise, engine/simulator.js:3194-3195) and inbound asks both the port and the VLAN interface (3420-3438).

Change

One table in one doc: counters are now a Modelled row, "no counters" dropped from Absent, prose and pointers corrected. Docs-only; no code touched.

Gates

guard before after
scripts/syntax-check.js 521 files OK 521 files OK
docs-show-commands 7/7 7/7
docs-cli-transcript 9/9 9/9
help-completeness 8/8 8/8
no-form-help-key 81/81 81/81
check-control-bytes clean clean
doc-citations 11/11 11/11

Nothing else changed; no transcripts edited, so nothing needed to be retyped.

## What was untrue `docs/SIMULATION.md` §5.3 (ACLs) still claimed the model had **no counters**, and its code pointers had slid. - The row `| **Absent** | Any state… No logging, no counters, no time-ranges…` predates #1267/#1268. Since then every evaluation is tallied in `engine/simulator.js:_countAclHit()` (2993-3017) - per rule, keyed by the rule's text, plus the implicit deny - and `show access-lists` prints `(N matches)` per line and `(implicit deny all: N matches)` (`engine/cli.js:6820-6863`). `docs/CLI.md` already documents this ("how many packets each rule has matched"), so the two pages disagreed. - Pointers moved: implicit deny `engine/acl.js:407-415` -> `443-451`; `_accessGroup()` `engine/cli.js:3970-4021` -> `4180-4231`; `_aclCheck()` `engine/simulator.js:2965-2986` -> `2965-2985`; extended-match fields `2900-2907` -> `2971-2977`; IPv4-only guard `2897` -> `2968`. - The binding prose still said outbound was judged on the **physical port**; since #1517 out is evaluated on the interface the frame leaves by (subinterface if bound there, physical port otherwise, `engine/simulator.js:3194-3195`) and inbound asks both the port and the VLAN interface (`3420-3438`). ## Change One table in one doc: counters are now a **Modelled** row, "no counters" dropped from **Absent**, prose and pointers corrected. Docs-only; no code touched. ## Gates | guard | before | after | |---|---|---| | `scripts/syntax-check.js` | 521 files OK | 521 files OK | | `docs-show-commands` | 7/7 | 7/7 | | `docs-cli-transcript` | 9/9 | 9/9 | | `help-completeness` | 8/8 | 8/8 | | `no-form-help-key` | 81/81 | 81/81 | | `check-control-bytes` | clean | clean | | `doc-citations` | 11/11 | 11/11 | Nothing else changed; no transcripts edited, so nothing needed to be retyped.
docs(simulation): the ACL rows said 'no counters', and their pointers had slid (#1267, #1517)
All checks were successful
CI / Server smoke and Docker build (pull_request) Successful in 7s
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 6s
CI / Test (Node 20) (pull_request) Successful in 54s
CI / Test (Node 18) (pull_request) Successful in 56s
CI / Test (Node 22) (pull_request) Successful in 52s
CI / Arm auto-merge (pull_request) Successful in 2s
a7c3353012
forgejo-actions scheduled this pull request to auto merge when all checks succeed 2026-11-21 08:50:50 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2395
No description provided.