plans(traceroute): max is indexed and dropped, probes are unchangeable, and an IPv6 path has no trace #2360

Merged
jaylouisw merged 1 commit from plan/1121-0337 into main 2026-11-21 03:45:23 +00:00
Owner

Plans only - no code. Adds docs/plans/traceroute-options.md.

Measured on a6a6ab46.

  • help and docs/CLI.md:3944 advertise traceroute <address|name> [max <n>], but _traceroute() (engine/cli.js:5018) reads tokens[0] only and calls Simulator.traceroute() (engine/simulator.js:754) without opts, so max 2 walks 30 hops. The engine already takes maxHops (1-64) and probes (1-10); only tests reach them (test/icmp-errors-traceroute.test.js:75,95,108,148).
  • Every trailing word is swallowed: numeric, ttl 1, probes 1, source eth0 all print the unchanged trace - where ping has refused stray words since #1379 (engine/cli.js:4658).
  • Hops carry dev: null (:781,789,798) although _icmpErrorTo() knows the box (:3917), so a hop has no name and numeric has nothing to suppress.
  • IPv6: the console refuses a colon target (:5031), and _forwardL3v6() drops at hop limit 0 without an answer (:2493-2496) because ICMPV6_TYPES (engine/ipv6.js:21-28) has no time-exceeded or destination-unreachable; docs/SIMULATION.md:296 lists both as absent.

Six ordered steps: max <n>, one grammar line with named refusals, hop names/numeric, ICMPv6 errors (needs Jay's approval), traceroute6 (needs Jay's approval), and the two stale SIMULATION rows.

Closes no open issue; the queue holds only #130 and #803 (device requests).

Plans only - no code. Adds `docs/plans/traceroute-options.md`. Measured on `a6a6ab46`. - `help` and `docs/CLI.md:3944` advertise `traceroute <address|name> [max <n>]`, but `_traceroute()` (`engine/cli.js:5018`) reads `tokens[0]` only and calls `Simulator.traceroute()` (`engine/simulator.js:754`) without `opts`, so `max 2` walks 30 hops. The engine already takes `maxHops` (1-64) and `probes` (1-10); only tests reach them (`test/icmp-errors-traceroute.test.js:75,95,108,148`). - Every trailing word is swallowed: `numeric`, `ttl 1`, `probes 1`, `source eth0` all print the unchanged trace - where `ping` has refused stray words since #1379 (`engine/cli.js:4658`). - Hops carry `dev: null` (`:781,789,798`) although `_icmpErrorTo()` knows the box (`:3917`), so a hop has no name and `numeric` has nothing to suppress. - IPv6: the console refuses a colon target (`:5031`), and `_forwardL3v6()` drops at hop limit 0 without an answer (`:2493-2496`) because `ICMPV6_TYPES` (`engine/ipv6.js:21-28`) has no time-exceeded or destination-unreachable; `docs/SIMULATION.md:296` lists both as absent. Six ordered steps: `max <n>`, one grammar line with named refusals, hop names/`numeric`, ICMPv6 errors (needs Jay's approval), `traceroute6` (needs Jay's approval), and the two stale SIMULATION rows. Closes no open issue; the queue holds only #130 and #803 (device requests).
plans(traceroute): max is indexed and dropped, probes are unchangeable, and an IPv6 path has no trace
All checks were successful
CI / Classify the change (pull_request) Successful in 14s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 14s
CI / Test (Node 18) (pull_request) Successful in 1m2s
CI / Server smoke and Docker build (pull_request) Successful in 23s
CI / Test (Node 20) (pull_request) Successful in 1m4s
CI / Test (Node 22) (pull_request) Successful in 59s
CI / Arm auto-merge (pull_request) Successful in 4s
09c9429e94
forgejo-actions scheduled this pull request to auto merge when all checks succeed 2026-11-21 03:42:55 +00:00
jaylouisw deleted branch plan/1121-0337 2026-11-21 03:45:28 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2360
No description provided.