plans(server): a board you delete is back at the next boot #2318

Merged
jaylouisw merged 1 commit from plan/1120-2137 into main 2026-11-20 21:47:33 +00:00
Owner

Adds docs/plans/board-lifecycle.md. Plans only, no code.

Measured on 5da9cc49 by running the real server against a scratch PF_DATA:

  • DELETE /api/topologies/lab-keep answers {ok:true} and removes the map entry; lab-keep.json stays on disk and loadSavedTopologies() brings the board back on the next boot (server/index.js:844, :200-224).
  • DELETE of a board that never existed answers 200.
  • A file that will not parse is logged "left alone", never listed, and immune to DELETE — only rm recovers it.
  • GET /api/topologies is {ids} only; savedAt is written at :158 and read nowhere.
  • POST on an occupied name answers 201.
  • DELETE never calls broadcast(), so a second tab keeps painting a deleted board; the client is pinned to const TOPO = 'default' (web/app.js:4) and never lists boards.
  • No suite issues a board-level DELETE.

Six ordered steps (S/S/S/S/S/S-M) plus one M fenced as needs-Jay (a board surface in the UI). Closes no open issue; the queue is #803 and #130.

Deliberately left out: rename/duplicate, the fixed export filename, document-version migration, and the fullState()-twice cost.

Adds `docs/plans/board-lifecycle.md`. Plans only, no code. Measured on `5da9cc49` by running the real server against a scratch `PF_DATA`: * `DELETE /api/topologies/lab-keep` answers `{ok:true}` and removes the map entry; `lab-keep.json` stays on disk and `loadSavedTopologies()` brings the board back on the next boot (server/index.js:844, :200-224). * `DELETE` of a board that never existed answers 200. * A file that will not parse is logged "left alone", never listed, and immune to `DELETE` — only `rm` recovers it. * `GET /api/topologies` is `{ids}` only; `savedAt` is written at :158 and read nowhere. * `POST` on an occupied name answers 201. * `DELETE` never calls `broadcast()`, so a second tab keeps painting a deleted board; the client is pinned to `const TOPO = 'default'` (web/app.js:4) and never lists boards. * No suite issues a board-level `DELETE`. Six ordered steps (S/S/S/S/S/S-M) plus one M fenced as needs-Jay (a board surface in the UI). Closes no open issue; the queue is #803 and #130. Deliberately left out: rename/duplicate, the fixed export filename, document-version migration, and the `fullState()`-twice cost.
plans(server): a board you delete is back at the next boot
All checks were successful
CI / Classify the change (pull_request) Successful in 14s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 9s
CI / Server smoke and Docker build (pull_request) Successful in 25s
CI / Test (Node 22) (pull_request) Successful in 59s
CI / Test (Node 20) (pull_request) Successful in 1m0s
CI / Test (Node 18) (pull_request) Successful in 1m3s
CI / Arm auto-merge (pull_request) Successful in 3s
2dde3c89c5
forgejo-actions scheduled this pull request to auto merge when all checks succeed 2026-11-20 21:42:32 +00:00
jaylouisw deleted branch plan/1120-2137 2026-11-20 21:47:34 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2318
No description provided.