docs(ci): the third disclaimer-close, and the forge binds only the adjacent number #2317

Merged
jaylouisw merged 1 commit from catalogue/1120-2122 into main 2026-11-20 21:37:55 +00:00
Owner

Documentation of a tracker behaviour, not a device spec: no devices/ file is touched, and issue 130 stays open and blocked (Ubiquiti publishes no UDW-PRO artifact; the nine surfaces in that thread are unchanged).

What happened. PR #2301 merged at 19:08:34Z with a body opening "Does not close issue 130 or issue 803" (as written there, with # before each number). Issue 130 went to closed at 19:08:37Z with no comment on it; 803 stayed open. So the forge read the first number after the keyword and ignored the second: or is not a separator in its run. The issue was reopened at 21:24Z with that measurement recorded.

What changes.

file change
docs/CI.md the third row in The forge's own parser, and the sentence it cannot read, plus the narrower rule: the risk is the number adjacent to a keyword, not any number near it; a two-request disclaimer can lose one request while reading as if it protected both
scripts/check-closing-keywords.js header comment carries the third measurement (#2301, 19:08:37Z) and the same observation

The checker was run against the #2301 sentence: it reports exactly one at-risk reference (#130, negated) and not the second, which matches what the forge did.

Gates: node scripts/syntax-check.js -> 498 files, all OK; node scripts/audit-port-types.js -> 0 gated, 2704 reported template ports (unchanged baseline).

Refs #130

Documentation of a tracker behaviour, not a device spec: no `devices/` file is touched, and issue 130 stays open and blocked (Ubiquiti publishes no UDW-PRO artifact; the nine surfaces in that thread are unchanged). **What happened.** PR #2301 merged at 19:08:34Z with a body opening *"Does not close issue 130 or issue 803"* (as written there, with `#` before each number). Issue 130 went to `closed` at 19:08:37Z with no comment on it; 803 stayed open. So the forge read the first number after the keyword and ignored the second: `or` is not a separator in its run. The issue was reopened at 21:24Z with that measurement recorded. **What changes.** | file | change | |---|---| | `docs/CI.md` | the third row in *The forge's own parser, and the sentence it cannot read*, plus the narrower rule: the risk is the number **adjacent** to a keyword, not any number near it; a two-request disclaimer can lose one request while reading as if it protected both | | `scripts/check-closing-keywords.js` | header comment carries the third measurement (#2301, 19:08:37Z) and the same observation | The checker was run against the #2301 sentence: it reports exactly one at-risk reference (`#130`, `negated`) and not the second, which matches what the forge did. Gates: `node scripts/syntax-check.js` -> 498 files, all OK; `node scripts/audit-port-types.js` -> 0 gated, 2704 reported template ports (unchanged baseline). Refs #130
docs(ci): a third disclaimer-close, and the forge binds only the adjacent number
All checks were successful
CI / Classify the change (pull_request) Successful in 14s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 13s
CI / Server smoke and Docker build (pull_request) Successful in 23s
CI / Test (Node 22) (pull_request) Successful in 57s
CI / Test (Node 20) (pull_request) Successful in 59s
CI / Test (Node 18) (pull_request) Successful in 1m3s
CI / Arm auto-merge (pull_request) Successful in 4s
8c2725593e
PR #2301's body disclaimed both open device requests by name and the forge
closed exactly one of them, three seconds after the merge: issue 130. The
second reference in the same sentence was ignored, so "or" is not a
separator in the forge's run - the keyword binds to the number next to it.

That is the third measured close of a [Device]: request on its own
disclaimer, and the first with two numbers in one sentence. docs/CI.md
gets the third row and the narrower rule; the header of
scripts/check-closing-keywords.js gets the third measurement. No
behaviour change - the checker still reports, never gates.

Refs #130
forgejo-actions scheduled this pull request to auto merge when all checks succeed 2026-11-20 21:27:00 +00:00
jaylouisw deleted branch catalogue/1120-2122 2026-11-20 21:37:57 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2317
No description provided.