docs(architecture): the neighbours list says show-lldp 23 and poe 18, the suites print 24 and 21 #2300

Merged
jaylouisw merged 1 commit from docs/1120-1847 into main 2026-11-20 19:08:02 +00:00
Owner

What was untrue

docs/ARCHITECTURE.md, the "neighbours green" list under A saved lab forgot who was holding which address, gave two suite snapshots that the suites have outgrown:

  • show-lldp 23 — the file prints 24 (node test/show-lldp.test.js -> 24 passed, 0 failed). The 23 was written 2026-11-12; the show lldp neighbors rework (#2286) landed a check on top of it.
  • poe 18 — the file prints 21 (node test/poe.test.js -> 21 passed, 0 failed). #2124 (UCG-Ultra / UDM-Pro accept no PoE) added the poeIn: false and unpowered-transmit checks.

Both numbers were re-run rather than reasoned about; every other count in the same paragraph (lldp 27, lldp-across-trunk 32, flows-survive-save-load 16, spec-survives-load 32, dhcp-leases-survive-save 32, state-payload-complete 16, examples-generated 21, counters-agreement 32, link-state 69, stp-port-state 32, config-roundtrip 47, pon-splitter 33) still matches its file.

Guards

  • node scripts/syntax-check.js — 492 files, all OK
  • docs-commands (test/docs-show-commands.test.js) — 7 passed
  • docs-syntax/transcript (test/docs-cli-transcript.test.js) — 9 passed
  • help-coverage (test/help-completeness.test.js) — 8 passed
  • help-forms (test/no-form-help-key.test.js) — 81 passed
  • test/doc-catalog-counts.test.js — 43 checks passed

Docs-only: no engine, CLI or test change.

## What was untrue `docs/ARCHITECTURE.md`, the "neighbours green" list under *A saved lab forgot who was holding which address*, gave two suite snapshots that the suites have outgrown: - `show-lldp` **23** — the file prints **24** (`node test/show-lldp.test.js` -> `24 passed, 0 failed`). The 23 was written 2026-11-12; the `show lldp neighbors` rework (#2286) landed a check on top of it. - `poe` **18** — the file prints **21** (`node test/poe.test.js` -> `21 passed, 0 failed`). #2124 (UCG-Ultra / UDM-Pro accept no PoE) added the `poeIn: false` and unpowered-transmit checks. Both numbers were re-run rather than reasoned about; every other count in the same paragraph (lldp 27, lldp-across-trunk 32, flows-survive-save-load 16, spec-survives-load 32, dhcp-leases-survive-save 32, state-payload-complete 16, examples-generated 21, counters-agreement 32, link-state 69, stp-port-state 32, config-roundtrip 47, pon-splitter 33) still matches its file. ## Guards - `node scripts/syntax-check.js` — 492 files, all OK - docs-commands (`test/docs-show-commands.test.js`) — 7 passed - docs-syntax/transcript (`test/docs-cli-transcript.test.js`) — 9 passed - help-coverage (`test/help-completeness.test.js`) — 8 passed - help-forms (`test/no-form-help-key.test.js`) — 81 passed - `test/doc-catalog-counts.test.js` — 43 checks passed Docs-only: no engine, CLI or test change.
docs(architecture): the neighbours list cites show-lldp 23 and poe 18, today's suites print 24 and 21
All checks were successful
CI / Classify the change (pull_request) Successful in 22s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 14s
CI / Server smoke and Docker build (pull_request) Has been skipped
CI / Test (Node 22) (pull_request) Successful in 1m1s
CI / Test (Node 20) (pull_request) Successful in 1m4s
CI / Test (Node 18) (pull_request) Successful in 1m7s
CI / Arm auto-merge (pull_request) Successful in 4s
b77a83cd3f
Both counts were snapshots: `show-lldp` 23 was written on 2026-11-12 and the file's
#2286 rework ('show lldp neighbors' prints the box's five columns) took the file to
24 passing checks; `poe` 18 predates #2124 (UCG-Ultra/UDM-Pro are not PDs), which
added the four no-PoE/unpowered checks that make it 21. Verified by running both
files: 24 passed / 21 passed, 0 failed. Every other count in the paragraph was run
and matches.
forgejo-actions scheduled this pull request to auto merge when all checks succeed 2026-11-20 18:51:38 +00:00
jaylouisw deleted branch docs/1120-1847 2026-11-20 19:08:04 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2300
No description provided.