plans: a bundle's minimum links is a field nothing can set and nothing reads #2299

Merged
jaylouisw merged 1 commit from plan/1120-1837 into main 2026-11-20 18:43:51 +00:00
Owner

Forward plan only, no code.

docs/plans/lag-min-links.md — measured on 2fb4a9a7 with a two-switch probe lab.

What it finds

  • normalizeLag() parses minLinks and defaults it to 2 (engine/lag.js:99, :156-160) but is only reached from validateLag(); channel-group stores a literal with no such key (engine/cli.js:3823, :3844). grep -rln minLinks finds only test/lag.test.js.
  • show etherchannel summary prints M - not in use, minimum links not met in its key (engine/cli.js:447) and no code can print M: the bundle cell is S + U|D (:6939).
  • One live member of two reads Po1(SU), prints bundle 1 is running on 1 of 2 members, and pings 5/5. The data plane hashes across whatever is left (engine/simulator.js:3704) and degraded compares against capacity, not a threshold (:3716).
  • No verb exists: port-channel 1 min-links 3 and interface Port-channel1 are both % Unrecognized command, so show running-config has no line and nothing round-trips.
  • docs/SIMULATION.md:151 and :606 already mark it Approximate/decoration, citing engine/lag.js:90 where the constant no longer lives.

Six steps. Research capture (S) → put minLinks on the stored group with "absent means unset" (S) → one bundleState() predicate read by the summary, the member letters and the brief row (S) → port-channel <id> min-links <n> + no form (M) → PoN(SM) and a data-plane refusal (M) → docs and the stale citation (S).

Two design decisions are flagged needs Jay's approval: the default value (PacketForge's 2 is not the vendor's, and test/lag.test.js:34 pins it) and the verb's spelling (there is no interface Port-channelN mode here).

Steps 3 and 4 change answers pinned by test/brief-port-channel-row.test.js:16 and test/lag-member-down.test.js:105; the plan names both. Closes no open issue — the queue is two device requests (#803, #130).

node scripts/check-doc-citations.js and check-control-bytes.js pass.

Forward plan only, no code. `docs/plans/lag-min-links.md` — measured on `2fb4a9a7` with a two-switch probe lab. **What it finds** - `normalizeLag()` parses `minLinks` and defaults it to 2 (`engine/lag.js:99`, `:156-160`) but is only reached from `validateLag()`; `channel-group` stores a literal with no such key (`engine/cli.js:3823`, `:3844`). `grep -rln minLinks` finds only `test/lag.test.js`. - `show etherchannel summary` prints `M - not in use, minimum links not met` in its key (`engine/cli.js:447`) and no code can print `M`: the bundle cell is `S` + `U|D` (`:6939`). - One live member of two reads `Po1(SU)`, prints `bundle 1 is running on 1 of 2 members`, and pings 5/5. The data plane hashes across whatever is left (`engine/simulator.js:3704`) and `degraded` compares against capacity, not a threshold (`:3716`). - No verb exists: `port-channel 1 min-links 3` and `interface Port-channel1` are both `% Unrecognized command`, so `show running-config` has no line and nothing round-trips. - `docs/SIMULATION.md:151` and `:606` already mark it Approximate/decoration, citing `engine/lag.js:90` where the constant no longer lives. **Six steps.** Research capture (S) → put `minLinks` on the stored group with "absent means unset" (S) → one `bundleState()` predicate read by the summary, the member letters and the brief row (S) → `port-channel <id> min-links <n>` + `no` form (M) → `PoN(SM)` and a data-plane refusal (M) → docs and the stale citation (S). Two design decisions are flagged **needs Jay's approval**: the default value (PacketForge's 2 is not the vendor's, and `test/lag.test.js:34` pins it) and the verb's spelling (there is no `interface Port-channelN` mode here). Steps 3 and 4 change answers pinned by `test/brief-port-channel-row.test.js:16` and `test/lag-member-down.test.js:105`; the plan names both. Closes no open issue — the queue is two device requests (#803, #130). `node scripts/check-doc-citations.js` and `check-control-bytes.js` pass.
plans: a bundle's minimum links is a field nothing can set and nothing reads
All checks were successful
CI / Classify the change (pull_request) Successful in 11s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 8s
CI / Test (Node 18) (pull_request) Successful in 54s
CI / Test (Node 20) (pull_request) Successful in 53s
CI / Test (Node 22) (pull_request) Successful in 52s
CI / Server smoke and Docker build (pull_request) Successful in 18s
CI / Arm auto-merge (pull_request) Successful in 4s
c31002465c
forgejo-actions scheduled this pull request to auto merge when all checks succeed 2026-11-20 18:42:42 +00:00
jaylouisw deleted branch plan/1120-1837 2026-11-20 18:43:53 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2299
No description provided.