plans: a VRRP master keeps a gateway it can no longer serve #2253

Merged
jaylouisw merged 1 commit from plan/1120-0337 into main 2026-11-20 03:46:11 +00:00
Owner

One page of forward plan, no code. Measured on 8b94f987.

Finding. A VRRP master whose only uplink dies keeps priority 150 and the VIP: the election's only input for liveness is the group's own interface (engine/simulator.js:1080), so a healthy backup at 100 is never asked to take over. Probe lab (generic devices): PC pings a server through R1 (master, 150); cut R1's Gi0/1 and the ping returns link down (dropped by d1) 0/2 while R2 sits at Backup with a connected route. show vrrp on R1 still prints Master 150.

Second finding. setLinkState() (engine/simulator.js:498-556) rebuilds STP, flushes MAC tables and re-bases the schedule but never re-runs computeVrrp(); even shutdown on the master leaves device.vrrpClaims with it until the next ping or show.

Steps. (1) re-elect from the one choke point markTopologyChange(); (2) vrrp <vrid> track <iface> [decrement N]; (3) show vrrp names the track and the priority in force; (4) running-config round-trip and the no form; (5) preempt delay minimum; (6) docs. Sizes S/M/S/S/M/S. Closes no open issue (queue is #130 and #1980).

Left out on purpose: advertisement-loss detection, which needs held per-group state the module deliberately does not keep — flagged as a decision for Jay.

One page of forward plan, no code. Measured on `8b94f987`. **Finding.** A VRRP master whose only uplink dies keeps priority 150 and the VIP: the election's only input for liveness is the group's own interface (`engine/simulator.js:1080`), so a healthy backup at 100 is never asked to take over. Probe lab (generic devices): PC pings a server through R1 (master, 150); cut R1's Gi0/1 and the ping returns `link down (dropped by d1)` 0/2 while R2 sits at `Backup` with a connected route. `show vrrp` on R1 still prints `Master 150`. **Second finding.** `setLinkState()` (`engine/simulator.js:498-556`) rebuilds STP, flushes MAC tables and re-bases the schedule but never re-runs `computeVrrp()`; even `shutdown` on the master leaves `device.vrrpClaims` with it until the next ping or `show`. **Steps.** (1) re-elect from the one choke point `markTopologyChange()`; (2) `vrrp <vrid> track <iface> [decrement N]`; (3) `show vrrp` names the track and the priority in force; (4) running-config round-trip and the `no` form; (5) `preempt delay minimum`; (6) docs. Sizes S/M/S/S/M/S. Closes no open issue (queue is #130 and #1980). Left out on purpose: advertisement-loss detection, which needs held per-group state the module deliberately does not keep — flagged as a decision for Jay.
plans: a VRRP master keeps a gateway it can no longer serve
All checks were successful
CI / Classify the change (pull_request) Successful in 17s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 10s
CI / Server smoke and Docker build (pull_request) Successful in 34s
CI / Test (Node 22) (pull_request) Successful in 1m12s
CI / Test (Node 20) (pull_request) Successful in 1m14s
CI / Test (Node 18) (pull_request) Successful in 1m18s
CI / Arm auto-merge (pull_request) Successful in 5s
ee00e326ac
forgejo-actions scheduled this pull request to auto merge when all checks succeed 2026-11-20 03:45:10 +00:00
jaylouisw deleted branch plan/1120-0337 2026-11-20 03:46:13 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2253
No description provided.