docs(ARCHITECTURE): three neighbour-suite counts re-measured (ping-ipv6 41, show-arp 35, show-argument-refusal 84) #2250

Merged
jaylouisw merged 1 commit from docs/1120-0317 into main 2026-11-20 03:37:57 +00:00
Owner

docs/ARCHITECTURE.md carries two "Neighbours green" list the sections use to show which suites sit beside a rule. Each figure is that suite's check count, and three are stale.

suite doc says measured (node test/<suite>.test.js @ 8b94f987)
test/ping-ipv6.test.js 44 41
test/show-arp.test.js 31 35
test/show-argument-refusal.test.js 77 84

Evidence from the code:

  • 57deef1b (#2204) removed the five per-sequence Request timed out (seq N) checks and the two Reply from … checks from test/ping-ipv6.test.js and replaced them with the marks-line and rate-only assertions — 44 -> 41. The same commit updated the prose and transcript around line 895 but left the count.
  • d51d8637 (#1989) added the box's own addresses to show arp, growing test/show-arp.test.js 31 -> 35.
  • a2949f9d (#2147) and 82b3f781 (#2176) grew test/show-argument-refusal.test.js 77 -> 84.

The last re-measure of these lists was #1896 (e95680c8); nothing guards the numbers, so they drift silently. ping-ipv6 appears three times (both lists plus the pins it, N checks line at 901) and all three are corrected.

Docs-only: no engine, test or script change.

Guards: node scripts/syntax-check.js 476 files OK; check-control-bytes clean; docs-cli-transcript 9 passed; docs-show-commands 7 passed; no-form-help-key 81 passed; help-completeness 8 passed; doc-catalog-counts 43 passed; doc-citations 359 cited, none >40 lines from its code.

`docs/ARCHITECTURE.md` carries two "Neighbours green" list the sections use to show which suites sit beside a rule. Each figure is that suite's check count, and three are stale. | suite | doc says | measured (`node test/<suite>.test.js` @ 8b94f987) | |---|---|---| | `test/ping-ipv6.test.js` | 44 | **41** | | `test/show-arp.test.js` | 31 | **35** | | `test/show-argument-refusal.test.js` | 77 | **84** | Evidence from the code: * `57deef1b` (#2204) removed the five per-sequence `Request timed out (seq N)` checks and the two `Reply from …` checks from `test/ping-ipv6.test.js` and replaced them with the marks-line and rate-only assertions — 44 -> 41. The same commit updated the prose and transcript around line 895 but left the count. * `d51d8637` (#1989) added the box's own addresses to `show arp`, growing `test/show-arp.test.js` 31 -> 35. * `a2949f9d` (#2147) and `82b3f781` (#2176) grew `test/show-argument-refusal.test.js` 77 -> 84. The last re-measure of these lists was #1896 (e95680c8); nothing guards the numbers, so they drift silently. `ping-ipv6` appears three times (both lists plus the `pins it, N checks` line at 901) and all three are corrected. Docs-only: no engine, test or script change. Guards: `node scripts/syntax-check.js` 476 files OK; `check-control-bytes` clean; docs-cli-transcript 9 passed; docs-show-commands 7 passed; no-form-help-key 81 passed; help-completeness 8 passed; doc-catalog-counts 43 passed; doc-citations 359 cited, none >40 lines from its code.
docs(ARCHITECTURE): three neighbour-suite counts re-measured (ping-ipv6 41, show-arp 35, show-argument-refusal 84)
All checks were successful
CI / Classify the change (pull_request) Successful in 15s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 18s
CI / Server smoke and Docker build (pull_request) Has been skipped
CI / Test (Node 22) (pull_request) Successful in 1m7s
CI / Test (Node 20) (pull_request) Successful in 1m11s
CI / Test (Node 18) (pull_request) Successful in 1m16s
CI / Arm auto-merge (pull_request) Successful in 4s
4af548206c
The 'Neighbours green' lists measured each suite by its check count. Three
have moved since the last re-measure (#1896):

  * test/ping-ipv6.test.js     44 -> 41  (57deef1b, #2204, drops the
    per-echo reply/timeout checks for the marks line and the rate)
  * test/show-arp.test.js      31 -> 35  (d51d8637, #1989, the box's own
    addresses with a hyphen age)
  * test/show-argument-refusal.test.js  77 -> 84  (#2147, #2176)

Measured with node test/<suite>.test.js at 8b94f987: 41 / 35 / 84 passed.
forgejo-actions scheduled this pull request to auto merge when all checks succeed 2026-11-20 03:25:16 +00:00
jaylouisw deleted branch docs/1120-0317 2026-11-20 03:38:00 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2250
No description provided.