plans: web/ names every connector three times, and 240 models print 'Connector unknown' #2194
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!2194
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "plan/1119-1837"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Plan only - no code, no engine/test/workflow edits in this PR.
docs/plans/web-connector-vocabulary.md, measured onfac38e6f:{ name, family, label }(engine/media.js:339-405, exported at:1562). The browser knows a subset, three times over:CAGE_INFO(22 entries,web/faceplate.js:46-79),names(18,web/canvas.js:33-55),known(18,web/app.js:1953-1962). Onlyusbis spelt identically in all four places.qsfp56,sfp56,xfp, the fourfc-*,cfp2,serial,wwan); faceplate is missing nine (it knowsserial) and carries two dead keys (rj11, aliased todslatengine/media.js:410;mpo, which is a medium connector, never a cage).Connector unknown:wwan279,fc-sfp28144,fc-sfpdd80,fc-sfp72,cfp254,fc-qsfp288,sfp568,qsfp562,xfp2. An Advantech ICR-3231 reads2× RJ45 · 2× Console · 1× Connector unknown.familyOf()sends any cage it does not know toother(web/faceplate.js:144-151), andFAMILY_ORDERputsotherlast (:76), so a Brocade G720's 32G FC ports are drawn after the console.test/faceplate-names-every-connector.test.js:146fails ong.cage === 'unknown', butplan()keys groups by the resolved cage (web/faceplate.js:313-323), so an unnameablefc-sfpgroup is{cage:'fc-sfp', label:'Connector unknown'}and never matches;:137also limits the check toserial/consoleports.derivePortHardware()already computescageName(engine/media.js:1066), butDevice.serialize()drops it, which is why the copies exist.docs/CONNECTORS.md:814currently instructs maintainers to update both copies by hand.Seven ordered steps, each one PR and one worker: one shared web table with a test against
CAGES, then faceplate, canvas and inspector adopt it, then the guard is widened to every port, then (needs Jay)cageNamein the serialized payload, then the docs. Sizes S except step 6 (M).Closes no open issue - the queue is #2193, #2192, #2191, #2190, #2150, #130 and #1980, none about the browser. Step 6 needs Jay's approval before anyone acts on it.