cli(show): a refusal's advice must not point at a second refusal (#2146) #2151
Closed
jaylouisw
wants to merge 1 commit from
fix/1119-1232 into main
pull from: fix/1119-1232
merge into: jaylouisw:main
jaylouisw:main
jaylouisw:rev/1121-1812
jaylouisw:catalogue/1121-1822
jaylouisw:docs/1121-1817
jaylouisw:catalogue/1121-1752
jaylouisw:docs/1121-1747
jaylouisw:rev/1121-1742
jaylouisw:catalogue/1121-1722
jaylouisw:rev/1121-1712
jaylouisw:docs/1121-1717
jaylouisw:catalogue/1121-1652
jaylouisw:rev/1121-1642
jaylouisw:docs/1121-1647
jaylouisw:ci/1121-1646
jaylouisw:ci/1121-1427
jaylouisw:rev/1121-1412
jaylouisw:catalogue/1121-1422
jaylouisw:docs/1121-1417
jaylouisw:catalogue/1121-1352
jaylouisw:rev/1121-1342
jaylouisw:docs/1121-1347
jaylouisw:rev/1121-1212
jaylouisw:catalogue/1121-1222
jaylouisw:docs/1121-1217
jaylouisw:ci/1121-1027
jaylouisw:catalogue/1121-1022
jaylouisw:rev/1121-1013
jaylouisw:docs/1121-1017
jaylouisw:catalogue/1121-0852
jaylouisw:rev/1121-0842
jaylouisw:docs/1121-0847
jaylouisw:ci/1121-0827
jaylouisw:catalogue/1121-0822
jaylouisw:rev/1121-0812
jaylouisw:catalogue/1121-0752
jaylouisw:rev/1121-0742
jaylouisw:docs/1121-0747
jaylouisw:catalogue/1121-0722
jaylouisw:docs/1121-0717
jaylouisw:rev/1121-0712
jaylouisw:rev/1121-0642
jaylouisw:plan/1121-0637
jaylouisw:ci/1121-0627
jaylouisw:catalogue/1121-0622
jaylouisw:rev/1121-0612
jaylouisw:docs/1121-0617
jaylouisw:plan/1120-0337
jaylouisw:docs/1120-0347
jaylouisw:rev/1119-1942
jaylouisw:rev/1119-1912
jaylouisw:catalogue/1119-1752
jaylouisw:docs/1119-1347
jaylouisw:catalogue/1119-1352
jaylouisw:fix/1119-0602
jaylouisw:catalogue/1119-0452
jaylouisw:catalogue/1119-0422
jaylouisw:docs/1119-0417
jaylouisw:fix/1119-0202
jaylouisw:catalogue/1119-0222
jaylouisw:rev/1119-0042
jaylouisw:catalogue/1118-2252
jaylouisw:docs/1118-2047
jaylouisw:catalogue/1118-2152
jaylouisw:fix/1118-2037
jaylouisw:ci/1118-2027
jaylouisw:docs/1118-1416
jaylouisw:fix/1118-1006
jaylouisw:catalogue/1118-0326
jaylouisw:catalogue/1117-2326
jaylouisw:catalogue/1117-0025
jaylouisw:catalogue/1116-1730
jaylouisw:fix/1523-speed-downgrade-one-end
jaylouisw:fix/enable-required-and-empty-pipe-help
jaylouisw:land-all-v5
jaylouisw:land-all-v4
jaylouisw:land-all-v3
jaylouisw:land-all-v2
jaylouisw:land-all
jaylouisw:fix/board-id
jaylouisw:fix/stated-range
jaylouisw:fix/no-form-names-v2
jaylouisw:fix/voice-vlan
jaylouisw:devices/catalogue-batch
jaylouisw:devices/powerline-moca
jaylouisw:devices/firewalls-enterprise
jaylouisw:devices/pon-splitters
jaylouisw:devices/nvr-and-taps
jaylouisw:devices/four-nvr-models
jaylouisw:fix/contributing-exemption
jaylouisw:fix/stale-github-urls
jaylouisw:ci/cancel-superseded-runs
jaylouisw:gh/1438
jaylouisw:device/uisp-console-lbe-xr
jaylouisw:gh/1442
jaylouisw:docs/readme-current-counts
jaylouisw:feat/device-ubiquiti-wave-fiber-onu
jaylouisw:fix/address-ownership
jaylouisw:feat/vrrp-in-path
jaylouisw:fix/merge-research-duplicate
jaylouisw:docs/hybrid-patch-current
jaylouisw:fix/audit-port-template
jaylouisw:fix/2930f-jl256a-uplinks
jaylouisw:feat/dhcp-in-path
jaylouisw:feat/hackgpon-ubiquiti-uisp-fiber-xgs
jaylouisw:feat/hackgpon-adtran-sdx-621
jaylouisw:tool/issue-duplicate-sweep
jaylouisw:feat/device-mikrotik-rb433ah
jaylouisw:feat/hackgpon-ma5671a
jaylouisw:issues/categories-and-labels
jaylouisw:ci/run-every-suite-locally
jaylouisw:chore/http-smoke
No reviewers
Labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!2151
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1119-1232"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #2146
1.
show ip interface brief <word>offered the rejected word back as a port.The pointer now prints the port only when the typed words resolve to one
show interfacescan describe (sameresolvePortNametable, and a console/aux socket is a line, not an interface); otherwise it keeps the<port>placeholdershow mac address-table interface <port>already uses.2.
show ip route <prefix>pointed at a table it never printed. The refusal is one line (#1403), so "read the row for the prefix in the table below" sent the reader past the answer. It now names the command that prints the table:typeshow ip routeand read the row for the prefix.docs/CLI.mdquotes the second message and moves with it, and now states the rule: the sentence after the dash may not name a command that refuses in turn.Tests: new section in
test/show-argument-refusal.test.jsfollows every pointer rather than reading it (unknown word -> placeholder, console socket -> placeholder, every port the box lists ->show interfacesanswers, route refusal ->show ip routeanswers). 5 of its assertions fail on origin/main. Fullnpm test: 374 suites, 12705 assertions, 0 failed.Closing as superseded — main already contains this change, and this branch would revert the work that landed after it.
What this PR does was landed an hour earlier by #2147 (squash
a2949f9d, "cli: ashowrefusal names a command this box can run, and no table it did not print"). Same subject, same three files, same tests:test/show-argument-refusal.test.jsgains the "advice after the dash points at something that is there (#2146)" block;engine/cli.jsgainsresolvePortName-guarded<port>in theshow ip interface briefrefusal and drops "in the table below" fromshow ip route. The only difference I can see is the verb — this branch says "typeshow ip route", main says "runshow ip route".It is also stale in a way a merge would damage: the branch predates #2149 (
053b3995, power-deny / 0.0 W), and itsdocs/CLI.mdhunk puts that section back toOper off … 12.95 W … (denied). Merging it would revert landed documentation. Hencemergeable=false— the conflict is ondocs/CLI.mdandengine/cli.js, both against newer main.No content is lost:
git diff origin/main 5b6fc849shows this branch's net effect onengine/cli.jsis already in main, minus the #2149 revert.If the "type" wording is actually wanted over "run", it is a one-line PR against current main — reopen on that basis and I will merge it. Rebased-and-reopened is fine; force-pushing this branch would drop #2149 again.
Pull request closed