ci(test): start the Node matrix at dispatch instead of behind the classifier #2073

Merged
jaylouisw merged 3 commits from ci/1119-0227 into main 2026-11-19 03:08:26 +00:00
Owner

Baseline

Classify the change sits in front of all three Test (Node *) legs and publishes nothing the matrix reads (data_only only stands smoke/docker down; live is now asked by the leg).

  • /actions/tasks, 858 Classify the change tasks over 2026-11-17..19: median 7 s, p90 11 s.
  • Run 6947 (PR #2071, 2026-11-19): classify 02:22:05 -> 02:22:11 (6 s), Test (Node 18) created 02:22:13 and finished 02:23:14 (61 s); run 02:22:05 -> 02:23:20 = 75 s. Node 18 is the wall clock.
  • Run 6945 (PR #2070): classify 02:20:28 -> 02:20:35, legs created 02:20:37 (9 s).
  • Reliability: run 6076 / task 15604 — classifier hung 855 s, log lost, the five jobs below it never existed: one red X on a PR with zero coverage.

Change

  • test no longer has needs: changes. Legs are created at dispatch.
  • The merged/closed stand-down moves into the leg as one API call (still_open) at step start: same rule (only a positive merged: true / state: closed stops it), same fail-open direction (no token, timeout, unparseable reply -> run).
  • No check removed, added, softened or retried.

Coverage unchanged

All three Node legs, the full 344-suite npm test, the syntax check, the three static scans, both example steps, smoke, docker and arm are untouched. smoke/docker still wait for the classifier, so a data-only diff still stands them down.

## Baseline `Classify the change` sits in front of all three `Test (Node *)` legs and publishes nothing the matrix reads (`data_only` only stands `smoke`/`docker` down; `live` is now asked by the leg). - `/actions/tasks`, 858 `Classify the change` tasks over 2026-11-17..19: **median 7 s, p90 11 s**. - **Run 6947** (PR #2071, 2026-11-19): classify `02:22:05 -> 02:22:11` (6 s), `Test (Node 18)` created `02:22:13` and finished `02:23:14` (61 s); run `02:22:05 -> 02:23:20` = 75 s. Node 18 is the wall clock. - **Run 6945** (PR #2070): classify `02:20:28 -> 02:20:35`, legs created `02:20:37` (9 s). - Reliability: **run 6076 / task 15604** — classifier hung 855 s, log lost, the five jobs below it never existed: one red X on a PR with zero coverage. ## Change - `test` no longer has `needs: changes`. Legs are created at dispatch. - The merged/closed stand-down moves into the leg as one API call (`still_open`) at step start: same rule (only a positive `merged: true` / `state: closed` stops it), same fail-open direction (no token, timeout, unparseable reply -> run). - No check removed, added, softened or retried. ## Coverage unchanged All three Node legs, the full 344-suite `npm test`, the syntax check, the three static scans, both example steps, `smoke`, `docker` and `arm` are untouched. `smoke`/`docker` still wait for the classifier, so a data-only diff still stands them down.
ci(test): start the Node matrix at dispatch instead of behind the classifier
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 18s
CI / Test (Node 18) (pull_request) Failing after 1m1s
CI / Test (Node 20) (pull_request) Successful in 59s
CI / Test (Node 22) (pull_request) Successful in 59s
CI / Server smoke test (pull_request) Successful in 10s
CI / Docker build (pull_request) Successful in 44s
CI / Arm auto-merge (pull_request) Successful in 3s
d1ce3cc67e
Every Test (Node *) leg waited for Classify the change, a job whose outputs the
matrix never reads: data_only only stands smoke and docker down, and liveness
is now asked by the leg itself. The classifier is 7 s median / 11 s p90 over the
858 tasks of the last two days, and run 6947 shows the cost - classify held
02:22:05-02:22:11 and the leg that is the wall clock of the run (Test (Node 18),
61 s of 75 s) was created at 02:22:13.

Same dependency is why run 6076 / task 15604 reported one red X and zero
coverage when the classifier hung for 855 s.

The stand-down for an already merged or closed pull request moves into the leg
as one API call at step start: same rule (only a positive merged/closed answer
stops it), same fail-open direction. No check is removed, added or weakened.
forgejo-actions force-pushed ci/1119-0227 from d1ce3cc67e
Some checks failed
CI / Classify the change (pull_request) Successful in 10s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 18s
CI / Test (Node 18) (pull_request) Failing after 1m1s
CI / Test (Node 20) (pull_request) Successful in 59s
CI / Test (Node 22) (pull_request) Successful in 59s
CI / Server smoke test (pull_request) Successful in 10s
CI / Docker build (pull_request) Successful in 44s
CI / Arm auto-merge (pull_request) Successful in 3s
to 85c26dc8b0 2026-11-19 02:43:07 +00:00
Compare
ci(test): re-run the matrix on the rebased head (Node 18 leg red on 6969/d1ce3cc6, siblings green)
Some checks failed
CI / Classify the change (pull_request) Successful in 14s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Server smoke test (pull_request) Successful in 8s
CI / Test (Node 20) (pull_request) Successful in 54s
CI / Test (Node 22) (pull_request) Failing after 55s
CI / Test (Node 18) (pull_request) Successful in 59s
CI / Docker build (pull_request) Successful in 20s
CI / Arm auto-merge (pull_request) Successful in 3s
d33c1ce53b
forgejo-actions force-pushed ci/1119-0227 from d33c1ce53b
Some checks failed
CI / Classify the change (pull_request) Successful in 14s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 15s
CI / Server smoke test (pull_request) Successful in 8s
CI / Test (Node 20) (pull_request) Successful in 54s
CI / Test (Node 22) (pull_request) Failing after 55s
CI / Test (Node 18) (pull_request) Successful in 59s
CI / Docker build (pull_request) Successful in 20s
CI / Arm auto-merge (pull_request) Successful in 3s
to 43b5d381f2 2026-11-19 02:51:19 +00:00
Compare
ci(test): run CI on the rebased head (rebase force-push produced no run)
All checks were successful
CI / Classify the change (pull_request) Successful in 9s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 8s
CI / Server smoke test (pull_request) Successful in 9s
CI / Docker build (pull_request) Successful in 22s
CI / Test (Node 18) (pull_request) Successful in 56s
CI / Test (Node 20) (pull_request) Successful in 54s
CI / Test (Node 22) (pull_request) Successful in 54s
CI / Arm auto-merge (pull_request) Successful in 3s
8177e81f85
forgejo-actions scheduled this pull request to auto merge when all checks succeed 2026-11-19 03:00:31 +00:00
jaylouisw deleted branch ci/1119-0227 2026-11-19 03:08:28 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2073
No description provided.