plans: the trunk is edited by three verbs and printed by no table #2058

Merged
jaylouisw merged 1 commit from plan/1119-0037 into main 2026-11-19 02:39:04 +00:00
Owner

Plan only - no code, no engine/test/workflow edits in this PR.

docs/plans/interfaces-trunk-view.md, measured on 68857a05.

  • show interfaces trunk is a refused view: the 13-entry INTERFACES_VIEW_KEYWORDS table (engine/cli.js:551-568, trunk at :557) answers it with % 'trunk' is a view, not a port: this console has no 'show interfaces trunk'. and points at show vlan brief + show interfaces <port>. test/show-interfaces-view-keywords.test.js:108 pins the phrase; docs/ARCHITECTURE.md:722/738/1260/1290 carry the 13 / twelve / 97 counts.
  • The configuration side is finished and busy: three verbs write the allowed list (cli.js:3175-3330), 15 of the last 80 commits are about it, five trunk-allowed-* suites pin it - and nothing lists the trunks.
  • The readable half is one line inside a 10-line block (switchportSentence() engine/vlan.js:436, printed at cli.js:6487): show interfaces is 66 lines on the 8-port generic switch, ~370 on a 48-port box.
  • Two states are reachable and invisible: switchport trunk allowed vlan 10,20,99 is accepted with VLAN 99 never created (allowed but not active), and a trunk cabled to an access port measures status: up, protocol: up while mismatchReason() (vlan.js:738) already knows the sentence and no view prints it.
  • Device.inactiveVlan() (device.js:382-395) answers the deleted-VLAN question for access ports only, and says in its own comment that the trunk half is left alone.

Five ordered steps, each one PR: capture the vendor's four sections (S, research only), add sections 1-2 as _showInterfacesTrunk() beside _showDhcp() (M, needs Jay's approval), extract one VLAN database shared with show vlan so allowed-vs-active cannot disagree (S), share the carrier list with no vlan (S), and move the docs, help index and the four ARCHITECTURE counts (S).

Vlans in spanning tree forwarding state and not pruned is out of scope: engine/stp.js:191 runs one tree with no VLAN argument, so a per-VLAN answer does not exist to print.

Closes no open issue - the queue is #130 and #803, both device requests. It supplies the transcript open PR #2056 records as unfound, which is why it is complementary rather than a duplicate.

Guards: node scripts/syntax-check.js 430 files OK; node scripts/check-doc-citations.js clean.

Plan only - no code, no engine/test/workflow edits in this PR. `docs/plans/interfaces-trunk-view.md`, measured on `68857a05`. - `show interfaces trunk` is a refused *view*: the 13-entry `INTERFACES_VIEW_KEYWORDS` table (`engine/cli.js:551-568`, `trunk` at `:557`) answers it with `% 'trunk' is a view, not a port: this console has no 'show interfaces trunk'.` and points at `show vlan brief` + `show interfaces <port>`. `test/show-interfaces-view-keywords.test.js:108` pins the phrase; `docs/ARCHITECTURE.md:722/738/1260/1290` carry the 13 / twelve / 97 counts. - The configuration side is finished and busy: three verbs write the allowed list (`cli.js:3175-3330`), 15 of the last 80 commits are about it, five `trunk-allowed-*` suites pin it - and nothing lists the trunks. - The readable half is one line inside a 10-line block (`switchportSentence()` `engine/vlan.js:436`, printed at `cli.js:6487`): `show interfaces` is 66 lines on the 8-port generic switch, ~370 on a 48-port box. - Two states are reachable and invisible: `switchport trunk allowed vlan 10,20,99` is accepted with VLAN 99 never created (allowed but not active), and a trunk cabled to an access port measures `status: up, protocol: up` while `mismatchReason()` (`vlan.js:738`) already knows the sentence and no view prints it. - `Device.inactiveVlan()` (`device.js:382-395`) answers the deleted-VLAN question for access ports only, and says in its own comment that the trunk half is left alone. Five ordered steps, each one PR: capture the vendor's four sections (S, research only), add sections 1-2 as `_showInterfacesTrunk()` beside `_showDhcp()` (M, **needs Jay's approval**), extract one VLAN database shared with `show vlan` so allowed-vs-active cannot disagree (S), share the carrier list with `no vlan` (S), and move the docs, help index and the four ARCHITECTURE counts (S). `Vlans in spanning tree forwarding state and not pruned` is out of scope: `engine/stp.js:191` runs one tree with no VLAN argument, so a per-VLAN answer does not exist to print. Closes no open issue - the queue is #130 and #803, both device requests. It supplies the transcript open PR #2056 records as unfound, which is why it is complementary rather than a duplicate. Guards: `node scripts/syntax-check.js` 430 files OK; `node scripts/check-doc-citations.js` clean.
plans: the trunk is edited by three verbs and printed by no table
All checks were successful
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 9s
CI / Server smoke test (pull_request) Successful in 9s
CI / Docker build (pull_request) Successful in 22s
CI / Test (Node 20) (pull_request) Successful in 56s
CI / Test (Node 22) (pull_request) Successful in 58s
CI / Test (Node 18) (pull_request) Successful in 1m1s
CI / Arm auto-merge (pull_request) Successful in 2s
33e06c3417
`show interfaces trunk` is answered by a keyword sentence (cli.js:557) that points at two
other commands, so the one question a trunk is configured to answer - what does it carry, and
is that VLAN still on the box - has no view. Measured on 68857a05: allowed-but-absent VLAN 99
is accepted and printed by the port sentence alone, `show vlan brief` has no row for it, and a
trunk cabled to an access port reads up/up while `mismatchReason()` already knows the sentence.

Plan only: capture the vendor's four sections, add sections 1-2 as a method beside `_showDhcp()`
(needs Jay's approval), extract one VLAN database shared with `show vlan`, share the carrier list
with `no vlan`, and move the 13/twelve/97 counts in ARCHITECTURE. Forwarding-state and PVST are
out of scope: `engine/stp.js` runs one tree with no VLAN.

No code, no engine/test/workflow edits.
forgejo-actions force-pushed plan/1119-0037 from 33e06c3417
All checks were successful
CI / Classify the change (pull_request) Successful in 7s
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 9s
CI / Server smoke test (pull_request) Successful in 9s
CI / Docker build (pull_request) Successful in 22s
CI / Test (Node 20) (pull_request) Successful in 56s
CI / Test (Node 22) (pull_request) Successful in 58s
CI / Test (Node 18) (pull_request) Successful in 1m1s
CI / Arm auto-merge (pull_request) Successful in 2s
to 8f9153a6de 2026-11-19 00:43:04 +00:00
Compare
jaylouisw force-pushed plan/1119-0037 from 6f108e8fbe to f0b760af55
All checks were successful
PR rebase / Rebase onto main and arm auto-merge (pull_request) Successful in 4s
CI / Classify the change (pull_request) Successful in 7s
CI / Server smoke test (pull_request) Successful in 12s
CI / Test (Node 18) (pull_request) Successful in 58s
CI / Docker build (pull_request) Successful in 21s
CI / Test (Node 20) (pull_request) Successful in 53s
CI / Test (Node 22) (pull_request) Successful in 48s
CI / Arm auto-merge (pull_request) Successful in 3s
2026-11-19 02:10:39 +00:00
Compare
forgejo-actions scheduled this pull request to auto merge when all checks succeed 2026-11-19 02:20:29 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!2058
No description provided.