ci: a classifier that dies must run the gate, not skip it #1972
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1972
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ci/1118-1020"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A failing
Classify the changejob used to stand the whole gate down instead of running it: the five jobs below depend on it, so a failed dependency made themskipped, and the pull request carried one red X and zero coverage of its diff.Baseline (before)
Classify the change, pull #1957, 2026-11-18T08:21:26Z): failed after 855 s, and it is the only task that run ever created - no log survived either (dbfs open "actions_log/jaylouisw/packetforge/f4/15604.log.zst": file does not exist). No test leg, no smoke, no Docker build was ever dispatched.probe-classify-fail, the same file with a 4-lineexit 1probe in the classify job):After
always()on theif:oftest,smokeanddocker. A failed classifier now runs the full matrix - the same conservative answerclassify-change.jsalready prints whenever it cannot read a diff.Same probe, same 4 lines, on the fixed file - run 6202, tasks 15986-15992:
Normal path unchanged - run 6203 (this branch, workflow_dispatch, 7 tasks, wall clock 66 s, every job green) against the baseline run 6172 (main, dispatch at 10:27, 7 tasks, wall clock 58 s, same 7 tasks, same statuses, arm skipped on both because neither is a
pull_requestevent).Coverage is unchanged
No check is removed, relaxed or made conditional.
live=falseanddata_only=trueare outputs the classifier writes only when it succeeded and positively said so, and both still stand the legs down; an absent output has always meant "run". A cancelled run still cancels its jobs -always()describes a failed dependency, not a cancelled run. The only behaviour that changes is the one where the gate previously produced no verdict at all.The two probe branches (
probe-classify-fail,probe-classify-fail-fixed) are throwaway evidence and are deleted after this opens.