test(close-merged-issues): read the open-request ledger, not a snapshot of it (#1963) #1970
Closed
jaylouisw
wants to merge 1 commit from
fix/1118-1006 into main
pull from: fix/1118-1006
merge into: jaylouisw:main
jaylouisw:main
jaylouisw:rev/1121-1812
jaylouisw:catalogue/1121-1822
jaylouisw:docs/1121-1817
jaylouisw:catalogue/1121-1752
jaylouisw:docs/1121-1747
jaylouisw:rev/1121-1742
jaylouisw:catalogue/1121-1722
jaylouisw:rev/1121-1712
jaylouisw:docs/1121-1717
jaylouisw:catalogue/1121-1652
jaylouisw:rev/1121-1642
jaylouisw:docs/1121-1647
jaylouisw:ci/1121-1646
jaylouisw:ci/1121-1427
jaylouisw:rev/1121-1412
jaylouisw:catalogue/1121-1422
jaylouisw:docs/1121-1417
jaylouisw:catalogue/1121-1352
jaylouisw:rev/1121-1342
jaylouisw:docs/1121-1347
jaylouisw:rev/1121-1212
jaylouisw:catalogue/1121-1222
jaylouisw:docs/1121-1217
jaylouisw:ci/1121-1027
jaylouisw:catalogue/1121-1022
jaylouisw:rev/1121-1013
jaylouisw:docs/1121-1017
jaylouisw:catalogue/1121-0852
jaylouisw:rev/1121-0842
jaylouisw:docs/1121-0847
jaylouisw:ci/1121-0827
jaylouisw:catalogue/1121-0822
jaylouisw:rev/1121-0812
jaylouisw:catalogue/1121-0752
jaylouisw:rev/1121-0742
jaylouisw:docs/1121-0747
jaylouisw:catalogue/1121-0722
jaylouisw:docs/1121-0717
jaylouisw:rev/1121-0712
jaylouisw:rev/1121-0642
jaylouisw:plan/1121-0637
jaylouisw:ci/1121-0627
jaylouisw:catalogue/1121-0622
jaylouisw:rev/1121-0612
jaylouisw:docs/1121-0617
jaylouisw:plan/1120-0337
jaylouisw:docs/1120-0347
jaylouisw:rev/1119-1942
jaylouisw:rev/1119-1912
jaylouisw:catalogue/1119-1752
jaylouisw:docs/1119-1347
jaylouisw:catalogue/1119-1352
jaylouisw:fix/1119-1232
jaylouisw:fix/1119-0602
jaylouisw:catalogue/1119-0452
jaylouisw:catalogue/1119-0422
jaylouisw:docs/1119-0417
jaylouisw:fix/1119-0202
jaylouisw:catalogue/1119-0222
jaylouisw:rev/1119-0042
jaylouisw:catalogue/1118-2252
jaylouisw:docs/1118-2047
jaylouisw:catalogue/1118-2152
jaylouisw:fix/1118-2037
jaylouisw:ci/1118-2027
jaylouisw:docs/1118-1416
jaylouisw:catalogue/1118-0326
jaylouisw:catalogue/1117-2326
jaylouisw:catalogue/1117-0025
jaylouisw:catalogue/1116-1730
jaylouisw:fix/1523-speed-downgrade-one-end
jaylouisw:fix/enable-required-and-empty-pipe-help
jaylouisw:land-all-v5
jaylouisw:land-all-v4
jaylouisw:land-all-v3
jaylouisw:land-all-v2
jaylouisw:land-all
jaylouisw:fix/board-id
jaylouisw:fix/stated-range
jaylouisw:fix/no-form-names-v2
jaylouisw:fix/voice-vlan
jaylouisw:devices/catalogue-batch
jaylouisw:devices/powerline-moca
jaylouisw:devices/firewalls-enterprise
jaylouisw:devices/pon-splitters
jaylouisw:devices/nvr-and-taps
jaylouisw:devices/four-nvr-models
jaylouisw:fix/contributing-exemption
jaylouisw:fix/stale-github-urls
jaylouisw:ci/cancel-superseded-runs
jaylouisw:gh/1438
jaylouisw:device/uisp-console-lbe-xr
jaylouisw:gh/1442
jaylouisw:docs/readme-current-counts
jaylouisw:feat/device-ubiquiti-wave-fiber-onu
jaylouisw:fix/address-ownership
jaylouisw:feat/vrrp-in-path
jaylouisw:fix/merge-research-duplicate
jaylouisw:docs/hybrid-patch-current
jaylouisw:fix/audit-port-template
jaylouisw:fix/2930f-jl256a-uplinks
jaylouisw:feat/dhcp-in-path
jaylouisw:feat/hackgpon-ubiquiti-uisp-fiber-xgs
jaylouisw:feat/hackgpon-adtran-sdx-621
jaylouisw:tool/issue-duplicate-sweep
jaylouisw:feat/device-mikrotik-rb433ah
jaylouisw:feat/hackgpon-ma5671a
jaylouisw:issues/categories-and-labels
jaylouisw:ci/run-every-suite-locally
jaylouisw:chore/http-smoke
No reviewers
Labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1970
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/1118-1006"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1963
What was wrong. The last block of
test/close-merged-issues.test.jspasted Jay's open device-request queue as a literal and asserted none of those requests was in the catalogue. Answering a request therefore turned the suite red: #1962 (E9612) failed on all three Node legs for modelling the device it was opened to model, and #1934 for the three subracks it models. #1955 was green only because it hand-edited the same literal in its own commit (1304b0bd).What changed. The queue is read from
research/open-device-requests.jsoninstead of being copied into the test. That file is already the machine-readable queue:docs/DEVICE_REGISTRY.mdis rendered from it andscripts/check-closed-issues.jsreads it as the "still blocked" record, and a request leaves it in the commit that models the device (as #1962 did for #808). The assertion keeps the part that matters: a row the ledger still lists as blocked must not be one the sweep would close, because the ledger would then be lying to the docs and the sweep would close an issue for a device nobody built. The count in the message is derived, not spelled out, and a failure now reads#810 -> devices/huawei/optixtrans-e9624.jsonso the remediation is visible. Two rows about the join itself were added (the ledger is non-empty, and every row has an issue and a model).Reproduced, then fixed. A stand-in for the device PR that answers #810 - an
optixtrans-e9624.jsonadded, the#810row dropped - leavesorigin/main's version at 73 passed / 1 failed (none of the six open requests is in the catalogue ... [#810]) and this version at 76 passed / 0 failed. Negative control: a ledger row for the already-built RUTX12 correctly fails with#999 -> devices/teltonika/rutx12.json.Gates.
node scripts/syntax-check.js412 files all OK;node scripts/check-control-bytes.jsclean;close-merged-issues76/0,closed-issues-audit36/0,doc-catalog-counts43/0,request-queue32/0. Test-only change, so no engine or CLI code is touched.No new feature and no device work. The catalogue, the ledger, the sweep and every spec are untouched; only the test file changed. The device stream can land #1962 (already merged) and rebase #1934 without editing this test.
Superseded by #1967, which landed four minutes before this was opened. Closing.
Same issue (#1963), same file, same fix: stop pasting the open-request queue into
test/close-merged-issues.test.jsand read it fromresearch/open-device-requests.json. #1967 merged as587039a2(green 8/8, all three Node legs), so the ledger is already what the test reads on main.This branch is
mergeable: falsefor that reason only:587039a2rewrote the same block. No rebase needed — there is nothing left for it to change.One substantive difference worth keeping in mind, recorded rather than silently dropped: #1967 pins the looser property a request the catalogue answers is answered by its own spec file (so an answered row may linger in the ledger), while this branch kept none of the open requests is in the catalogue against the ledger itself, which additionally catches a stale ledger row (
npm run regen:registry-doc). Main has the looser form. If we want the stricter ledger-staleness assertion as well, it is a one-assertion follow-up on top of587039a2, not this PR.Surgery loop, 10:24.
Pull request closed