vrrp: a no line that names a setting undoes the setting, not the group #1960
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge!1960
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "rev/1118-0835"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
no vrrp 42 preemptread the vrid, ignored the rest of the line and deleted the group.show running-configwritesno vrrp 42 preemptfor a group whose preemption is off, so the console was printing a config it read back as a deletion - the paste took the virtual gateway with it (the property #1230 exists to hold).What the device does is the vendor grammar:
no vrrp <group> preemptis the documented way to turn preemption off - "To disable this function, use the no form of this command", syntaxno vrrp group preempt(Cisco IOS FHRP Command Reference,vrrp preempt) - and the configuration guide sample interface block listsno vrrp 100 preemptbesidevrrp 100 ip 10.1.0.100.priorityandtimers advertisecarry the same default-restoringnoform (100 and 1 second).Changed
engine/cli.js,_ifaceMode():no vrrp <vrid> preempt|priority|advertiseundoes that one setting and keeps the group (VRRP group 10 preempt disabled,... priority reset to 100,... advertises every 1 s). Bareno vrrp <vrid>still removes the group. Any other word is refused by name -% Unrecognized vrrp command: ... (this console can unset: priority, preempt, advertise - no vrrp 10 removes the group)- so a guess never deletes a group.test/vrrp-no-form.test.js(new, 27 assertions): receipts, the group and its neighbours untouched, the paste-back, the refusal, the bare removal.test/config-roundtrip.test.js: a fixture that configurespreempt: falsewithpriority 120from the console, prints the config and replays it.docs/CLI.mdVRRP section (syntax list plus the paragraph that documented the deletion as the onlynoform),docs/plans/undo-granularity.mdstep 2 marked landed, newresearch/vrrp-no-form-scope.md.Unresolved (recorded in the research note)
preemptduring an election yet:computeVrrp()elects from scratch each pass andgroupState()is called only by tests. The flag is stored, printed and validated; no packet changes - that would be a convergence change, which the plan excludes.show vrrphas no column for it. IOS 15.xshow vrrp briefprintsP/blank inPre; IOS XE 16/17 printsY/Nin the same column, and Cisco's own 15.x page carries both sentences. One transcript from the imitated platform would settle which.no vrrp <vrid> ip <addr>(remove one virtual address) is still refused as unrecognized - a separate question.Gates
node scripts/syntax-check.js: 411 files OKnpm test: 338 suites, 11,758 assertions, 0 failednoline that names a setting undoes the setting, not the groupc503ed599b9794f8cb1c